From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F123C4338F for ; Wed, 4 Aug 2021 09:38:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4E11360F22 for ; Wed, 4 Aug 2021 09:38:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237092AbhHDJi1 (ORCPT ); Wed, 4 Aug 2021 05:38:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237101AbhHDJiX (ORCPT ); Wed, 4 Aug 2021 05:38:23 -0400 Received: from mail-io1-xd2a.google.com (mail-io1-xd2a.google.com [IPv6:2607:f8b0:4864:20::d2a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B560C061799; Wed, 4 Aug 2021 02:38:10 -0700 (PDT) Received: by mail-io1-xd2a.google.com with SMTP id y1so1666594iod.10; Wed, 04 Aug 2021 02:38:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=IfelQpsCk2dlINF9FFCZTuni2ibPe6+4gIAnhuY21DA=; b=UXTmtNB5ldrjppN/daDbCwyPoNdxb4/Se8Y8s+f5aIGsnRxCW04IBvBCjAz00PWDAP e7nfljw2k7P7USYvwEuh87MwSkoAW4XtUYf6i9fwOo0uWZUSj6o/beveNqX+ILF5AGYQ JZWqeTyMcP86EwqFB5m+GibJvUwhy/GKMyL7mSvaOzgA2OTakU3i90o5tvtVRzTy1wLu UXv20zGzK2cF8TtAD/G40jmdvHVTnhLh3P2y1B8mUK39Rqpe3MCBDJuLBtGkcNfZciL4 mUzMZ2h3y0h3/0MagNDBuk+l5bw93PqX9NJRAeJD/D+CKkpu9u/Nq233HAKzLlrKovzE stVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=IfelQpsCk2dlINF9FFCZTuni2ibPe6+4gIAnhuY21DA=; b=djdvPTDrWh1ecRN1+H+sDcL9fQPYGxxgvnN5vl7pcAe26YNoGfrgAJjDOwXhsK6aO6 /CtAdd9c8L98RHYZ0TRi4PPKwRC4gTk5MAjdaxmh9Hyer0Px5KIifxlsXxXM3mNLlm9h JczFD9QDfY932JMD51E6AaOnuvqBCcdz2QREn10M8NSVDRC74VfktGgwwBRXwcVeYCIP sTuhol2zwgKpDfF2RJohhLBgSHN4Kl2AHuOTguWQrtEmVah1hzWyLOPH9G5Oqr37tCaQ n6jmDezDHYQ37jkhUtdqgBDnr4nhu5MC02dhjle2ZBHl6uo63rYFoX+n/8tnHXpHS5BX 7NHg== X-Gm-Message-State: AOAM530XshxJoqxJu6Mvopr8TmJvFgZHS15qlNxzllvqZMYr5NHj1nGl lDjVF1/6CA8R7ANAVygwjoZrZI3SW+CdRKc1mn0= X-Google-Smtp-Source: ABdhPJy4d09HfTysXpHb3wis6SDAF0TjPV6izp1uKTttA1IPmLWsRseIQeRndBfkN1Ovcz4WC8iZaUke8E5xeQTPgXs= X-Received: by 2002:a5d:8e19:: with SMTP id e25mr673746iod.175.1628069889790; Wed, 04 Aug 2021 02:38:09 -0700 (PDT) MIME-Version: 1.0 References: <20210803084456.198-1-alistair@alistair23.me> <20210803084456.198-2-alistair@alistair23.me> In-Reply-To: From: Alistair Francis Date: Wed, 4 Aug 2021 19:37:42 +1000 Message-ID: Subject: Re: [PATCH v8 02/11] mfd: sy7636a: Initial commit To: Lee Jones Cc: Alistair Francis , Rob Herring , lgirdwood@gmail.com, Mark Brown , dl-linux-imx , Sascha Hauer , devicetree , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Aug 4, 2021 at 7:06 PM Lee Jones wrote: > > On Wed, 04 Aug 2021, Alistair Francis wrote: > > > On Tue, Aug 3, 2021 at 11:16 PM Lee Jones wrote: > > > > > > On Tue, 03 Aug 2021, Alistair Francis wrote: > > > > > > > Initial support for the Silergy SY7636A Power Management chip. > > > > > > > > Signed-off-by: Alistair Francis > > > > --- > > > > drivers/mfd/Kconfig | 9 +++++ > > > > drivers/mfd/Makefile | 1 + > > > > drivers/mfd/sy7636a.c | 72 +++++++++++++++++++++++++++++++++= ++++ > > > > include/linux/mfd/sy7636a.h | 45 +++++++++++++++++++++++ > > > > 4 files changed, 127 insertions(+) > > > > create mode 100644 drivers/mfd/sy7636a.c > > > > create mode 100644 include/linux/mfd/sy7636a.h > > > > > > > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > > > > index 6a3fd2d75f96..b82208f0c79c 100644 > > > > --- a/drivers/mfd/Kconfig > > > > +++ b/drivers/mfd/Kconfig > > > > @@ -1352,6 +1352,15 @@ config MFD_SYSCON > > > > Select this option to enable accessing system control regis= ters > > > > via regmap. > > > > > > > > +config MFD_SY7636A > > > > + tristate "Silergy SY7636A Power Management IC" > > > > + select MFD_CORE > > > > + select REGMAP_I2C > > > > + depends on I2C > > > > + help > > > > + Select this option to enable support for the Silergy SY7636= A > > > > + Power Management IC. > > > > + > > > > config MFD_DAVINCI_VOICECODEC > > > > tristate > > > > select MFD_CORE > > > > diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile > > > > index 8116c19d5fd4..cbe581e87fa9 100644 > > > > --- a/drivers/mfd/Makefile > > > > +++ b/drivers/mfd/Makefile > > > > @@ -266,6 +266,7 @@ obj-$(CONFIG_MFD_KHADAS_MCU) +=3D khadas-m= cu.o > > > > obj-$(CONFIG_MFD_ACER_A500_EC) +=3D acer-ec-a500.o > > > > obj-$(CONFIG_MFD_QCOM_PM8008) +=3D qcom-pm8008.o > > > > > > > > +obj-$(CONFIG_MFD_SY7636A) +=3D sy7636a.o > > > > obj-$(CONFIG_SGI_MFD_IOC3) +=3D ioc3.o > > > > obj-$(CONFIG_MFD_SIMPLE_MFD_I2C) +=3D simple-mfd-i2c.o > > > > obj-$(CONFIG_MFD_INTEL_M10_BMC) +=3D intel-m10-bmc.o > > > > diff --git a/drivers/mfd/sy7636a.c b/drivers/mfd/sy7636a.c > > > > new file mode 100644 > > > > index 000000000000..f3ff93c7395d > > > > --- /dev/null > > > > +++ b/drivers/mfd/sy7636a.c > > > > @@ -0,0 +1,72 @@ > > > > +// SPDX-License-Identifier: GPL-2.0+ > > > > +/* > > > > + * MFD parent driver for SY7636A chip > > > > + * > > > > + * Copyright (C) 2021 reMarkable AS - http://www.remarkable.com/ > > > > + * > > > > + * Authors: Lars Ivar Miljeteig > > > > + * Alistair Francis > > > > + * > > > > + * Based on the lp87565 driver by Keerthy > > > > + */ > > > > + > > > > +#include > > > > +#include > > > > +#include > > > > +#include > > > > + > > > > +#include > > > > + > > > > +static const struct regmap_config sy7636a_regmap_config =3D { > > > > + .reg_bits =3D 8, > > > > + .val_bits =3D 8, > > > > +}; > > > > + > > > > +static const struct mfd_cell sy7636a_cells[] =3D { > > > > + { .name =3D "sy7636a-regulator", }, > > > > > > What kind of regulator is 'vcom'? LDO? DCDC? > > > > Both I guess: > > > > "SY7636A is a single-chip power management IC (PMIC) designed for > > electronic paper display (EPD) applications. The device supports panel > > sizes up to 9.7 inches and larger. The device integrates two > > high-efficiency DC-DC boost converters, which are boosted to 25V and > > -20V by two charge pumps to provide gate driver power for the panel. > > Two tracking LDOs create a =C2=B115V source driver power supply that > > supports output currents up to 200mA. SY7636A also provides I2C > > interface control for specific panel requirements" > > Is there a datasheet I could look at? I have managed to find this: https://www.silergy.com/cn/productsview/SY7636ARMC which is in Chinese. The datasheet is behind a login page unfortunately. Alistair > > -- > Lee Jones [=E6=9D=8E=E7=90=BC=E6=96=AF] > Senior Technical Lead - Developer Services > Linaro.org =E2=94=82 Open source software for Arm SoCs > Follow Linaro: Facebook | Twitter | Blog