From mboxrd@z Thu Jan 1 00:00:00 1970 From: Viresh Kumar Subject: Re: [PATCH V2 3/3] ARM: SPEAr13xx: Pass DW DMAC platform data from DT Date: Sat, 13 Oct 2012 19:40:53 +0530 Message-ID: References: <142ef9170a2c69657d8a05ac127a9970d7b04965.1350051925.git.viresh.kumar@linaro.org> <2039bc164224b0068bc078b6cd8df6218e754fce.1350051925.git.viresh.kumar@linaro.org> <20121012144837.GE12801@game.jcrosoft.org> <20121012162148.GH12801@game.jcrosoft.org> <20121013064422.GJ12801@game.jcrosoft.org> <20121013122242.GL12801@game.jcrosoft.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Jean-Christophe PLAGNIOL-VILLARD Cc: andriy.shevchenko@linux.intel.com, vinod.koul@intel.com, spear-devel@list.st.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree-discuss@lists.ozlabs.org List-Id: devicetree@vger.kernel.org On 13 October 2012 19:38, Viresh Kumar wrote: > On 13 October 2012 17:52, Jean-Christophe PLAGNIOL-VILLARD > wrote: >> On 14:18 Sat 13 Oct , Viresh Kumar wrote: >>> On Oct 13, 2012 12:16 PM, "Jean-Christophe PLAGNIOL-VILLARD" >>> wrote: >>> > >>> > On 22:42 Fri 12 Oct , Viresh Kumar wrote: >>> > > On 12 October 2012 21:51, Jean-Christophe PLAGNIOL-VILLARD >>> > > wrote: >>> > > >> >> + OF_DEV_AUXDATA("arasan,cf-spear1340", MCIF_CF_BASE, NULL, >>> "cf"), >>> > > >> > ?/ >>> > > >> >>> > > >> Sorry. can't get it :( >>> > > > what is the "cf" as paltfrom data >>> > > >>> > > This is dma bus_id string, which matches with what is passed from dtb. >>> > so pass if via dtb too >>> >>> Yes. Already passed in 13xx.dtsi. Probably some confusion here. What i meant to say here is, dmac's DT slave info has a node for cf and cf driver expects this string to come via platform data currently. >> so why do you keep the AUXDATA > > Because the compact flash driver expects it via platform data and not > via DT. yes, it > can be changed, but that wasn't the target of this patchset. If it has > to be done, then > it has to be done separately by ST guys. -- viresh