From: Andrew Bresticker <abrestic@chromium.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Padmavathi Venna <padma.v@samsung.com>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
alsa-devel@alsa-project.org, padma.kvr@gmail.com,
sbkim73@samsung.com, Kukjin Kim <kgene.kim@samsung.com>,
"broonie@kernel.org" <broonie@kernel.org>,
Mike Turquette <mturquette@linaro.org>
Subject: Re: [PATCH V4 2/4] clk: samsung: register audio subsystem clocks using common clock framework
Date: Mon, 3 Jun 2013 16:46:09 -0700 [thread overview]
Message-ID: <CAL1qeaEkomoDQPyGqqLL-WzoLS=nND-eXeRAGD2HpoV6WW3yRQ@mail.gmail.com> (raw)
In-Reply-To: <CAD=FV=XOfi=BsaF+-96SqKwyiwP9h0h3MCJxJ+qWNKaGoP=CcA@mail.gmail.com>
>> +static unsigned long reg_save[][2] = {
>> + {ASS_CLK_SRC, 0},
>> + {ASS_CLK_DIV, 0},
>> + {ASS_CLK_GATE, 0},
>> +};
>> +
>> +/* list of all parent clock list */
>> +static const char *mout_audss_p[] = { "fin_pll", "fout_epll" };
>
> I think this is supposed to be "xxti" which might or might not be
> "fin_pll". In the exynos4 code these are two different clocks that
> are chosen by OM[0]. I'd bet that 99% of the time they are the same,
> but it seems better to use "xxti".
OM[0] also appears to mux the input here between "xxti" and "xusbxti"
as well. So this should probably remain "fin_pll".
> At the moment the 5250 code doesn't expose "xxti". It probably
> should. Andrew (CCed) is looking at this.
Yes, xxti is used directly elsewhere (SPI and UART, from what I can
tell), but not here.
-Andrew
next prev parent reply other threads:[~2013-06-03 23:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 5:19 [PATCH V4 0/4] clk: Samsung: audss: Register audio subsytem clocks using common clk framework Padmavathi Venna
2013-06-03 5:19 ` [PATCH V4 1/4] ARM: samsung: use #include for all device trees Padmavathi Venna
2013-06-03 5:19 ` [PATCH V4 2/4] clk: samsung: register audio subsystem clocks using common clock framework Padmavathi Venna
2013-06-03 20:10 ` Doug Anderson
2013-06-03 23:46 ` Andrew Bresticker [this message]
2013-06-04 0:07 ` Doug Anderson
2013-06-03 5:19 ` [PATCH V4 3/4] ARM: dts: add Exynos audio subsystem clock controller node Padmavathi Venna
2013-06-03 20:13 ` Doug Anderson
2013-06-04 4:25 ` Padma Venkat
2013-06-04 15:15 ` Doug Anderson
2013-06-03 5:19 ` [PATCH V4 4/4] ARM: dts: add clock provider information for i2s controllers in Exynos5250 Padmavathi Venna
2013-06-03 20:18 ` Doug Anderson
2013-06-04 4:28 ` Padma Venkat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL1qeaEkomoDQPyGqqLL-WzoLS=nND-eXeRAGD2HpoV6WW3yRQ@mail.gmail.com' \
--to=abrestic@chromium.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dianders@chromium.org \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=padma.kvr@gmail.com \
--cc=padma.v@samsung.com \
--cc=sbkim73@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).