devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Bresticker <abrestic@chromium.org>
To: Tomasz Figa <t.figa@samsung.com>
Cc: Padmavathi Venna <padma.v@samsung.com>,
	linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
	"devicetree-discuss@lists.ozlabs.org"
	<devicetree-discuss@lists.ozlabs.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	alsa-devel@alsa-project.org, Padma Venkat <padma.kvr@gmail.com>,
	sbkim73@samsung.com, "broonie@kernel.org" <broonie@kernel.org>,
	Kukjin Kim <kgene.kim@samsung.com>,
	Mike Turquette <mturquette@linaro.org>,
	Doug Anderson <dianders@chromium.org>
Subject: Re: [PATCH 2/4] clk: exynos-audss: allow input clocks to be specified in device tree
Date: Wed, 14 Aug 2013 13:11:18 -0700	[thread overview]
Message-ID: <CAL1qeaFZH+3D26Vis4rUqCKK6Un-eHBv1wckYpPR-fac_gz6qA@mail.gmail.com> (raw)
In-Reply-To: <1610421.OFFn8rqlxt@amdc1227>

Hi Tomasz,

> Well, this is basically how it should be done, but in current state of
> clock core I can see a problem: can we really rely on the order of clock
> initialization? I mean, we can't defer initialization of particular clock
> controller until all external clocks it needs are available, because there
> is no probing involved here.

Right, we can't.  The reason I added the device-tree lookup of input
clocks was because Exynos5420 has different names for several of the
input clocks to the audio block.  We already need a separate
compatibility string because of the ADMA clock, so we could just use
that to determine the parent clock names.  It's not ideal, but it's a
workaround for the initialization order issue.  Thoughts?

Thanks,
Andrew

  parent reply	other threads:[~2013-08-14 20:11 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-10 12:11 [PATCH 0/4] clk: Samsung: audss: Add support for Exynos5420 Padmavathi Venna
2013-07-10 12:11 ` [PATCH 1/4] clk: exynos-audss: add support for Exynos 5420 Padmavathi Venna
2013-07-10 12:11 ` [PATCH 2/4] clk: exynos-audss: allow input clocks to be specified in device tree Padmavathi Venna
2013-07-22 16:28   ` Tomasz Figa
2013-07-22 18:15     ` Mike Turquette
2013-07-22 19:42       ` Tomasz Figa
2013-07-23 10:25         ` Padma Venkat
2013-08-14 20:11     ` Andrew Bresticker [this message]
2013-07-10 12:11 ` [PATCH 3/4] ARM: dts: Correct the /include entry on exynos5420 dtsi file Padmavathi Venna
2013-08-18 19:54   ` Kukjin Kim
2013-07-10 12:11 ` [PATCH 4/4] ARM: dts: exynos5420: add audio clock controller Padmavathi Venna
2013-08-18 19:54   ` Kukjin Kim
2013-08-12 10:15 ` [PATCH 0/4] clk: Samsung: audss: Add support for Exynos5420 Padma Venkat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAL1qeaFZH+3D26Vis4rUqCKK6Un-eHBv1wckYpPR-fac_gz6qA@mail.gmail.com \
    --to=abrestic@chromium.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=dianders@chromium.org \
    --cc=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=mturquette@linaro.org \
    --cc=padma.kvr@gmail.com \
    --cc=padma.v@samsung.com \
    --cc=sbkim73@samsung.com \
    --cc=t.figa@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).