From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Bresticker Subject: Re: [PATCH v4 1/2] watchdog: ImgTec PDC Watchdog Timer Driver Date: Thu, 20 Nov 2014 10:09:02 -0800 Message-ID: References: <1416488526-22079-1-git-send-email-jude.abraham@imgtec.com> <1416488526-22079-2-git-send-email-jude.abraham@imgtec.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <1416488526-22079-2-git-send-email-jude.abraham-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jude Abraham Cc: "wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org" , "linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org" , Ezequiel Garcia , James Hartley , James Hogan , Naidu Tellapati , Arul Ramasamy , "linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: devicetree@vger.kernel.org Jude, Naidu, On Thu, Nov 20, 2014 at 5:02 AM, wrote: > From: Jude Abraham > > This commit adds support for ImgTec PowerDown Controller Watchdog Timer. > > Signed-off-by: Jude Abraham > Signed-off-by: Naidu Tellapati Reviewed-by: Andrew Bresticker Two small comments you may want to fix if you need to re-spin the series though: > +static struct watchdog_info pdc_wdt_info = { > + .options = WDIOF_SETTIMEOUT | > + WDIOF_KEEPALIVEPING | > + WDIOF_MAGICCLOSE, > + .identity = "IMG PDC Watchdog", > +}; Inconsistent spacing. > + ret = watchdog_init_timeout(&pdc_wdt->wdt_dev, timeout, &pdev->dev); > + if (ret < 0) > + pdc_wdt->wdt_dev.timeout = pdc_wdt->wdt_dev.max_timeout; Maybe print an error here? -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html