* Re: [PATCH v4 1/2] watchdog: ImgTec PDC Watchdog Timer Driver [not found] ` <1416488526-22079-2-git-send-email-jude.abraham-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org> @ 2014-11-20 18:09 ` Andrew Bresticker [not found] ` <CAL1qeaGWK+ok1d48i_wrnLdfALjFCRiPZiwwiYUeBSdNdDkHEw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 0 siblings, 1 reply; 2+ messages in thread From: Andrew Bresticker @ 2014-11-20 18:09 UTC (permalink / raw) To: Jude Abraham Cc: wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org, linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org, Ezequiel Garcia, James Hartley, James Hogan, Naidu Tellapati, Arul Ramasamy, linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Jude, Naidu, On Thu, Nov 20, 2014 at 5:02 AM, <jude.abraham-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org> wrote: > From: Jude Abraham <Jude.Abraham-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org> > > This commit adds support for ImgTec PowerDown Controller Watchdog Timer. > > Signed-off-by: Jude Abraham <Jude.Abraham-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org> > Signed-off-by: Naidu Tellapati <Naidu.Tellapati-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org> Reviewed-by: Andrew Bresticker <abrestic-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> Two small comments you may want to fix if you need to re-spin the series though: > +static struct watchdog_info pdc_wdt_info = { > + .options = WDIOF_SETTIMEOUT | > + WDIOF_KEEPALIVEPING | > + WDIOF_MAGICCLOSE, > + .identity = "IMG PDC Watchdog", > +}; Inconsistent spacing. > + ret = watchdog_init_timeout(&pdc_wdt->wdt_dev, timeout, &pdev->dev); > + if (ret < 0) > + pdc_wdt->wdt_dev.timeout = pdc_wdt->wdt_dev.max_timeout; Maybe print an error here? -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 2+ messages in thread
[parent not found: <CAL1qeaGWK+ok1d48i_wrnLdfALjFCRiPZiwwiYUeBSdNdDkHEw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* RE: [PATCH v4 1/2] watchdog: ImgTec PDC Watchdog Timer Driver [not found] ` <CAL1qeaGWK+ok1d48i_wrnLdfALjFCRiPZiwwiYUeBSdNdDkHEw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2014-11-21 5:53 ` Naidu Tellapati 0 siblings, 0 replies; 2+ messages in thread From: Naidu Tellapati @ 2014-11-21 5:53 UTC (permalink / raw) To: Andrew Bresticker, Jude Abraham Cc: wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org, linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org, Ezequiel Garcia, James Hartley, James Hogan, Arul Ramasamy, linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Hi Andrew, Many thanks for the review. > On Thu, Nov 20, 2014 at 5:02 AM, <jude.abraham-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org> wrote: >> From: Jude Abraham <Jude.Abraham-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org> >> >> This commit adds support for ImgTec PowerDown Controller Watchdog Timer. >> >> Signed-off-by: Jude Abraham <Jude.Abraham-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org> >> Signed-off-by: Naidu Tellapati <Naidu.Tellapati-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org> > Reviewed-by: Andrew Bresticker <abrestic-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> > Two small comments you may want to fix if you need to re-spin the series though: Will address following two review comments and submit new Patch set today. >> +static struct watchdog_info pdc_wdt_info = { >> + .options = WDIOF_SETTIMEOUT | >> + WDIOF_KEEPALIVEPING | >> + WDIOF_MAGICCLOSE, >> + .identity = "IMG PDC Watchdog", >> +}; > Inconsistent spacing. >> + ret = watchdog_init_timeout(&pdc_wdt->wdt_dev, timeout, &pdev->dev); >> + if (ret < 0) >> + pdc_wdt->wdt_dev.timeout = pdc_wdt->wdt_dev.max_timeout; > Maybe print an error here? Regards, Naidu. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-11-21 5:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1416488526-22079-1-git-send-email-jude.abraham@imgtec.com>
[not found] ` <1416488526-22079-2-git-send-email-jude.abraham@imgtec.com>
[not found] ` <1416488526-22079-2-git-send-email-jude.abraham-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>
2014-11-20 18:09 ` [PATCH v4 1/2] watchdog: ImgTec PDC Watchdog Timer Driver Andrew Bresticker
[not found] ` <CAL1qeaGWK+ok1d48i_wrnLdfALjFCRiPZiwwiYUeBSdNdDkHEw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-21 5:53 ` Naidu Tellapati
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).