From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Bresticker Subject: Re: [PATCH v4 5/5] arm: exynos: Add MCPM call-back functions Date: Fri, 2 May 2014 11:23:51 -0700 Message-ID: References: <1398528348-21214-6-git-send-email-a.kesavan@samsung.com> <1399044359-15784-1-git-send-email-a.kesavan@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Nicolas Pitre Cc: Abhilash Kesavan , Dave Martin , Lorenzo Pieralisi , daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , Kukjin Kim , Tomasz Figa , thomas.ab-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, inderpal.s-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, Mark Rutland , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Grant Likely , Rob Herring , Will Deacon , Arnd Bergmann , Abhilash Kesavan List-Id: devicetree@vger.kernel.org >> + /* >> + * TODO: Turn off the clusters when all cores in the cluster >> + * are down to achieve significant power savings. >> + */ > > This comment should actually be located right after the > "if (exynos_cluster_unused(cluster))" above. That is where the cluster > control should be applied, assuming it'll be effective only when WFI is > executed. Correct me if I'm wrong Samsung folks, but I thought it was not possible to apply cluster power control from a CPU within the cluster being powered down, i.e. a CPU in the other cluster must be the one to apply the cluster power control to power down the outbound cluster. -Andrew -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html