From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leela Krishna Amudala Subject: Re: [PATCH V4 1/3] ARM: dts: Add pmu sysreg node to Exynos5 dtsi file Date: Wed, 30 Oct 2013 15:39:09 +0530 Message-ID: References: <1383126673-29033-1-git-send-email-l.krishna@samsung.com> <1383126673-29033-2-git-send-email-l.krishna@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: In-Reply-To: Sender: linux-samsung-soc-owner@vger.kernel.org To: Sachin Kamat Cc: Leela Krishna Amudala , linux-samsung-soc , Kukjin Kim , Wim Van Sebroeck , Tomasz Figa , devicetree@vger.kernel.org, Doug Anderson , linux-watchdog@vger.kernel.org, cpgs@samsung.com List-Id: devicetree@vger.kernel.org Hi, On Wed, Oct 30, 2013 at 3:22 PM, Sachin Kamat wrote: > Hi Leela, > > On 30 October 2013 15:21, Leela Krishna Amudala wrote: >> This patch adds pmusysreg node to Exynos5 dtsi file to handle PMU >> register accesses in a centralized way using syscon driver >> >> Signed-off-by: Leela Krishna Amudala >> --- >> arch/arm/boot/dts/exynos5.dtsi | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/arch/arm/boot/dts/exynos5.dtsi b/arch/arm/boot/dts/exynos5.dtsi >> index e52b038..918e732 100644 >> --- a/arch/arm/boot/dts/exynos5.dtsi >> +++ b/arch/arm/boot/dts/exynos5.dtsi >> @@ -106,4 +106,9 @@ >> #size-cells = <0>; >> status = "disabled"; >> }; >> + >> + pmu_sys_reg: pmusysreg@1004000 { >> + compatible = "syscon"; >> + reg = <0x10040000 0x5000>; >> + }; >> }; > > Had a look at this in a bit detail and found the following. > The register base address for this block on 5250 and 5420 as per the > TRM is 0x10050000. > > Also, the binding document specifies the naming convention. According > to it this node > should like: > > sys_reg: sysreg@10050000 { > compatible = "samsung,exynos5-sysreg", "syscon"; > reg = <0x10050000 0x500>; > }; > I know, but here my intention is not to regmap system register (0x10050000), but instead PMU register (0x10040000), Hence created this node. ~Leela Krishna > -- > With warm regards, > Sachin > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html