From: Leela Krishna Amudala <l.krishna@samsung.com>
To: Tomasz Figa <tomasz.figa@gmail.com>
Cc: Leela Krishna Amudala <l.krishna@samsung.com>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
Kukjin Kim <kgene.kim@samsung.com>,
Wim Van Sebroeck <wim@iguana.be>,
Tomasz Figa <t.figa@samsung.com>,
devicetree@vger.kernel.org,
Douglas Anderson <dianders@chromium.org>,
linux-watchdog@vger.kernel.org, cpgs@samsung.com,
Sachin Kamat <sachin.kamat@linaro.org>
Subject: Re: [PATCH V7 2/3] ARM: dts: update watchdog device nodes for Exynos5250 and Exynos5420
Date: Tue, 12 Nov 2013 11:27:59 +0530 [thread overview]
Message-ID: <CAL1wa8fe+eRsJ8VsqmCCtsp_ipLK84wNYZ0d0PBJyHUW3zSriA@mail.gmail.com> (raw)
In-Reply-To: <10330347.YPtX4Jly4T@flatron>
Hi Tomasz,
On Mon, Nov 11, 2013 at 6:36 PM, Tomasz Figa <tomasz.figa@gmail.com> wrote:
> Hi Leela,
>
> On Monday 11 of November 2013 18:14:56 Leela Krishna Amudala wrote:
>> In Exynos5 series SoCs, PMU has registers to enable/disable mask/unmask
>> watchdog timer which is not the case with s3c series SoCs so, there is a
>> need to have different compatible names for watchdog to handle these pmu
>> registers access.
>>
>> Hence this patch removes watchdog node from Exynos5.dtsi common file and
>> make it separate by updating existing node in Exynos5250 and adding new node
>> to Exynos5420. This patch also makes the watchdog node enabled by default
>>
>> Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
>> ---
>> arch/arm/boot/dts/exynos5.dtsi | 7 -------
>> arch/arm/boot/dts/exynos5250.dtsi | 6 +++++-
>> arch/arm/boot/dts/exynos5420.dtsi | 9 +++++++++
>> 3 files changed, 14 insertions(+), 8 deletions(-)
>
> This patch should go as the last in this series, because otherwise it
> would change DTS files to use compatible values that are not yet
> supported.
>
Okay, will make it as last patch in the series
Best Wishes,
Leela Krishna
> The patch itself is fine, so
>
> Reviewed-by: Tomasz Figa <t.figa@samsung.com>
>
> Best regards,
> Tomasz
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-11-12 5:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-11 12:44 [PATCH V7 0/3] Add watchdog DT nodes and use syscon regmap interfac to configure pmu registers Leela Krishna Amudala
2013-11-11 12:44 ` [PATCH V7 1/3] ARM: dts: Add pmu sysreg node to exynos5250 and exynos5420 dtsi files Leela Krishna Amudala
[not found] ` <1384173897-16106-2-git-send-email-l.krishna-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-11-11 13:00 ` Tomasz Figa
[not found] ` <1384173897-16106-1-git-send-email-l.krishna-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-11-11 12:44 ` [PATCH V7 2/3] ARM: dts: update watchdog device nodes for Exynos5250 and Exynos5420 Leela Krishna Amudala
[not found] ` <1384173897-16106-3-git-send-email-l.krishna-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-11-11 13:06 ` Tomasz Figa
2013-11-12 5:57 ` Leela Krishna Amudala [this message]
2013-11-11 12:44 ` [PATCH V7 3/3] watchdog: s3c2410_wdt: add device tree support and use syscon regmap interface to configure pmu register Leela Krishna Amudala
2013-11-11 13:23 ` Tomasz Figa
2013-11-12 6:00 ` Leela Krishna Amudala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL1wa8fe+eRsJ8VsqmCCtsp_ipLK84wNYZ0d0PBJyHUW3zSriA@mail.gmail.com \
--to=l.krishna@samsung.com \
--cc=cpgs@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=kgene.kim@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
--cc=t.figa@samsung.com \
--cc=tomasz.figa@gmail.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).