devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 3/3] ARM: dts: NSP: Add PWM Support to DT
  2016-03-01 17:42 [PATCH 0/3] pwm support for Broadcom iProc SoC's Yendapally Reddy Dhananjaya Reddy
@ 2016-03-01 17:42 ` Yendapally Reddy Dhananjaya Reddy
  2016-03-01 20:25   ` Arnd Bergmann
  0 siblings, 1 reply; 4+ messages in thread
From: Yendapally Reddy Dhananjaya Reddy @ 2016-03-01 17:42 UTC (permalink / raw)
  To: Thierry Reding, Rob Herring, Pawel Moll, Mark Rutland,
	Ian Campbell, Kumar Gala, Russell King, Ray Jui, Scott Branden,
	Jon Mason
  Cc: linux-pwm, devicetree, linux-kernel, linux-arm-kernel,
	bcm-kernel-feedback-list, Yendapally Reddy Dhananjaya Reddy

Add PWM support to the device tree for the Broadcom Northstar Plus SoC.

Signed-off-by: Yendapally Reddy Dhananjaya Reddy <yendapally.reddy@broadcom.com>
---
 arch/arm/boot/dts/bcm-nsp.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/bcm-nsp.dtsi b/arch/arm/boot/dts/bcm-nsp.dtsi
index def9e78..f9c8341 100644
--- a/arch/arm/boot/dts/bcm-nsp.dtsi
+++ b/arch/arm/boot/dts/bcm-nsp.dtsi
@@ -206,6 +206,14 @@
 			brcm,nand-has-wp;
 		};
 
+		pwm: pwm@31000 {
+			compatible = "brcm,iproc-pwm";
+			reg = <0x31000 0x28>;
+			clocks = <&osc>;
+			#pwm-cells = <3>;
+			status = "disabled";
+		};
+
 		ccbtimer0: timer@34000 {
 			compatible = "arm,sp804";
 			reg = <0x34000 0x1000>;
-- 
2.1.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 3/3] ARM: dts: NSP: Add PWM Support to DT
  2016-03-01 17:42 ` [PATCH 3/3] ARM: dts: NSP: Add PWM Support to DT Yendapally Reddy Dhananjaya Reddy
@ 2016-03-01 20:25   ` Arnd Bergmann
  0 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2016-03-01 20:25 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: Yendapally Reddy Dhananjaya Reddy, Thierry Reding, Rob Herring,
	Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Russell King,
	Ray Jui, Scott Branden, Jon Mason, linux-pwm, devicetree,
	linux-kernel, bcm-kernel-feedback-list

On Tuesday 01 March 2016 12:42:49 Yendapally Reddy Dhananjaya Reddy wrote:
>                 };
>  
> +               pwm: pwm@31000 {
> +                       compatible = "brcm,iproc-pwm";
> +                       reg = <0x31000 0x28>;
> +                       clocks = <&osc>;
> +                       #pwm-cells = >;
> +                       status = "disabled";
> +               };
> 

Should this also list "brcm,kona-pwm" as compatible? From patch
1, it sounds like that was the original one.

	Arnd

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 3/3] ARM: dts: NSP: Add PWM Support to DT
@ 2016-03-02 14:52 Yendapally Reddy Dhananjaya Reddy
       [not found] ` <CAL2FKYkoXFm_pG6inxJqwkRqEK-TsMT2ndy4fgvQG1wT6AZ03Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
  0 siblings, 1 reply; 4+ messages in thread
From: Yendapally Reddy Dhananjaya Reddy @ 2016-03-02 14:52 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: linux-arm-kernel, Thierry Reding, Rob Herring, Pawel Moll,
	Mark Rutland, Ian Campbell, Kumar Gala, Russell King, Ray Jui,
	Scott Branden, Jon Mason, linux-pwm, devicetree, linux-kernel,
	BCM Kernel Feedback

On Wed, Mar 2, 2016 at 1:55 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Tuesday 01 March 2016 12:42:49 Yendapally Reddy Dhananjaya Reddy wrote:
>>                 };
>>
>> +               pwm: pwm@31000 {
>> +                       compatible = "brcm,iproc-pwm";
>> +                       reg = <0x31000 0x28>;
>> +                       clocks = <&osc>;
>> +                       #pwm-cells = >;
>> +                       status = "disabled";
>> +               };
>>
>
> Should this also list "brcm,kona-pwm" as compatible? From patch
> 1, it sounds like that was the original one.

Arnd,

The NSP is a iProc based SoC and the pwm controller register offsets are
slightly differ with the kona pwm controller. The compatible will be either
"brcm,kona-pwm" or "brcm,iproc-pwm".

>
>         Arnd

Regards
Dhananjay

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 3/3] ARM: dts: NSP: Add PWM Support to DT
       [not found] ` <CAL2FKYkoXFm_pG6inxJqwkRqEK-TsMT2ndy4fgvQG1wT6AZ03Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2016-03-02 15:28   ` Arnd Bergmann
  0 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2016-03-02 15:28 UTC (permalink / raw)
  To: Yendapally Reddy Dhananjaya Reddy
  Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Thierry Reding,
	Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
	Russell King, Ray Jui, Scott Branden, Jon Mason,
	linux-pwm-u79uwXL29TY76Z2rM5mHXA,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA, BCM Kernel Feedback

On Wednesday 02 March 2016 20:22:01 Yendapally Reddy Dhananjaya Reddy wrote:
> On Wed, Mar 2, 2016 at 1:55 AM, Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org> wrote:
> > On Tuesday 01 March 2016 12:42:49 Yendapally Reddy Dhananjaya Reddy wrote:
> >>                 };
> >>
> >> +               pwm: pwm@31000 {
> >> +                       compatible = "brcm,iproc-pwm";
> >> +                       reg = <0x31000 0x28>;
> >> +                       clocks = <&osc>;
> >> +                       #pwm-cells = >;
> >> +                       status = "disabled";
> >> +               };
> >>
> >
> > Should this also list "brcm,kona-pwm" as compatible? From patch
> > 1, it sounds like that was the original one.
> 
> Arnd,
> 
> The NSP is a iProc based SoC and the pwm controller register offsets are
> slightly differ with the kona pwm controller. The compatible will be either
> "brcm,kona-pwm" or "brcm,iproc-pwm".

Ok, got it, thanks for the explanation.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-03-02 15:28 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-02 14:52 [PATCH 3/3] ARM: dts: NSP: Add PWM Support to DT Yendapally Reddy Dhananjaya Reddy
     [not found] ` <CAL2FKYkoXFm_pG6inxJqwkRqEK-TsMT2ndy4fgvQG1wT6AZ03Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-02 15:28   ` Arnd Bergmann
  -- strict thread matches above, loose matches on Subject: below --
2016-03-01 17:42 [PATCH 0/3] pwm support for Broadcom iProc SoC's Yendapally Reddy Dhananjaya Reddy
2016-03-01 17:42 ` [PATCH 3/3] ARM: dts: NSP: Add PWM Support to DT Yendapally Reddy Dhananjaya Reddy
2016-03-01 20:25   ` Arnd Bergmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).