Re: [PATCH 4/7] USB chipidea: introduce dual role mode pdata flags

[Peter Chen <hzpeterchen-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

On Mon, Jun 3, 2013 at 8:37 PM, Alexander Shishkin
<alexander.shishkin-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> wrote:
> Michael Grzeschik <mgr-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> writes:
>
>> From: Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
>>
>> Even if a chipidea core is otg capable the board may not. This allows
>
> "may not be"
>
>> to explicitly set the core to host/peripheral mode. Without these
>> flags the driver falls back to the old behaviour.
>>
>> Signed-off-by: Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
>> ---
>
> [snip]
>
>> +     if (!ci->platdata->dr_mode)
>> +             ci->platdata->dr_mode = of_usb_get_dr_mode(dev->of_node);
>
> same as previous one, let's keep it in the platform.

Alex, have you made the conclusion with Felipe, whether we need DT support
at core driver to handle such kinds of things or use platform data is ok?
Last time, I remember he disagreed the way this patch uses.

--
BR,
Peter Chen
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html