devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Y Vo <yvo@apm.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, Phong Vo <pvo@apm.com>,
	Toan Le <toanle@apm.com>, Loc Ho <lho@apm.com>,
	Feng Kan <fkan@apm.com>, Quan Nguyen <qnguyen@apm.com>,
	Duc Dang <dhdang@apm.com>, patches <patches@apm.com>
Subject: Re: [PATCH 2/2] Documentation: gpio: Update description for X-Gene standby GPIO controller DTS binding
Date: Fri, 11 Sep 2015 18:24:47 +0700	[thread overview]
Message-ID: <CAL4ahLepjn-VG9WCLEovzjwc=8fpncP6xTS68gRO2VtVaEDc1g@mail.gmail.com> (raw)
In-Reply-To: <11539535.sS04eUgSdg@wuerfel>

On Fri, Sep 11, 2015 at 4:35 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Friday 11 September 2015 16:22:12 Y Vo wrote:
>>  There are 20 GPIO pins from 0..21. There is no GPIO_DS14 or GPIO_DS15,
>> -only GPIO_DS8..GPIO_DS13 support interrupts. The IRQ mapping
>> +only GPIO_DS8..GPIO_DS13 support external interrupts. The IRQ mapping
>>  is currently 1-to-1 on interrupts 0x28 thru 0x2d.
>> +GPIO pins from GPIO_DS8 to GPIO_DS13 are configured as external interrupt
>> +by default. If one wish not to use any of these pins as external interrupts,
>> +the corresponding interrupt resource for those pins should be removed.
>
> According to this description, I fail to see how one would specify
> a missing interrupt for one of the pins that is not the last one in
> the list.
>
All GPIO_DS8..GPIO_DS13 are configured as external IRQ by default. So
if anyone want to use one of them as gpio mode, they can drop add the
sbgpio node to their DTB board-specific, and remove that GPIO from
interrupts property. As example below I want to leave GPIO_DS8 as gpio
mode, so I remove it as below:

/* Board-specific: exclude GPIO_DS8 to leave it as GPIO */
&sbgpio {
       interrupts =    <0x0 0x29 0x1>,         /* GPIO_DS9 */
                       <0x0 0x2a 0x1>,         /* GPIO_DS10 */
                       <0x0 0x2b 0x1>,         /* GPIO_DS11 */
                       <0x0 0x2c 0x1>,         /* GPIO_DS12 */
                       <0x0 0x2d 0x1>;         /* GPIO_DS13 */
}

>         Arnd

  reply	other threads:[~2015-09-11 11:24 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-11  9:22 [PATCH 0/2] gpio: xgene: add support to configure GPIO line as input, output or external IRQ pin Y Vo
2015-09-11  9:22 ` [PATCH 1/2] " Y Vo
2015-10-02  9:51   ` Linus Walleij
2015-10-02 14:03     ` Y Vo
2015-09-11  9:22 ` [PATCH 2/2] Documentation: gpio: Update description for X-Gene standby GPIO controller DTS binding Y Vo
2015-09-11  9:35   ` Arnd Bergmann
2015-09-11 11:24     ` Y Vo [this message]
2015-09-11 12:46       ` Arnd Bergmann
2015-09-11 14:23         ` Y Vo
2015-09-11 14:47           ` Arnd Bergmann
2015-09-11 15:06             ` Y Vo
2015-09-11 16:45               ` Arnd Bergmann
2015-09-12  5:55                 ` Y Vo
2015-09-14  9:11                   ` Arnd Bergmann
2015-09-14  9:39                     ` Y Vo
2015-09-14 14:47                       ` Arnd Bergmann
2015-09-14 15:06                         ` Y Vo
2015-09-14 15:18                           ` Arnd Bergmann
2015-09-14 15:23                           ` Marc Zyngier
2015-09-16  1:48                             ` Y Vo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAL4ahLepjn-VG9WCLEovzjwc=8fpncP6xTS68gRO2VtVaEDc1g@mail.gmail.com' \
    --to=yvo@apm.com \
    --cc=arnd@arndb.de \
    --cc=devicetree@vger.kernel.org \
    --cc=dhdang@apm.com \
    --cc=fkan@apm.com \
    --cc=lho@apm.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=patches@apm.com \
    --cc=pvo@apm.com \
    --cc=qnguyen@apm.com \
    --cc=toanle@apm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).