From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Michel Hautbois Subject: Re: [alsa-devel] [PATCH] audio: sgtl5000: Add MicBias resistor support in DT Date: Sun, 12 Oct 2014 23:42:47 +0200 Message-ID: References: <1413139149-2485-1-git-send-email-jean-michel.hautbois@vodalys.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Fabio Estevam Cc: Mark Brown , Fabio Estevam , "alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org" , Nicolin Chen , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: devicetree@vger.kernel.org Hi Fabio, 2014-10-12 23:15 GMT+02:00 Fabio Estevam : > On Sun, Oct 12, 2014 at 3:39 PM, Jean-Michel Hautbois > wrote: > >> + if (np) { >> + if (!of_property_read_u32(np, >> + "sgtl5000-micbias-resistor", &value)) { >> + switch (value) { >> + case 1: >> + sgtl5000->micbias_resistor = >> + SGTL5000_MICBIAS_2K; >> + break; >> + case 2: >> + sgtl5000->micbias_resistor = >> + SGTL5000_MICBIAS_4K; >> + break; >> + case 3: >> + sgtl5000->micbias_resistor = >> + SGTL5000_MICBIAS_8K; >> + break; >> + default: >> + sgtl5000->micbias_resistor = >> + SGTL5000_MICBIAS_OFF; >> + dev_err(&client->dev, >> + "Unsuitable MicBias resistor\n"); > > The case 0 should SGTL5000_MICBIAS_OFF and the default should be > SGTL5000_MICBIAS_4K. You are right of course, second version sent. I have a patch wich adds MicBias voltage support too, but it will be on top of this one, is this a problem ? Thanks, JM -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html