From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7764CC433E1 for ; Wed, 19 Aug 2020 19:52:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 440FF207DA for ; Wed, 19 Aug 2020 19:52:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="TDvGe73f" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726868AbgHSTwW (ORCPT ); Wed, 19 Aug 2020 15:52:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726603AbgHSTwT (ORCPT ); Wed, 19 Aug 2020 15:52:19 -0400 Received: from mail-ot1-x342.google.com (mail-ot1-x342.google.com [IPv6:2607:f8b0:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83C1CC061342 for ; Wed, 19 Aug 2020 12:52:18 -0700 (PDT) Received: by mail-ot1-x342.google.com with SMTP id t7so20073749otp.0 for ; Wed, 19 Aug 2020 12:52:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=20eRCPt9U7XROuUscJl4o9bl5XBe7/+hwEOIYHyciSM=; b=TDvGe73fi0mYFcu8gy0zyv7nAwTvj7LZXmceDEUKPP8XfBtwIw8eDnhZKXXW/8lOST i3mwXYbXDDRyFBEBUEFYWxYynj8XahsSAx/k6lpaNmRyovcJDE7Y/1Us5/lAXLoB+fny MXwugodqdfXUpnDdV+YqwtDPcrU39IcwaELeeOIEfQVGHH8qMEJzhHrmfsPm50dMtK8D E2hgWNg9hTGAkp/gDSRS2/SFCteSIRgMdFhm92/90JvBoxi1tgk0nM350xbrUY9djJu/ Vayz78+1GIbV3JXLHBbEvqxWVmcLvT6HCup7VhLEysHQgvZVLA6bXvrYb7L+4t8Mxya5 O2PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=20eRCPt9U7XROuUscJl4o9bl5XBe7/+hwEOIYHyciSM=; b=OwtgjezVv3Icm6TE2jMrk5pnLCTwxARBhU2aeb3f6receLIztZSONnEB7w2nLi1nBP epBC4rRqXlVliKy6HVpMB8PiMRsWi1CVQkAu1AOruTKCWAqa4cgZfo7DOVbMs1PDhAUb 5/UUqIeN5oX09ROxzQl2PvoPCP68MGXqAYkIe15QQEkg9j8zuI0wPLpsXI+kFXaBLX/Z wqXHevU/YBry2qQdyHqyY78kuoSL80E2qBPp1EKDZzG10HXfgI10TzY9/n6e7Em4LkQb fvRJs3h3Bs7/1j3Dr7tUOvlyoetvF4AZAkx6542QVFA9Gi0NlqFg8c60au+uD6HdCBZc Xmwg== X-Gm-Message-State: AOAM533t4vdykxobDz5aiMFY62XRNMzcJIX2KVuQHzFDjoSVqqQHwDEj ZHey+uDjxf41LLuLNxt2Rr3Dv4lITGTrHwGPHxHrTQ== X-Google-Smtp-Source: ABdhPJziBBPPuDZCBcZoysAn7wtSqkMtfGL35ZZB/FJ/a7yXT1Ut5k0YtYAU8hIkSuF0vuVhhtyHAco3tq76syVzuqI= X-Received: by 2002:a9d:6f8f:: with SMTP id h15mr18795170otq.221.1597866737290; Wed, 19 Aug 2020 12:52:17 -0700 (PDT) MIME-Version: 1.0 References: <20200819152120.GA106437@ravnborg.org> <20200819153045.GA18469@pendragon.ideasonboard.com> In-Reply-To: <20200819153045.GA18469@pendragon.ideasonboard.com> From: John Stultz Date: Wed, 19 Aug 2020 12:52:06 -0700 Message-ID: Subject: Re: [PATCH 00/49] DRM driver for Hikey 970 To: Laurent Pinchart Cc: Sam Ravnborg , Neil Armstrong , David Airlie , Wanchun Zheng , linuxarm@huawei.com, dri-devel , Andrzej Hajda , driverdevel , Daniel Borkmann , Mauro Carvalho Chehab , John Fastabend , Xiubin Zhang , Wei Xu , Xinliang Liu , Xinwei Kong , Tomi Valkeinen , Bogdan Togorean , Jakub Kicinski , Laurentiu Palcu , linux-media , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Liwei Cai , Jesper Dangaard Brouer , Manivannan Sadhasivam , Chen Feng , Alexei Starovoitov , "moderated list:DMA BUFFER SHARING FRAMEWORK" , Rob Herring , mauro.chehab@huawei.com, Rob Clark , linux-arm-kernel , Greg Kroah-Hartman , lkml , Liuyao An , Network Development , Rongrong Zou , BPF Mailing List , "David S. Miller" Content-Type: text/plain; charset="UTF-8" Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Aug 19, 2020 at 8:31 AM Laurent Pinchart wrote: > On Wed, Aug 19, 2020 at 05:21:20PM +0200, Sam Ravnborg wrote: > > On Wed, Aug 19, 2020 at 01:45:28PM +0200, Mauro Carvalho Chehab wrote: > > > This patch series port the out-of-tree driver for Hikey 970 (which > > > should also support Hikey 960) from the official 96boards tree: > > > > > > https://github.com/96boards-hikey/linux/tree/hikey970-v4.9 > > > > > > Based on his history, this driver seems to be originally written > > > for Kernel 4.4, and was later ported to Kernel 4.9. The original > > > driver used to depend on ION (from Kernel 4.4) and had its own > > > implementation for FB dev API. > > > > > > As I need to preserve the original history (with has patches from > > > both HiSilicon and from Linaro), I'm starting from the original > > > patch applied there. The remaining patches are incremental, > > > and port this driver to work with upstream Kernel. > > > ... > > > - Due to legal reasons, I need to preserve the authorship of > > > each one responsbile for each patch. So, I need to start from > > > the original patch from Kernel 4.4; ... > > I do acknowledge you need to preserve history and all - > > but this patchset is not easy to review. > > Why do we need to preserve history ? Adding relevant Signed-off-by and > Co-developed-by should be enough, shouldn't it ? Having a public branch > that contains the history is useful if anyone is interested, but I don't > think it's required in mainline. Yea. I concur with Laurent here. I'm not sure what legal reasoning you have on this but preserving the "absolute" history here is actively detrimental for review and understanding of the patch set. Preserving Authorship, Signed-off-by lines and adding Co-developed-by lines should be sufficient to provide both atribution credit and DCO history. thanks -john