From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13EB6C2BA12 for ; Thu, 2 Apr 2020 23:08:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DC1F3207FF for ; Thu, 2 Apr 2020 23:08:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="NJH8mUDy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390080AbgDBXIg (ORCPT ); Thu, 2 Apr 2020 19:08:36 -0400 Received: from mail-ot1-f68.google.com ([209.85.210.68]:43615 "EHLO mail-ot1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390073AbgDBXIf (ORCPT ); Thu, 2 Apr 2020 19:08:35 -0400 Received: by mail-ot1-f68.google.com with SMTP id a6so5361609otb.10 for ; Thu, 02 Apr 2020 16:08:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QQeb3TySrXKWjqdpdystZzrLdZhobbR4wczMyxU9daE=; b=NJH8mUDyS4vydKm8ozgwIwBIN0a+isHGLQhu1Xa7KlLuolkz3lTRHWLGbQWqH3DraZ GVKcNeq10kJshsCpCmD1ur2WOCalb70yJRRqscOw6we52/btmA03mOpNDeepRwaZoCKx dJnRiSXTU6iVG2WpqT5DIUkzfttiDahvRrN9Ewboh/gzEwIivf1ZemL3a2CfwUbgyEk+ 2hChBjqqFqpMhYxoe+FEq53Gsdh4f2ziNfFkSadQSpgWvqL+EBX+bXP8uMgyvWFIYFUI 90w2wzB44wDQeY7nCWytwHwPOT1gRiQLyRCC3DnFQq2w4RQ2VwXqZVzPKsRGfmhCuw6R MIaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QQeb3TySrXKWjqdpdystZzrLdZhobbR4wczMyxU9daE=; b=fWfuoPAmsiuqUxoES4giG4W60+pKvxphj7Y9xtCAyyzhCaKnn65pA6mloKr7/w9pcG R7ma9Lygc1g1Te7Vp6Eq++XhBRBthi3yvwhWX2W1tWUHdhhKZn9wQrbKLF0Skl5oHHSv wLqaTG0XZOP9AiCaLudZXL2SoFJ34fr9GQDC1owhfJWiqxL86l31Hq1Fg5eI8/ntspXA nDJnHP3i2kytH0GJBHKmOb3Cpftpx/eyu9d0sMeJ0vUxXvDmRknt4pmar2KMThAd75gd 9QJcpROODD6Tr40hb/CYTUJu+ZEMeZpiFvFi1Fq6xPfmc0WFW51J/aXQev5mc5/ZQlJE 7UAg== X-Gm-Message-State: AGi0PuahoBnZazmkudQnhlZfkm+POv773GV5dbnAv89dGMwTaSxCqDFE JoM84hl6Z2H5zQLQo2v67zRL9H42kLX65mE8g1kxfA== X-Google-Smtp-Source: APiQypLZA26Q+M0Ymf7b40RsmQRLEnKqmqg5on5PqLiHU2wifOGb73iVFhOLTaxXIGxQBRFM25QTMqgRbY3IyGi8mMM= X-Received: by 2002:a9d:344:: with SMTP id 62mr4591686otv.102.1585868913011; Thu, 02 Apr 2020 16:08:33 -0700 (PDT) MIME-Version: 1.0 References: <20200402223723.7150-1-john.stultz@linaro.org> In-Reply-To: From: John Stultz Date: Thu, 2 Apr 2020 16:08:21 -0700 Message-ID: Subject: Re: [PATCH] phy: qcom-qusb2: Re add "qcom,sdm845-qusb2-phy" compat string To: Doug Anderson Cc: lkml , Andy Gross , Bjorn Andersson , Rob Herring , Mark Rutland , Manu Gautam , Sandeep Maheswaram , Matthias Kaehlcke , Stephen Boyd , Kishon Vijay Abraham I , linux-arm-msm , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" Content-Type: text/plain; charset="UTF-8" Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Apr 2, 2020 at 3:56 PM Doug Anderson wrote: > > Hi, > > On Thu, Apr 2, 2020 at 3:37 PM John Stultz wrote: > > > > In commit 8fe75cd4cddf ("phy: qcom-qusb2: Add generic QUSB2 V2 > > PHY support"), the change was made to add "qcom,qusb2-v2-phy" > > as a generic compat string. However the change also removed > > the "qcom,sdm845-qusb2-phy" compat string, which is documented > > in the binding and already in use. > > > > This patch re-adds the "qcom,sdm845-qusb2-phy" compat string > > which allows the driver to continue to work with existing dts > > entries such as found on the db845c. > > > > Cc: Andy Gross > > Cc: Bjorn Andersson > > Cc: Rob Herring > > Cc: Mark Rutland > > Cc: Doug Anderson > > Cc: Manu Gautam > > Cc: Sandeep Maheswaram > > Cc: Matthias Kaehlcke > > Cc: Stephen Boyd > > Cc: Kishon Vijay Abraham I > > Cc: linux-arm-msm@vger.kernel.org > > Cc: devicetree@vger.kernel.org > > Fixes: 8fe75cd4cddf ("phy: qcom-qusb2: Add generic QUSB2 V2 PHY support") > > Reported-by: YongQin Liu > > Signed-off-by: John Stultz > > --- > > drivers/phy/qualcomm/phy-qcom-qusb2.c | 3 +++ > > 1 file changed, 3 insertions(+) > > Do you have an out-of-tree dts file? If not, I'd prefer that the fix > was for this patch to land instead: > > https://lore.kernel.org/r/1583747589-17267-9-git-send-email-sanm@codeaurora.org No, no out of tree dts. The usage is already in tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/qcom/sdm845.dtsi#n2389 > While we can land your patch if someone needs it for supporting an > out-of-tree dts, it gives people supporting future SoCs the idea that > they need to add themselves to this table too. That's now discouraged > unless there's a specific quirk that needs to be handled just for this > SoC. My understanding with dts bindings is that they are effectively an ABI. While maybe it makes sense to deprecate the "qcom,sdm845-qusb2-phy" string in the Documentation to avoid new users, I'd think we'd want to keep the support in the driver as we aren't supposed to have tight coupling between the DTB and kernel (at least for official bindings). Granted, I've not gotten much experience with boards that were fully upstream and thus didn't have an eternally evolving dts file that had to be kept in sync with the kernel, so in practice either solution does work for me, but in theory it seems like we should at least pretend these things are stable. :) thanks -john