From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ezequiel Garcia Subject: Re: [PATCH 11/14] ARM: OMAP2+: Add device-tree support for NOR flash Date: Mon, 4 Mar 2013 08:57:51 -0300 Message-ID: References: <1361899842-30303-1-git-send-email-jon-hunter@ti.com> <1361899842-30303-12-git-send-email-jon-hunter@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: In-Reply-To: <1361899842-30303-12-git-send-email-jon-hunter@ti.com> Sender: linux-omap-owner@vger.kernel.org To: Jon Hunter Cc: Rob Herring , Grant Likely , Tony Lindgren , Benoit Cousson , device-tree , linux-omap , linux-arm , Daniel Mack List-Id: devicetree@vger.kernel.org Hi Jon, On Tue, Feb 26, 2013 at 2:30 PM, Jon Hunter wrote: > + > +Example: > + > +gpmc: gpmc@6e000000 { > + compatible = "ti,omap3430-gpmc", "simple-bus"; I'm concern about using simple-bus, and I'm not entirely sure this will work. AFAIK, you can't correlate a parent-child relationship in the device tree to the order in which drivers will be probed, so it's only a matter of coincidence if this is working for you right now. The GPMC code is in "arch/arm/mach-omap2", is located *before* the mtd code in the Makefile, and thus the GPMC driver loads *before* the MTD code. Morevore, I believe that when we move GPMC from arch/arm/mach-omap2 to drivers/memory where it should be, this 'simple-bus' will stop working properly. Of course, I can be wrong, but I think you will have to find some other way to initialize the GPMC's childs. -- Ezequiel