From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 References: In-Reply-To: From: Adam Michaelis Date: Wed, 1 May 2019 14:16:04 -0500 Message-ID: Subject: Re: [PATCH 2/6] dt-bindings: iio: ad7949: Add adi,reference-select Content-Type: multipart/alternative; boundary="000000000000f3b7530587d859fd" To: lars@metafoo.de, michael.hennerich@analog.com, jic23@kernel.org, knaack.h@gmx.de, pmeerw@pmeerw.net, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, charles-antoine.couret@essensium.com, devicetree@vger.kernel.org Cc: Brandon Maier , Clayton Shotwell List-ID: --000000000000f3b7530587d859fd Content-Type: text/plain; charset="UTF-8" Forgot the device tree groups. On Wed, May 1, 2019 at 2:12 PM Adam Michaelis < adam.michaelis@rockwellcollins.com> wrote: > From d228a1a119e33aff91f481fb8ab301a027b5a4ac Mon Sep 17 00:00:00 2001 > From: Adam Michaelis > Date: Thu, 25 Apr 2019 15:22:00 -0500 > Subject: [PATCH 2/6] dt-bindings: iio: ad7949: Add adi,reference-select > > Adding optional parameter to AD7949 to specify the source for the > reference voltage signal. Default value is maintaned with option '6' to > match previous version of driver. > > Signed-off-by: Adam Michaelis > --- > .../devicetree/bindings/iio/adc/ad7949.txt | 22 > ++++++++++++++++++++-- > 1 file changed, 20 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/iio/adc/ad7949.txt > b/Documentation/devicetree/bindings/iio/adc/ad7949.txt > index c7f5057356b1..14ee9a2cb2a5 100644 > --- a/Documentation/devicetree/bindings/iio/adc/ad7949.txt > +++ b/Documentation/devicetree/bindings/iio/adc/ad7949.txt > @@ -6,11 +6,29 @@ Required properties: > * "adi,ad7682" > * "adi,ad7689" > - reg: spi chip select number for the device > - - vref-supply: The regulator supply for ADC reference voltage > > -Example: > +Optional properties: > + - adi,reference-select: Select the reference voltage source to use > + when converting the input voltages. Valid values are: > + 0: Internal 2.5V reference; temperature sensor enabled > + 1: Internal 4.096V reference; temperature sensor enabled > + 2: External reference, temperature sensor enabled, no buffer > + 3: External reference, temperature sensor enabled, buffer enabled > + 6: External reference, temperature sensor disabled, no buffer > + 7: External reference, temperature sensor disabled, buffer enabled > + - vref-supply: The regulator supply for ADC reference voltage. Required > + if external reference selected by 'adi,reference-select'. > + > +Examples: > adc@0 { > compatible = "adi,ad7949"; > reg = <0>; > + adi,reference-select = <2>; > vref-supply = <&vdd_supply>; > }; > + > +adc@0 { > + compatible = "adi,ad7949"; > + reg = <0>; > + adi,reference-select = <0>; > +}; > -- > 1.9.1 > > -- *Adam Michaelis *| Sr Software Engineer | Comm Engineering | Mission Systems *COLLINS AEROSPACE* 400 Collins Road, Cedar Rapids, IA 52498 U.S.A. *Tel:* +1 319 295 4102 *adam.michaelis@collins.com * | *collinsaerospace.com * CONFIDENTIALITY WARNING: This message may contain proprietary and/or privileged information of Collins Aerospace and its affiliated companies. If you are not the intended recipient, please 1) Do not disclose, copy, distribute or use this message or its contents. 2) Advise the sender by return email. 3) Delete all copies (including all attachments) from your computer. Your cooperation is greatly appreciated. --000000000000f3b7530587d859fd Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Forgot the device tree groups.

On Wed, May 1, 2019 at 2:12 = PM Adam Michaelis <adam.michaelis@rockwellcollins.com> wrote:
F= rom d228a1a119e33aff91f481fb8ab301a027b5a4ac Mon Sep 17 00:00:00 2001
=
From: Adam Michaelis <adam.michaelis@rockwellcollins.com>
=
Date: Thu, 25 Apr 2019 15:22:00 -0500
Subject: [PATCH 2/6] d= t-bindings: iio: ad7949: Add adi,reference-select

= Adding optional parameter to AD7949 to specify the source for the
reference voltage signal. Default value is maintaned with option '6= 9; to
match previous version of driver.

= Signed-off-by: Adam Michaelis <adam.michaelis@rockwellcollins.com>
---
=C2=A0.../devicetree/bindings/iio/adc/ad7949.txt=C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| 22 ++++++++++++++++++++--
=C2=A0= 1 file changed, 20 insertions(+), 2 deletions(-)

d= iff --git a/Documentation/devicetree/bindings/iio/adc/ad7949.txt b/Document= ation/devicetree/bindings/iio/adc/ad7949.txt
index c7f5057356b1..= 14ee9a2cb2a5 100644
--- a/Documentation/devicetree/bindings/iio/a= dc/ad7949.txt
+++ b/Documentation/devicetree/bindings/iio/adc/ad7= 949.txt
@@ -6,11 +6,29 @@ Required properties:
=C2=A0 * "adi,ad7682"
=C2=A0 * "adi,ad7689&qu= ot;
=C2=A0 - reg: spi chip select number for the device
- - vref-supply: The regulator supply for ADC reference voltage
= =C2=A0
-Example:
+Optional properties:
+ - ad= i,reference-select: Select the reference voltage source to use
+ = when converting the input voltages. Valid values are:
+=C2=A0 =C2= =A00: Internal 2.5V reference; temperature sensor enabled
+=C2=A0= =C2=A01: Internal 4.096V reference; temperature sensor enabled
+= =C2=A0 =C2=A02: External reference, temperature sensor enabled, no buffer
+=C2=A0 =C2=A03: External reference, temperature sensor enabled, b= uffer enabled
+=C2=A0 =C2=A06: External reference, temperature se= nsor disabled, no buffer
+=C2=A0 =C2=A07: External reference, tem= perature sensor disabled, buffer enabled
+ - vref-supply: The reg= ulator supply for ADC reference voltage. Required
+ if external r= eference selected by 'adi,reference-select'.
+
= +Examples:
=C2=A0adc@0 {
=C2=A0 compatible =3D "adi,ad7949";
=C2= =A0 reg =3D <0>;
+ adi,reference-select =3D &l= t;2>;
=C2=A0 vref-= supply =3D <&vdd_supply>;
=C2=A0};
+
+adc@0 {
+ compatib= le =3D "adi,ad7949";
+ reg =3D <0>;
+ adi,reference-select =3D <0>;
+};
--= =C2=A0
1.9.1



--

Adam Michaelis=C2= =A0| Sr Software En= gineer | Comm Engineering | Mission Systems

= COLLINS AEROSPACE

= 400 Collins Road, Cedar Rapids, IA 52498 U.S.A.

= Tel:<= /b> +1 319 295 = 4102

= a= dam.michaelis@collins.com | collinsae= rospace.com

= =C2=A0

= CONFIDENTIALITY WARNING: This message may contain proprietary and/or privileged information= of Collins Aerospace and its affiliated companies. If you are not the intended= recipient, please 1) Do not disclose, copy, distribute or use this message or its contents. 2) Advise the sender by return email. 3) Delete all copies (inclu= ding all attachments) from your computer. Your cooperation is greatly appreciate= d.

--000000000000f3b7530587d859fd--