From: Rob Herring <robh+dt@kernel.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Pantelis Antoniou <pantelis.antoniou@konsulko.com>,
Frank Rowand <frowand.list@gmail.com>,
devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
Bill Mills <bill.mills@linaro.org>,
tero.kristo@gmail.com
Subject: Re: [RFC 2/2] scripts: dtc: Handle outform dtbo
Date: Tue, 5 Jan 2021 08:37:21 -0700 [thread overview]
Message-ID: <CAL_Jsq+0dL=LHo8r9mY_weBP_bQ97UOBnt596J3JoVHwGNinHA@mail.gmail.com> (raw)
In-Reply-To: <7aa70809eff3f32d821761d2a763e4fb72ecc8fb.1609844956.git.viresh.kumar@linaro.org>
On Tue, Jan 5, 2021 at 4:24 AM Viresh Kumar <viresh.kumar@linaro.org> wrote:
>
> Update dtc compiler to accept dtbo as an outform.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
>
> ---
> I feel that this needs to go directly to
> https://git.kernel.org/pub/scm/utils/dtc/dtc.git
>
> Right ? I will send it separately if the idea is accepted here.
Yes, needs to go to devicetree-compiler list. I think this came up
before and IIRC David wasn't completely in agreement. I looked briefly
and couldn't find the thread though...
We really don't need a different extension because we could just
examine the dtb to determine if it is an overlay or not. That's less
obvious. We could also add meta-data to overlays defining what base
they apply to. If we had that, a tool could just list all overlays
that should apply to a base and we could use that info for build time
applying overlays. Of course, that and a dtbo extension/format are not
mutually exclusive.
> ---
> scripts/dtc/dtc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/scripts/dtc/dtc.c b/scripts/dtc/dtc.c
> index bdb3f5945699..40fa7128b3d6 100644
> --- a/scripts/dtc/dtc.c
> +++ b/scripts/dtc/dtc.c
> @@ -357,6 +357,8 @@ int main(int argc, char *argv[])
> #endif
> } else if (streq(outform, "dtb")) {
> dt_to_blob(outf, dti, outversion);
> + } else if (streq(outform, "dtbo")) {
> + dt_to_blob(outf, dti, outversion);
> } else if (streq(outform, "asm")) {
> dt_to_asm(outf, dti, outversion);
> } else if (streq(outform, "null")) {
You also need to extend guess_type_by_name().
Rob
next prev parent reply other threads:[~2021-01-05 15:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-05 11:24 [RFC 0/2] kbuild: Add support to build overlays (%.dtbo) Viresh Kumar
2021-01-05 11:24 ` [RFC 1/2] " Viresh Kumar
2021-01-05 11:24 ` [RFC 2/2] scripts: dtc: Handle outform dtbo Viresh Kumar
2021-01-05 15:37 ` Rob Herring [this message]
2021-01-12 0:18 ` Frank Rowand
2021-01-05 15:21 ` [RFC 0/2] kbuild: Add support to build overlays (%.dtbo) Rob Herring
2021-01-06 10:09 ` [PATCH] scripts: dtc: Start building fdtoverlay and fdtdump Viresh Kumar
2021-01-06 12:24 ` kernel test robot
2021-01-06 15:52 ` Rob Herring
2021-01-07 5:28 ` [RFC 0/2] kbuild: Add support to build overlays (%.dtbo) Masahiro Yamada
2021-01-07 7:27 ` Viresh Kumar
2021-01-07 19:02 ` Rob Herring
2021-01-07 19:42 ` Bill Mills
2021-01-11 17:26 ` Masahiro Yamada
2021-01-11 11:17 ` Viresh Kumar
2021-01-11 15:40 ` Masahiro Yamada
2021-01-11 16:13 ` Rob Herring
2021-01-11 17:02 ` Masahiro Yamada
2021-01-12 9:41 ` Viresh Kumar
2021-01-12 0:25 ` Frank Rowand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_Jsq+0dL=LHo8r9mY_weBP_bQ97UOBnt596J3JoVHwGNinHA@mail.gmail.com' \
--to=robh+dt@kernel.org \
--cc=bill.mills@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pantelis.antoniou@konsulko.com \
--cc=tero.kristo@gmail.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).