From: Rob Herring <robh@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Gregory Clement <gregory.clement@bootlin.com>,
arm-soc <arm@kernel.org>,
Device Tree <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 00/12] Start converting MVEBU bindings to DT Schema
Date: Wed, 31 Aug 2022 14:44:43 -0500 [thread overview]
Message-ID: <CAL_Jsq+6SkguPyorEZWmh=WXG9ha8FQM7_Z4JGEwz6deym37EQ@mail.gmail.com> (raw)
In-Reply-To: <Yw5jaz/EqNS0hT/T@lunn.ch>
On Tue, Aug 30, 2022 at 2:22 PM Andrew Lunn <andrew@lunn.ch> wrote:
>
> On Tue, Aug 30, 2022 at 01:43:34PM -0500, Rob Herring wrote:
> > On Thu, Aug 25, 2022 at 03:32:46AM +0200, Andrew Lunn wrote:
> > > This is the first batch of patches converting the Marvell MVEBU driver
> > > bindings from .txt to .yaml. So far, kirkwood has been used for
> > > testing, but these drivers apply to a range of Marvell SoCs.
> > >
> > > In order to reduce the number of warnings from the DT schema checking
> > > tools, a few minor changes have been made to a few DT files. No actual
> > > errors have been found, the changes just make the checker quiet.
> > >
> > > I propose these patches are merged via mvebu to arm-soc. No conflicts
> > > are expected with these patches.
> >
> > Why? I strongly prefer the bindings go via subsystem trees. That is the
> > documented way.
>
> I have 50 patches to convert kirkwood from .txt to .yaml. probably
> around 30 subsystems.
>
> 1) Complete nightmare to keep track of so many different patchsets
> going in 30 different directions.
That's what everyone else does. Send them out and let the maintainers
pick them up. Anything left can go via the DT tree or arm-soc. That is
going to happen anyways once you Cc the correct maintainers unless you
state in each patch not to apply.
> 2) None of these patches change any driver code. This is pure
> 'Documentation'. The subsystem probably reviewed the .txt file 10
> years ago when I and other mvebu maintainers submitted
> them. Nothing is changing in the kernel code base, except now we
> gain some degree of validation for this 'Documentation'.
>
> 3) Pretty much all of these were merged via arm-soc 10 years ago. Why
> do it different now? What is gained by not going via arm-soc?
10 years ago it was hit or miss whether bindings even got reviewed.
Shall we go back to that?
Probably my biggest complaint is when anything breaks in next, fixes
going into arm-soc are slow because there are 2 levels of maintainers.
Rob
prev parent reply other threads:[~2022-08-31 19:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 1:32 [PATCH v2 00/12] Start converting MVEBU bindings to DT Schema Andrew Lunn
2022-08-25 1:32 ` [PATCH v2 01/12] dt-bindings: RTC: orion-rtc: Convert to DT schema Andrew Lunn
2022-08-30 18:31 ` Rob Herring
2022-08-25 1:32 ` [PATCH v2 02/12] dt-bindings: thermal: marvell,kirkwood-thermal: " Andrew Lunn
2022-08-30 18:35 ` Rob Herring
2022-08-25 1:32 ` [PATCH v2 03/12] dt-bindings: pinctrl: Convert marvell,kirkwood-pintctrl " Andrew Lunn
2022-08-25 1:32 ` [PATCH v2 04/12] dt-bindings: marvell,ac5-pinctrl: Refactor to look like other Marvell pinctrl files Andrew Lunn
2022-08-25 1:32 ` [PATCH v2 05/12] dt-bindings: USB: Convert ehci-orion to DT schema Andrew Lunn
2022-08-25 1:32 ` [PATCH v2 06/12] dt-bindings: watchdog: Convert marvel.txt " Andrew Lunn
2022-08-25 1:32 ` [PATCH v2 07/12] arm: DT: kirkwood/orion5: Rename watchdog node Andrew Lunn
2022-08-25 1:32 ` [PATCH v2 08/12] dt-bindings: nand-controller: Reflect reality of marvell,orion-nand Andrew Lunn
2022-08-25 11:58 ` Rob Herring
2022-08-25 1:32 ` [PATCH v2 09/12] dt-bindings: mtd: Convert orion-nand to DT schema Andrew Lunn
2022-08-25 1:32 ` [PATCH v2 10/12] arm: DT: kirkwood.dtsi: Rename nand to nand-controller Andrew Lunn
2022-08-25 1:32 ` [PATCH v2 11/12] dt-bindings: timer: Convert marvell,orion-timer.txt to DT schema Andrew Lunn
2022-08-25 1:32 ` [PATCH v2 12/12] dt-bindings: clock: Convert mvebu-gated-clock.txt " Andrew Lunn
2022-08-30 18:43 ` [PATCH v2 00/12] Start converting MVEBU bindings to DT Schema Rob Herring
2022-08-30 19:22 ` Andrew Lunn
2022-08-31 19:44 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_Jsq+6SkguPyorEZWmh=WXG9ha8FQM7_Z4JGEwz6deym37EQ@mail.gmail.com' \
--to=robh@kernel.org \
--cc=andrew@lunn.ch \
--cc=arm@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).