From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A27A7ECAAD2 for ; Thu, 1 Sep 2022 22:33:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234751AbiIAWdu (ORCPT ); Thu, 1 Sep 2022 18:33:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235059AbiIAWdr (ORCPT ); Thu, 1 Sep 2022 18:33:47 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B72FF200; Thu, 1 Sep 2022 15:33:46 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 49FA96201B; Thu, 1 Sep 2022 22:33:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A4362C433D7; Thu, 1 Sep 2022 22:33:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662071625; bh=JVBvlEBiOmHDg0DcOMfECbdzQXwhpcC54UdN/AtqjWo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=ZPVfMQ0a8z2yo7VG7Fxo5kVxNZ6K7rrfDo/aAlpY3aOAgCKGZL/5sYaYDVT2lsS9v IMvV9Ysbn3Tpv9eXvaXih3f/on21G3SgnFEKTdc3rTpTDBtDjRohkzdpDjjIpudIn7 SBZem0lYwtAz5tmiVU4RnRhptT93mngtFZhreI1EHQlI9eSk9EgjuGVGI4sf1jzu43 b1ZYgRMRI5+kTJ6H9EK2yukdB/XwX0Ba3rPeh1BPAY92sJ7+/NOvlihI2mKsliPCTr gPi5aN64izpfRJFyFwPa6OYwUQrl3KghiDKoTk+Uoc+ZEvMxpIkVtT5WpJlvDR4tIe m4xZK2gZyKr4w== Received: by mail-pl1-f174.google.com with SMTP id d12so161014plr.6; Thu, 01 Sep 2022 15:33:45 -0700 (PDT) X-Gm-Message-State: ACgBeo1Ur110/c0+Bqy3EYFl7q6ggXj1xk7TMfi1LlCfeC/vm35akLos N6pTSfbHY18tKMkVHzfu0FG8lrWsm0nuf1VDug== X-Google-Smtp-Source: AA6agR42ASWP/CdkWAsB45KeALFYih+dn+yvzlUdsO7wBNb4Q0XNeVIFC9eif6EAMJZELzBQOqErTEHGgIdN4pieNj4= X-Received: by 2002:a17:902:ef81:b0:174:445f:b88d with SMTP id iz1-20020a170902ef8100b00174445fb88dmr30127552plb.148.1662071625166; Thu, 01 Sep 2022 15:33:45 -0700 (PDT) MIME-Version: 1.0 References: <426469c1-13cc-178b-4904-09439d7788e8@linaro.org> <928ddeff-efac-920c-7bbf-dda35a942b93@linaro.org> <2fedff34-6a20-f1ce-a756-2bd8671fcd52@linaro.org> In-Reply-To: From: Rob Herring Date: Thu, 1 Sep 2022 17:33:31 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/6] dt-bindings: mfd: add binding for Apple Mac System Management Controller To: "Russell King (Oracle)" Cc: Krzysztof Kozlowski , Arnd Bergmann , Lee Jones , Linus Walleij , Alyssa Rosenzweig , asahi@lists.linux.dev, Bartosz Golaszewski , Hector Martin , linux-arm-kernel , "open list:GPIO SUBSYSTEM" , Sven Peter , Krzysztof Kozlowski , devicetree@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Sep 1, 2022 at 11:47 AM Russell King (Oracle) wrote: > > On Thu, Sep 01, 2022 at 07:25:03PM +0300, Krzysztof Kozlowski wrote: > > On 01/09/2022 18:56, Russell King (Oracle) wrote: > > > > > > 8<=== > > > From: "Russell King (Oracle)" > > > Subject: [PATCH] dt-bindings: mfd: add binding for Apple Mac System Management > > > Controller > > > > > > Add a DT binding for the Apple Mac System Management Controller. > > > > > > Signed-off-by: Russell King (Oracle) > > > > Yes, looks good. > > > > I won't add Reviewed-by tag, because I think it would confuse Patchwork, > > so please send a v2 at some point. > > Thanks. Do you have any suggestions for patch 2? Should I merge the > description in patch 2 into this file? > > The full dts for this series looks like this: > > smc: smc@23e400000 { > compatible = "apple,t8103-smc", "apple,smc"; > reg = <0x2 0x3e400000 0x0 0x4000>, > <0x2 0x3fe00000 0x0 0x100000>; > reg-names = "smc", "sram"; > mboxes = <&smc_mbox>; > > smc_gpio: gpio { > gpio-controller; > #gpio-cells = <2>; > }; > }; > > but the fuller version in the asahi linux tree looks like: > > smc: smc@23e400000 { > compatible = "apple,t8103-smc", "apple,smc"; > reg = <0x2 0x3e400000 0x0 0x4000>, > <0x2 0x3fe00000 0x0 0x100000>; > reg-names = "smc", "sram"; > mboxes = <&smc_mbox>; > > smc_gpio: gpio { > gpio-controller; > #gpio-cells = <2>; Only 2 properties doesn't really need its own schema doc. However, I would just move these to the parent node. > }; > > smc_rtc: rtc { > nvmem-cells = <&rtc_offset>; > nvmem-cell-names = "rtc_offset"; > }; > > smc_reboot: reboot { > nvmem-cells = <&shutdown_flag>, <&boot_stage>, > <&boot_error_count>, <&panic_count>, <&pm_setting>; > nvmem-cell-names = "shutdown_flag", "boot_stage", > "boot_error_count", "panic_count", "pm_setting"; Not really much reason to split these up either because you can just fetch the entry you want by name. How confident are the asahi folks that this is a complete binding? Rob