devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH V3 01/16] PM / OPP: Update bindings to make opp-hz a 64 bit value
       [not found] <cover.1438166099.git.viresh.kumar@linaro.org>
@ 2015-07-29 10:52 ` Viresh Kumar
       [not found]   ` <f87ca786bca8abce6261dbd79a34218550355684.1438166099.git.viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
  2015-07-29 10:52 ` [PATCH V3 02/16] PM / OPP: Create a directory for opp bindings Viresh Kumar
  1 sibling, 1 reply; 8+ messages in thread
From: Viresh Kumar @ 2015-07-29 10:52 UTC (permalink / raw)
  To: Rafael Wysocki, sboyd
  Cc: linaro-kernel, linux-pm, rob.herring, arnd.bergmann, nm, broonie,
	mturquette, Sudeep.Holla, viswanath.puttagunta, l.stach,
	thomas.petazzoni, linux-arm-kernel, ta.omasab, kesavan.abhilash,
	khilman, santosh.shilimkar, b.zolnierkie, Viresh Kumar,
	devicetree, Ian Campbell, Kumar Gala, open list, Mark Rutland,
	Pawel Moll, Rafael J. Wysocki, Rob Herring

With a 32 bit value, the maximum frequency that the bindings can
support is ~ 4 GHz. And that might fall short of what newer systems may
have.

Allow opp-hz to be a 64 bit big-endian value.

Cc: Rob Herring <rob.herring@linaro.org>
Cc: devicetree@vger.kernel.org
Suggested-by: Stephen Boyd <sboyd@codeaurora.org>
Suggested-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
 Documentation/devicetree/bindings/power/opp.txt | 40 ++++++++++++-------------
 1 file changed, 20 insertions(+), 20 deletions(-)

diff --git a/Documentation/devicetree/bindings/power/opp.txt b/Documentation/devicetree/bindings/power/opp.txt
index 0d5e7c978121..0cb44dc21f97 100644
--- a/Documentation/devicetree/bindings/power/opp.txt
+++ b/Documentation/devicetree/bindings/power/opp.txt
@@ -88,7 +88,7 @@ This defines voltage-current-frequency combinations along with other related
 properties.
 
 Required properties:
-- opp-hz: Frequency in Hz
+- opp-hz: Frequency in Hz, expressed as a 64-bit big-endian integer.
 
 Optional properties:
 - opp-microvolt: voltage in micro Volts.
@@ -158,20 +158,20 @@ Example 1: Single cluster Dual-core ARM cortex A9, switch DVFS states together.
 		opp-shared;
 
 		opp00 {
-			opp-hz = <1000000000>;
+			opp-hz = /bits/ 64 <1000000000>;
 			opp-microvolt = <970000 975000 985000>;
 			opp-microamp = <70000>;
 			clock-latency-ns = <300000>;
 			opp-suspend;
 		};
 		opp01 {
-			opp-hz = <1100000000>;
+			opp-hz = /bits/ 64 <1100000000>;
 			opp-microvolt = <980000 1000000 1010000>;
 			opp-microamp = <80000>;
 			clock-latency-ns = <310000>;
 		};
 		opp02 {
-			opp-hz = <1200000000>;
+			opp-hz = /bits/ 64 <1200000000>;
 			opp-microvolt = <1025000>;
 			clock-latency-ns = <290000>;
 			turbo-mode;
@@ -237,20 +237,20 @@ independently.
 		 */
 
 		opp00 {
-			opp-hz = <1000000000>;
+			opp-hz = /bits/ 64 <1000000000>;
 			opp-microvolt = <970000 975000 985000>;
 			opp-microamp = <70000>;
 			clock-latency-ns = <300000>;
 			opp-suspend;
 		};
 		opp01 {
-			opp-hz = <1100000000>;
+			opp-hz = /bits/ 64 <1100000000>;
 			opp-microvolt = <980000 1000000 1010000>;
 			opp-microamp = <80000>;
 			clock-latency-ns = <310000>;
 		};
 		opp02 {
-			opp-hz = <1200000000>;
+			opp-hz = /bits/ 64 <1200000000>;
 			opp-microvolt = <1025000>;
 			opp-microamp = <90000;
 			lock-latency-ns = <290000>;
@@ -313,20 +313,20 @@ DVFS state together.
 		opp-shared;
 
 		opp00 {
-			opp-hz = <1000000000>;
+			opp-hz = /bits/ 64 <1000000000>;
 			opp-microvolt = <970000 975000 985000>;
 			opp-microamp = <70000>;
 			clock-latency-ns = <300000>;
 			opp-suspend;
 		};
 		opp01 {
-			opp-hz = <1100000000>;
+			opp-hz = /bits/ 64 <1100000000>;
 			opp-microvolt = <980000 1000000 1010000>;
 			opp-microamp = <80000>;
 			clock-latency-ns = <310000>;
 		};
 		opp02 {
-			opp-hz = <1200000000>;
+			opp-hz = /bits/ 64 <1200000000>;
 			opp-microvolt = <1025000>;
 			opp-microamp = <90000>;
 			clock-latency-ns = <290000>;
@@ -339,20 +339,20 @@ DVFS state together.
 		opp-shared;
 
 		opp10 {
-			opp-hz = <1300000000>;
+			opp-hz = /bits/ 64 <1300000000>;
 			opp-microvolt = <1045000 1050000 1055000>;
 			opp-microamp = <95000>;
 			clock-latency-ns = <400000>;
 			opp-suspend;
 		};
 		opp11 {
-			opp-hz = <1400000000>;
+			opp-hz = /bits/ 64 <1400000000>;
 			opp-microvolt = <1075000>;
 			opp-microamp = <100000>;
 			clock-latency-ns = <400000>;
 		};
 		opp12 {
-			opp-hz = <1500000000>;
+			opp-hz = /bits/ 64 <1500000000>;
 			opp-microvolt = <1010000 1100000 1110000>;
 			opp-microamp = <95000>;
 			clock-latency-ns = <400000>;
@@ -379,7 +379,7 @@ Example 4: Handling multiple regulators
 		opp-shared;
 
 		opp00 {
-			opp-hz = <1000000000>;
+			opp-hz = /bits/ 64 <1000000000>;
 			opp-microvolt = <970000>, /* Supply 0 */
 					<960000>, /* Supply 1 */
 					<960000>; /* Supply 2 */
@@ -392,7 +392,7 @@ Example 4: Handling multiple regulators
 		/* OR */
 
 		opp00 {
-			opp-hz = <1000000000>;
+			opp-hz = /bits/ 64 <1000000000>;
 			opp-microvolt = <970000 975000 985000>, /* Supply 0 */
 					<960000 965000 975000>, /* Supply 1 */
 					<960000 965000 975000>; /* Supply 2 */
@@ -405,7 +405,7 @@ Example 4: Handling multiple regulators
 		/* OR */
 
 		opp00 {
-			opp-hz = <1000000000>;
+			opp-hz = /bits/ 64 <1000000000>;
 			opp-microvolt = <970000 975000 985000>, /* Supply 0 */
 					<960000 965000 975000>, /* Supply 1 */
 					<960000 965000 975000>; /* Supply 2 */
@@ -437,12 +437,12 @@ Example 5: Multiple OPP tables
 		opp-shared;
 
 		opp00 {
-			opp-hz = <600000000>;
+			opp-hz = /bits/ 64 <600000000>;
 			...
 		};
 
 		opp01 {
-			opp-hz = <800000000>;
+			opp-hz = /bits/ 64 <800000000>;
 			...
 		};
 	};
@@ -453,12 +453,12 @@ Example 5: Multiple OPP tables
 		opp-shared;
 
 		opp10 {
-			opp-hz = <1000000000>;
+			opp-hz = /bits/ 64 <1000000000>;
 			...
 		};
 
 		opp11 {
-			opp-hz = <1100000000>;
+			opp-hz = /bits/ 64 <1100000000>;
 			...
 		};
 	};
-- 
2.4.0


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH V3 02/16] PM / OPP: Create a directory for opp bindings
       [not found] <cover.1438166099.git.viresh.kumar@linaro.org>
  2015-07-29 10:52 ` [PATCH V3 01/16] PM / OPP: Update bindings to make opp-hz a 64 bit value Viresh Kumar
@ 2015-07-29 10:52 ` Viresh Kumar
  2015-07-30 13:18   ` Rob Herring
  1 sibling, 1 reply; 8+ messages in thread
From: Viresh Kumar @ 2015-07-29 10:52 UTC (permalink / raw)
  To: Rafael Wysocki, sboyd
  Cc: linaro-kernel, linux-pm, rob.herring, arnd.bergmann, nm, broonie,
	mturquette, Sudeep.Holla, viswanath.puttagunta, l.stach,
	thomas.petazzoni, linux-arm-kernel, ta.omasab, kesavan.abhilash,
	khilman, santosh.shilimkar, b.zolnierkie, Viresh Kumar,
	devicetree

More platform specific extended opp bindings will follow and it would be
easy to manage them with a directory for opp. Lets create that and move
the existing opp bindings into it.

Cc: Rob Herring <rob.herring@linaro.org>
Cc: devicetree@vger.kernel.org
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
 Documentation/devicetree/bindings/power/{ => opp}/opp.txt | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 rename Documentation/devicetree/bindings/power/{ => opp}/opp.txt (100%)

diff --git a/Documentation/devicetree/bindings/power/opp.txt b/Documentation/devicetree/bindings/power/opp/opp.txt
similarity index 100%
rename from Documentation/devicetree/bindings/power/opp.txt
rename to Documentation/devicetree/bindings/power/opp/opp.txt
-- 
2.4.0


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH V3 02/16] PM / OPP: Create a directory for opp bindings
  2015-07-29 10:52 ` [PATCH V3 02/16] PM / OPP: Create a directory for opp bindings Viresh Kumar
@ 2015-07-30 13:18   ` Rob Herring
  2015-07-30 13:49     ` Viresh Kumar
  0 siblings, 1 reply; 8+ messages in thread
From: Rob Herring @ 2015-07-30 13:18 UTC (permalink / raw)
  To: Viresh Kumar
  Cc: Rafael Wysocki, Stephen Boyd, Nishanth Menon, Abhilash Kesavan,
	linaro-kernel@lists.linaro.org, Kevin Hilman,
	linux-pm@vger.kernel.org, Viswanath Puttagunta, Michael Turquette,
	Santosh Shilimkar, Bartlomiej Zolnierkiewicz, Mark Brown,
	Sudeep Holla, devicetree@vger.kernel.org, Thomas Petazzoni,
	linux-arm-kernel@lists.infradead.org, Lucas Stach

On Wed, Jul 29, 2015 at 5:52 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> More platform specific extended opp bindings will follow and it would be
> easy to manage them with a directory for opp. Lets create that and move
> the existing opp bindings into it.
>
> Cc: Rob Herring <rob.herring@linaro.org>

Use get_maintainers.pl please so you send to right people and right email.

> Cc: devicetree@vger.kernel.org
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
>  Documentation/devicetree/bindings/power/{ => opp}/opp.txt | 0
>  1 file changed, 0 insertions(+), 0 deletions(-)
>  rename Documentation/devicetree/bindings/power/{ => opp}/opp.txt (100%)
>
> diff --git a/Documentation/devicetree/bindings/power/opp.txt b/Documentation/devicetree/bindings/power/opp/opp.txt
> similarity index 100%
> rename from Documentation/devicetree/bindings/power/opp.txt
> rename to Documentation/devicetree/bindings/power/opp/opp.txt

"power" seems to be a random collection of things. I'd prefer you move
this to .../bindings/opp/opp.txt.

Rob

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH V3 01/16] PM / OPP: Update bindings to make opp-hz a 64 bit value
       [not found]   ` <f87ca786bca8abce6261dbd79a34218550355684.1438166099.git.viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
@ 2015-07-30 13:23     ` Rob Herring
  0 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2015-07-30 13:23 UTC (permalink / raw)
  To: Viresh Kumar
  Cc: Rafael Wysocki, Stephen Boyd,
	linaro-kernel-cunTk1MwBs8s++Sfvej+rw@public.gmane.org,
	linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Arnd Bergmann,
	Nishanth Menon, Mark Brown, Michael Turquette, Sudeep Holla,
	Viswanath Puttagunta, Lucas Stach, Thomas Petazzoni,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Thomas Abraham, Abhilash Kesavan, Kevin Hilman, Santosh Shilimkar,
	Bartlomiej Zolnierkiewicz,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org

On Wed, Jul 29, 2015 at 5:52 AM, Viresh Kumar <viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:
> With a 32 bit value, the maximum frequency that the bindings can
> support is ~ 4 GHz. And that might fall short of what newer systems may
> have.

4GHz should be fast enough for anyone...

> Allow opp-hz to be a 64 bit big-endian value.
>
> Cc: Rob Herring <rob.herring-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>

Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>

> Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> Suggested-by: Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
> Suggested-by: Bartlomiej Zolnierkiewicz <b.zolnierkie-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> Signed-off-by: Viresh Kumar <viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> ---
>  Documentation/devicetree/bindings/power/opp.txt | 40 ++++++++++++-------------
>  1 file changed, 20 insertions(+), 20 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/power/opp.txt b/Documentation/devicetree/bindings/power/opp.txt
> index 0d5e7c978121..0cb44dc21f97 100644
> --- a/Documentation/devicetree/bindings/power/opp.txt
> +++ b/Documentation/devicetree/bindings/power/opp.txt
> @@ -88,7 +88,7 @@ This defines voltage-current-frequency combinations along with other related
>  properties.
>
>  Required properties:
> -- opp-hz: Frequency in Hz
> +- opp-hz: Frequency in Hz, expressed as a 64-bit big-endian integer.
>
>  Optional properties:
>  - opp-microvolt: voltage in micro Volts.
> @@ -158,20 +158,20 @@ Example 1: Single cluster Dual-core ARM cortex A9, switch DVFS states together.
>                 opp-shared;
>
>                 opp00 {
> -                       opp-hz = <1000000000>;
> +                       opp-hz = /bits/ 64 <1000000000>;
>                         opp-microvolt = <970000 975000 985000>;
>                         opp-microamp = <70000>;
>                         clock-latency-ns = <300000>;
>                         opp-suspend;
>                 };
>                 opp01 {
> -                       opp-hz = <1100000000>;
> +                       opp-hz = /bits/ 64 <1100000000>;
>                         opp-microvolt = <980000 1000000 1010000>;
>                         opp-microamp = <80000>;
>                         clock-latency-ns = <310000>;
>                 };
>                 opp02 {
> -                       opp-hz = <1200000000>;
> +                       opp-hz = /bits/ 64 <1200000000>;
>                         opp-microvolt = <1025000>;
>                         clock-latency-ns = <290000>;
>                         turbo-mode;
> @@ -237,20 +237,20 @@ independently.
>                  */
>
>                 opp00 {
> -                       opp-hz = <1000000000>;
> +                       opp-hz = /bits/ 64 <1000000000>;
>                         opp-microvolt = <970000 975000 985000>;
>                         opp-microamp = <70000>;
>                         clock-latency-ns = <300000>;
>                         opp-suspend;
>                 };
>                 opp01 {
> -                       opp-hz = <1100000000>;
> +                       opp-hz = /bits/ 64 <1100000000>;
>                         opp-microvolt = <980000 1000000 1010000>;
>                         opp-microamp = <80000>;
>                         clock-latency-ns = <310000>;
>                 };
>                 opp02 {
> -                       opp-hz = <1200000000>;
> +                       opp-hz = /bits/ 64 <1200000000>;
>                         opp-microvolt = <1025000>;
>                         opp-microamp = <90000;
>                         lock-latency-ns = <290000>;
> @@ -313,20 +313,20 @@ DVFS state together.
>                 opp-shared;
>
>                 opp00 {
> -                       opp-hz = <1000000000>;
> +                       opp-hz = /bits/ 64 <1000000000>;
>                         opp-microvolt = <970000 975000 985000>;
>                         opp-microamp = <70000>;
>                         clock-latency-ns = <300000>;
>                         opp-suspend;
>                 };
>                 opp01 {
> -                       opp-hz = <1100000000>;
> +                       opp-hz = /bits/ 64 <1100000000>;
>                         opp-microvolt = <980000 1000000 1010000>;
>                         opp-microamp = <80000>;
>                         clock-latency-ns = <310000>;
>                 };
>                 opp02 {
> -                       opp-hz = <1200000000>;
> +                       opp-hz = /bits/ 64 <1200000000>;
>                         opp-microvolt = <1025000>;
>                         opp-microamp = <90000>;
>                         clock-latency-ns = <290000>;
> @@ -339,20 +339,20 @@ DVFS state together.
>                 opp-shared;
>
>                 opp10 {
> -                       opp-hz = <1300000000>;
> +                       opp-hz = /bits/ 64 <1300000000>;
>                         opp-microvolt = <1045000 1050000 1055000>;
>                         opp-microamp = <95000>;
>                         clock-latency-ns = <400000>;
>                         opp-suspend;
>                 };
>                 opp11 {
> -                       opp-hz = <1400000000>;
> +                       opp-hz = /bits/ 64 <1400000000>;
>                         opp-microvolt = <1075000>;
>                         opp-microamp = <100000>;
>                         clock-latency-ns = <400000>;
>                 };
>                 opp12 {
> -                       opp-hz = <1500000000>;
> +                       opp-hz = /bits/ 64 <1500000000>;
>                         opp-microvolt = <1010000 1100000 1110000>;
>                         opp-microamp = <95000>;
>                         clock-latency-ns = <400000>;
> @@ -379,7 +379,7 @@ Example 4: Handling multiple regulators
>                 opp-shared;
>
>                 opp00 {
> -                       opp-hz = <1000000000>;
> +                       opp-hz = /bits/ 64 <1000000000>;
>                         opp-microvolt = <970000>, /* Supply 0 */
>                                         <960000>, /* Supply 1 */
>                                         <960000>; /* Supply 2 */
> @@ -392,7 +392,7 @@ Example 4: Handling multiple regulators
>                 /* OR */
>
>                 opp00 {
> -                       opp-hz = <1000000000>;
> +                       opp-hz = /bits/ 64 <1000000000>;
>                         opp-microvolt = <970000 975000 985000>, /* Supply 0 */
>                                         <960000 965000 975000>, /* Supply 1 */
>                                         <960000 965000 975000>; /* Supply 2 */
> @@ -405,7 +405,7 @@ Example 4: Handling multiple regulators
>                 /* OR */
>
>                 opp00 {
> -                       opp-hz = <1000000000>;
> +                       opp-hz = /bits/ 64 <1000000000>;
>                         opp-microvolt = <970000 975000 985000>, /* Supply 0 */
>                                         <960000 965000 975000>, /* Supply 1 */
>                                         <960000 965000 975000>; /* Supply 2 */
> @@ -437,12 +437,12 @@ Example 5: Multiple OPP tables
>                 opp-shared;
>
>                 opp00 {
> -                       opp-hz = <600000000>;
> +                       opp-hz = /bits/ 64 <600000000>;
>                         ...
>                 };
>
>                 opp01 {
> -                       opp-hz = <800000000>;
> +                       opp-hz = /bits/ 64 <800000000>;
>                         ...
>                 };
>         };
> @@ -453,12 +453,12 @@ Example 5: Multiple OPP tables
>                 opp-shared;
>
>                 opp10 {
> -                       opp-hz = <1000000000>;
> +                       opp-hz = /bits/ 64 <1000000000>;
>                         ...
>                 };
>
>                 opp11 {
> -                       opp-hz = <1100000000>;
> +                       opp-hz = /bits/ 64 <1100000000>;
>                         ...
>                 };
>         };
> --
> 2.4.0
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH V3 02/16] PM / OPP: Create a directory for opp bindings
  2015-07-30 13:18   ` Rob Herring
@ 2015-07-30 13:49     ` Viresh Kumar
  2015-07-30 16:24       ` Rob Herring
  0 siblings, 1 reply; 8+ messages in thread
From: Viresh Kumar @ 2015-07-30 13:49 UTC (permalink / raw)
  To: Rob Herring
  Cc: Rafael Wysocki, Stephen Boyd, Nishanth Menon, Abhilash Kesavan,
	linaro-kernel@lists.linaro.org, Kevin Hilman,
	linux-pm@vger.kernel.org, Viswanath Puttagunta, Michael Turquette,
	Santosh Shilimkar, Bartlomiej Zolnierkiewicz, Mark Brown,
	Sudeep Holla, devicetree@vger.kernel.org, Thomas Petazzoni,
	linux-arm-kernel@lists.infradead.org, Lucas Stach

On 30-07-15, 08:18, Rob Herring wrote:
> On Wed, Jul 29, 2015 at 5:52 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> > More platform specific extended opp bindings will follow and it would be
> > easy to manage them with a directory for opp. Lets create that and move
> > the existing opp bindings into it.
> >
> > Cc: Rob Herring <rob.herring@linaro.org>
> 
> Use get_maintainers.pl please so you send to right people and right email.

Already done, you were just cc'd as an extra guy :)

> > Cc: devicetree@vger.kernel.org
> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> > ---
> >  Documentation/devicetree/bindings/power/{ => opp}/opp.txt | 0
> >  1 file changed, 0 insertions(+), 0 deletions(-)
> >  rename Documentation/devicetree/bindings/power/{ => opp}/opp.txt (100%)
> >
> > diff --git a/Documentation/devicetree/bindings/power/opp.txt b/Documentation/devicetree/bindings/power/opp/opp.txt
> > similarity index 100%
> > rename from Documentation/devicetree/bindings/power/opp.txt
> > rename to Documentation/devicetree/bindings/power/opp/opp.txt
> 
> "power" seems to be a random collection of things. I'd prefer you move
> this to .../bindings/opp/opp.txt.

Hmm, sure. That would be better I think.

--------------8<-------------------

Message-Id: <29597667e2c8afdbf396c5fcc9269fb27794131c.1438264123.git.viresh.kumar@linaro.org>
From: Viresh Kumar <viresh.kumar@linaro.org>
Date: Mon, 27 Jul 2015 10:04:21 +0530
Subject: [PATCH] PM / OPP: Create a directory for opp bindings

More platform specific extended opp bindings will follow and it would be
easy to manage them with a directory for opp. Lets create that and move
the existing opp bindings into it.

Cc: Rob Herring <rob.herring@linaro.org>
Cc: devicetree@vger.kernel.org
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
 Documentation/devicetree/bindings/{power => opp}/opp.txt | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 rename Documentation/devicetree/bindings/{power => opp}/opp.txt (100%)

diff --git a/Documentation/devicetree/bindings/power/opp.txt b/Documentation/devicetree/bindings/opp/opp.txt
similarity index 100%
rename from Documentation/devicetree/bindings/power/opp.txt
rename to Documentation/devicetree/bindings/opp/opp.txt

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH V3 02/16] PM / OPP: Create a directory for opp bindings
  2015-07-30 13:49     ` Viresh Kumar
@ 2015-07-30 16:24       ` Rob Herring
  2015-07-30 16:52         ` Viresh Kumar
  0 siblings, 1 reply; 8+ messages in thread
From: Rob Herring @ 2015-07-30 16:24 UTC (permalink / raw)
  To: Viresh Kumar
  Cc: Rafael Wysocki, Stephen Boyd, Nishanth Menon, Abhilash Kesavan,
	linaro-kernel@lists.linaro.org, Kevin Hilman,
	linux-pm@vger.kernel.org, Viswanath Puttagunta, Michael Turquette,
	Santosh Shilimkar, Bartlomiej Zolnierkiewicz, Mark Brown,
	Sudeep Holla, devicetree@vger.kernel.org, Thomas Petazzoni,
	linux-arm-kernel@lists.infradead.org, Lucas Stach

On Thu, Jul 30, 2015 at 8:49 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> On 30-07-15, 08:18, Rob Herring wrote:
>> On Wed, Jul 29, 2015 at 5:52 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
>> > More platform specific extended opp bindings will follow and it would be
>> > easy to manage them with a directory for opp. Lets create that and move
>> > the existing opp bindings into it.
>> >
>> > Cc: Rob Herring <rob.herring@linaro.org>
>>
>> Use get_maintainers.pl please so you send to right people and right email.
>
> Already done, you were just cc'd as an extra guy :)

No, because no one that is a maintainer of
Documentation/devicetree/bindings is cc'ed here. You did on the other
patch, but not here as neither Ian, Mark, Kumar nor Pawel are cc'ed.

>> > Cc: devicetree@vger.kernel.org
>> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
>> > ---
>> >  Documentation/devicetree/bindings/power/{ => opp}/opp.txt | 0
>> >  1 file changed, 0 insertions(+), 0 deletions(-)
>> >  rename Documentation/devicetree/bindings/power/{ => opp}/opp.txt (100%)
>> >
>> > diff --git a/Documentation/devicetree/bindings/power/opp.txt b/Documentation/devicetree/bindings/power/opp/opp.txt
>> > similarity index 100%
>> > rename from Documentation/devicetree/bindings/power/opp.txt
>> > rename to Documentation/devicetree/bindings/power/opp/opp.txt
>>
>> "power" seems to be a random collection of things. I'd prefer you move
>> this to .../bindings/opp/opp.txt.
>
> Hmm, sure. That would be better I think.
>
> --------------8<-------------------
>
> Message-Id: <29597667e2c8afdbf396c5fcc9269fb27794131c.1438264123.git.viresh.kumar@linaro.org>
> From: Viresh Kumar <viresh.kumar@linaro.org>
> Date: Mon, 27 Jul 2015 10:04:21 +0530
> Subject: [PATCH] PM / OPP: Create a directory for opp bindings
>
> More platform specific extended opp bindings will follow and it would be
> easy to manage them with a directory for opp. Lets create that and move
> the existing opp bindings into it.
>
> Cc: Rob Herring <rob.herring@linaro.org>

Still wrong...


> Cc: devicetree@vger.kernel.org
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
>  Documentation/devicetree/bindings/{power => opp}/opp.txt | 0
>  1 file changed, 0 insertions(+), 0 deletions(-)
>  rename Documentation/devicetree/bindings/{power => opp}/opp.txt (100%)
>
> diff --git a/Documentation/devicetree/bindings/power/opp.txt b/Documentation/devicetree/bindings/opp/opp.txt
> similarity index 100%
> rename from Documentation/devicetree/bindings/power/opp.txt
> rename to Documentation/devicetree/bindings/opp/opp.txt

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH V3 02/16] PM / OPP: Create a directory for opp bindings
  2015-07-30 16:24       ` Rob Herring
@ 2015-07-30 16:52         ` Viresh Kumar
  2015-07-30 16:57           ` [PATCH V3 resend] " Viresh Kumar
  0 siblings, 1 reply; 8+ messages in thread
From: Viresh Kumar @ 2015-07-30 16:52 UTC (permalink / raw)
  To: Rob Herring, Joe Perches
  Cc: Rafael Wysocki, Stephen Boyd, Nishanth Menon, Abhilash Kesavan,
	linaro-kernel@lists.linaro.org, Kevin Hilman,
	linux-pm@vger.kernel.org, Viswanath Puttagunta, Michael Turquette,
	Santosh Shilimkar, Bartlomiej Zolnierkiewicz, Mark Brown,
	Sudeep Holla, devicetree@vger.kernel.org, Thomas Petazzoni,
	linux-arm-kernel@lists.infradead.org, Lucas Stach

On 30-07-15, 11:24, Rob Herring wrote:
> On Thu, Jul 30, 2015 at 8:49 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> > On 30-07-15, 08:18, Rob Herring wrote:
> >> On Wed, Jul 29, 2015 at 5:52 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> >> > More platform specific extended opp bindings will follow and it would be
> >> > easy to manage them with a directory for opp. Lets create that and move
> >> > the existing opp bindings into it.
> >> >
> >> > Cc: Rob Herring <rob.herring@linaro.org>
> >>
> >> Use get_maintainers.pl please so you send to right people and right email.
> >
> > Already done, you were just cc'd as an extra guy :)
> 
> No, because no one that is a maintainer of
> Documentation/devicetree/bindings is cc'ed here. You did on the other
> patch, but not here as neither Ian, Mark, Kumar nor Pawel are cc'ed.

No. I sent all of them together and get_maintainers is invoked for all
of them. I checked again and its a bug with get_maintainers.

@Joe: Can you please take a look at that?

Problem description: Because my patch only had this:

-----------8<-------------

---
 Documentation/devicetree/bindings/{power => opp}/opp.txt | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 rename Documentation/devicetree/bindings/{power => opp}/opp.txt (100%)

diff --git a/Documentation/devicetree/bindings/power/opp.txt b/Documentation/devicetree/bindings/opp/opp.txt
similarity index 100%
rename from Documentation/devicetree/bindings/power/opp.txt
rename to Documentation/devicetree/bindings/opp/opp.txt

------------>8------------

get_maintainers reports this for the patch:

scripts/get_maintainer.pl: file
'0001-PM-OPP-Create-a-directory-for-opp-bindings.patch' doesn't appear
to be a patch.  Add -f to options?

 
> > Cc: Rob Herring <rob.herring@linaro.org>
> 
> Still wrong...

Let me send the patch as reply to this one, with personally cc'ing all
people you want me to.

-- 
viresh

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH V3 resend] PM / OPP: Create a directory for opp bindings
  2015-07-30 16:52         ` Viresh Kumar
@ 2015-07-30 16:57           ` Viresh Kumar
  0 siblings, 0 replies; 8+ messages in thread
From: Viresh Kumar @ 2015-07-30 16:57 UTC (permalink / raw)
  To: Rafael Wysocki, rob.herring
  Cc: linaro-kernel, linux-pm, arnd.bergmann, nm, broonie, mturquette,
	sboyd, Sudeep.Holla, viswanath.puttagunta, l.stach,
	thomas.petazzoni, linux-arm-kernel, ta.omasab, kesavan.abhilash,
	khilman, santosh.shilimkar, b.zolnierkie, pawel.moll,
	mark.rutland, ijc+devicetree, galak, devicetree, Viresh Kumar

More platform specific extended opp bindings will follow and it would be
easy to manage them with a directory for opp. Lets create that and move
the existing opp bindings into it.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
Resending to get cc list fixed, which isn't getting populated due to a
bug with get_maintainers.

 Documentation/devicetree/bindings/{power => opp}/opp.txt | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 rename Documentation/devicetree/bindings/{power => opp}/opp.txt (100%)

diff --git a/Documentation/devicetree/bindings/power/opp.txt b/Documentation/devicetree/bindings/opp/opp.txt
similarity index 100%
rename from Documentation/devicetree/bindings/power/opp.txt
rename to Documentation/devicetree/bindings/opp/opp.txt
-- 
2.4.0


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2015-07-30 16:57 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <cover.1438166099.git.viresh.kumar@linaro.org>
2015-07-29 10:52 ` [PATCH V3 01/16] PM / OPP: Update bindings to make opp-hz a 64 bit value Viresh Kumar
     [not found]   ` <f87ca786bca8abce6261dbd79a34218550355684.1438166099.git.viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-07-30 13:23     ` Rob Herring
2015-07-29 10:52 ` [PATCH V3 02/16] PM / OPP: Create a directory for opp bindings Viresh Kumar
2015-07-30 13:18   ` Rob Herring
2015-07-30 13:49     ` Viresh Kumar
2015-07-30 16:24       ` Rob Herring
2015-07-30 16:52         ` Viresh Kumar
2015-07-30 16:57           ` [PATCH V3 resend] " Viresh Kumar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).