devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Jianjun Wang <jianjun.wang@mediatek.com>
Cc: David Miller <davem@davemloft.net>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Ryder Lee <ryder.lee@mediatek.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
	PCI <linux-pci@vger.kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	"moderated list:ARM/Mediatek SoC support" 
	<linux-mediatek@lists.infradead.org>,
	devicetree@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Sj Huang <sj.huang@mediatek.com>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Subject: Re: [v1,1/3] dt-bindings: Add YAML schemas for Gen3 PCIe controller
Date: Wed, 9 Sep 2020 11:50:53 -0600	[thread overview]
Message-ID: <CAL_Jsq+NrfiJ-DAwtYG2b_chfivXi-aazHH8kiApuHS1G8JF=Q@mail.gmail.com> (raw)
In-Reply-To: <1599620917.2521.9.camel@mhfsdcap03>

On Tue, Sep 8, 2020 at 9:10 PM Jianjun Wang <jianjun.wang@mediatek.com> wrote:
>
> On Tue, 2020-09-08 at 13:50 -0600, Rob Herring wrote:
> > On Mon, 07 Sep 2020 20:08:50 +0800, Jianjun Wang wrote:
> > > Add YAML schemas documentation for Gen3 PCIe controller on
> > > MediaTek SoCs.
> > >
> > > Acked-by: Ryder Lee <ryder.lee@mediatek.com>
> > > Signed-off-by: Jianjun Wang <jianjun.wang@mediatek.com>
> > > ---
> > >  .../bindings/pci/mediatek-pcie-gen3.yaml      | 158 ++++++++++++++++++
> > >  1 file changed, 158 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> > >
> >
> >
> > My bot found errors running 'make dt_binding_check' on your patch:
> >
> > Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.example.dts:55.56-59.19: Warning (pci_device_reg): /example-0/bus/pcie@11230000/legacy-interrupt-controller: missing PCI reg property
> >
> >
> > See https://patchwork.ozlabs.org/patch/1359119
> >
> > If you already ran 'make dt_binding_check' and didn't see the above
> > error(s), then make sure dt-schema is up to date:
> >
> > pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade
> >
> > Please check and re-submit.
> >
>
> Yes, I have already found this warning message, but I'm confused with
> how to add this reg property, since the interrupt-controller has inherit
> the pci device type but does not have its own registers.
>
> Could you please tell me how to fix this error, or which docs can I
> refer to?

Actually, disregard this. We need to fix dtc for this case.

Rob

  reply	other threads:[~2020-09-09 17:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-07 12:08 [v1,0/3] PCI: mediatek: Add new generation controller support Jianjun Wang
2020-09-07 12:08 ` [v1,1/3] dt-bindings: Add YAML schemas for Gen3 PCIe controller Jianjun Wang
2020-09-08 19:50   ` Rob Herring
2020-09-09  3:08     ` Jianjun Wang
2020-09-09 17:50       ` Rob Herring [this message]
2020-09-08 20:04   ` Bjorn Helgaas
2020-09-09  3:14     ` Jianjun Wang
2020-09-08 20:21   ` Rob Herring
2020-09-09  3:39     ` Jianjun Wang
2020-09-07 12:08 ` [v1,2/3] PCI: mediatek: Add new generation controller support Jianjun Wang
2020-09-07 12:08 ` [v1,3/3] MAINTAINERS: update entry for MediaTek PCIe controller Jianjun Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAL_Jsq+NrfiJ-DAwtYG2b_chfivXi-aazHH8kiApuHS1G8JF=Q@mail.gmail.com' \
    --to=robh@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=jianjun.wang@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=matthias.bgg@gmail.com \
    --cc=mchehab+huawei@kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=ryder.lee@mediatek.com \
    --cc=sj.huang@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).