From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v4 03/13] dt-bindings: net: Add a YAML schemas for the generic MDIO options Date: Fri, 28 Jun 2019 12:17:15 -0600 Message-ID: References: <20190627155708.myxychzngc3trxhc@flea> <20190628134553.l445r5idtejwlryl@flea> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20190628134553.l445r5idtejwlryl@flea> Sender: netdev-owner@vger.kernel.org To: Maxime Ripard Cc: Mark Rutland , Frank Rowand , "David S . Miller" , Chen-Yu Tsai , Maxime Coquelin , Alexandre Torgue , netdev , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Maxime Chevallier , =?UTF-8?Q?Antoine_T=C3=A9nart?= , Andrew Lunn , Florian Fainelli , Heiner Kallweit List-Id: devicetree@vger.kernel.org On Fri, Jun 28, 2019 at 7:46 AM Maxime Ripard wrote: > > On Thu, Jun 27, 2019 at 10:06:57AM -0600, Rob Herring wrote: > > On Thu, Jun 27, 2019 at 9:57 AM Maxime Ripard wrote: > > > > > + > > > > > + reset-gpios = <&gpio2 5 1>; > > > > > + reset-delay-us = <2>; > > > > > + > > > > > + ethphy0: ethernet-phy@1 { > > > > > + reg = <1>; > > > > > > > > Need a child node schema to validate the unit-address and reg property. > > > > > > This should be already covered by the ethernet-phy.yaml schemas > > > earlier in this series. > > > > Partially, yes. > > > > > Were you expecting something else? > > > > That would not prevent having a child node such as 'foo {};' or > > 'foo@bad {};'. It would also not check valid nodes named something > > other than 'ethernet-phy'. > > Right, but listing the nodes won't either, since we can't enable > additionalProperties in that schema. So any node that wouldn't match > ethernet-phy@.* wouldn't be validated, but wouldn't generate a warning > either. Perhaps I wasn't clear, but it was missing or incorrect 'reg' property and unit-address format checks that I was thinking about. Just like we have for SPI. Rob