From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH 0/5] Marvell PXA1928 USB support Date: Fri, 15 May 2015 11:04:23 -0500 Message-ID: References: <1431557340-5421-1-git-send-email-robh@kernel.org> <5555C2A5.8010509@gmail.com> <2878212.YRcsYyF5mD@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <2878212.YRcsYyF5mD@wuerfel> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Arnd Bergmann Cc: Sebastian Hesselbarth , Greg Kroah-Hartman , Alan Stern , Kishon Vijay Abraham I , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Linux USB List , Jason Cooper , Andrew Lunn , Gregory Clement , Thomas Petazzoni List-Id: devicetree@vger.kernel.org On Fri, May 15, 2015 at 9:11 AM, Arnd Bergmann wrote: > On Friday 15 May 2015 07:48:24 Rob Herring wrote: >> >> > Anyway, if you are introducing new PHY drivers with _that_ generic >> > names, it will either clash with every other Marvell USB PHYs - >> > or we'll have to add the PHY code into the drivers above. >> >> How about phy-pxa-28nm-{usb2,hsic}? >> > > Seems ok to me, but please verify that these are actually usb2 and hsic > specific devices. There are a lot of PHY implementations that share the > basic layout between devices for different purposes, e.g. USB3 and PCIe > and they should have a name that is not too specific for one connection > when the same driver gets reused by another part. Yes, I'm aware of that as Calxeda "comboPHYs" did 10G XAUI, PCIe and SATA. Those are cases are supporting similar electrical specs. USB3 is similar to those. I've not seen USB 2.0 PHYs shared with anything else, and HSIC is also very unique. Rob > > Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html