[PATCH 1/2] dt-bindings: rtc: Fix Xicor X1205 vendor prefix

[PATCH 1/2] dt-bindings: rtc: Fix Xicor X1205 vendor prefix

[Rob Herring (Arm)]

The vendor for the Xircom X1205 RTC is not Xircom, but Xicor which was
acquired by Intersil.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 Documentation/devicetree/bindings/rtc/trivial-rtc.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml b/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml
index 7330a7200831..f8a35446d029 100644
--- a/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml
+++ b/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml
@@ -85,8 +85,8 @@ properties:
       - via,vt8500-rtc
       # I2C bus SERIAL INTERFACE REAL-TIME CLOCK IC
       - whwave,sd3078
-      # Xircom X1205 I2C RTC
-      - xircom,x1205
+      # Xicor/Intersil X1205 I2C RTC
+      - xicor,x1205
 
   reg:
     maxItems: 1
-- 
2.50.1

[PATCH 2/2] rtc: x1205: Fix Xicor X1205 vendor prefix

[Rob Herring (Arm)]

The vendor for the X1205 RTC is not Xircom, but Xicor which was acquired
by Intersil. Since the I2C subsystem drops the vendor prefix for driver
matching, the vendor prefix hasn't mattered.

Fixes: 6875404fdb44 ("rtc: x1205: Add DT probing support")
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 drivers/rtc/rtc-x1205.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/rtc/rtc-x1205.c b/drivers/rtc/rtc-x1205.c
index 4bcd7ca32f27..b8a0fccef14e 100644
--- a/drivers/rtc/rtc-x1205.c
+++ b/drivers/rtc/rtc-x1205.c
@@ -669,7 +669,7 @@ static const struct i2c_device_id x1205_id[] = {
 MODULE_DEVICE_TABLE(i2c, x1205_id);
 
 static const struct of_device_id x1205_dt_ids[] = {
-	{ .compatible = "xircom,x1205", },
+	{ .compatible = "xicor,x1205", },
 	{},
 };
 MODULE_DEVICE_TABLE(of, x1205_dt_ids);
-- 
2.50.1

Re: [PATCH 1/2] dt-bindings: rtc: Fix Xicor X1205 vendor prefix

[Linus Walleij]

On Thu, Aug 21, 2025 at 11:57 PM Rob Herring (Arm) <robh@kernel.org> wrote:

> The vendor for the Xircom X1205 RTC is not Xircom, but Xicor which was
> acquired by Intersil.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>

Aw shoot. My misspelling.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

Re: [PATCH 2/2] rtc: x1205: Fix Xicor X1205 vendor prefix

[Linus Walleij]

On Thu, Aug 21, 2025 at 11:57 PM Rob Herring (Arm) <robh@kernel.org> wrote:

> The vendor for the X1205 RTC is not Xircom, but Xicor which was acquired
> by Intersil. Since the I2C subsystem drops the vendor prefix for driver
> matching, the vendor prefix hasn't mattered.
>
> Fixes: 6875404fdb44 ("rtc: x1205: Add DT probing support")
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

Re: [PATCH 2/2] rtc: x1205: Fix Xicor X1205 vendor prefix

[Linus Walleij]

On Thu, Aug 21, 2025 at 11:57 PM Rob Herring (Arm) <robh@kernel.org> wrote:

> The vendor for the X1205 RTC is not Xircom, but Xicor which was acquired
> by Intersil. Since the I2C subsystem drops the vendor prefix for driver
> matching, the vendor prefix hasn't mattered.
>
> Fixes: 6875404fdb44 ("rtc: x1205: Add DT probing support")
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>

This should probably be tagged for stable since there is
a device tree using this (correct) compatible and it doesn't
probe right now.

Yours,
Linus Walleij

Re: [PATCH 2/2] rtc: x1205: Fix Xicor X1205 vendor prefix

[Rob Herring]

On Thu, Aug 21, 2025 at 5:21 PM Linus Walleij <linus.walleij@linaro.org> wrote:
>
> On Thu, Aug 21, 2025 at 11:57 PM Rob Herring (Arm) <robh@kernel.org> wrote:
>
> > The vendor for the X1205 RTC is not Xircom, but Xicor which was acquired
> > by Intersil. Since the I2C subsystem drops the vendor prefix for driver
> > matching, the vendor prefix hasn't mattered.
> >
> > Fixes: 6875404fdb44 ("rtc: x1205: Add DT probing support")
> > Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
>
> This should probably be tagged for stable since there is
> a device tree using this (correct) compatible and it doesn't
> probe right now.

It should probe just fine as I explained. The I2C subsystem strips the
vendor prefix off for matching, so what you put doesn't really matter.

Rob