From: Rob Herring <robh+dt@kernel.org>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Cc: Frank Rowand <frowand.list@gmail.com>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
"moderated list:BROADCOM BCM2835 ARM ARCHITECTURE"
<linux-rpi-kernel@lists.infradead.org>,
Nathan Chancellor <natechancellor@gmail.com>,
devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] of: unittest: Use bigger address cells to catch parser regressions
Date: Mon, 3 Aug 2020 16:27:39 -0600 [thread overview]
Message-ID: <CAL_Jsq+oQyQhAaB-jP8MxKp9jTEbr4c0oxPY5FiwmQRcnqJOdg@mail.gmail.com> (raw)
In-Reply-To: <9200970a917a9cabdc5b17483b5a8725111eb9d0.camel@suse.de>
On Mon, Aug 3, 2020 at 8:25 AM Nicolas Saenz Julienne
<nsaenzjulienne@suse.de> wrote:
>
> Getting address and size cells for dma-ranges/ranges parsing is tricky
> and shouldn't rely on the node's count_cells() method. The function
> starts looking for cells on the parent node, as its supposed to work
> with device nodes, which doesn't work when input with bus nodes, as
> generally done when parsing ranges.
>
> Add test to catch regressions on that specific quirk as developers will
> be tempted to edit it out in favor of the default method.
>
> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> ---
> drivers/of/unittest-data/tests-address.dtsi | 10 +++++-----
> drivers/of/unittest.c | 2 +-
> 2 files changed, 6 insertions(+), 6 deletions(-)
Applied, thanks.
Rob
next prev parent reply other threads:[~2020-08-03 22:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-31 10:02 [PATCH] of: address: Fix parser address/size cells initialization Nicolas Saenz Julienne
2020-07-31 15:03 ` Rob Herring
2020-08-03 14:25 ` [PATCH] of: unittest: Use bigger address cells to catch parser regressions Nicolas Saenz Julienne
2020-08-03 22:27 ` Rob Herring [this message]
2020-07-31 15:45 ` [PATCH] of: address: Fix parser address/size cells initialization Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_Jsq+oQyQhAaB-jP8MxKp9jTEbr4c0oxPY5FiwmQRcnqJOdg@mail.gmail.com \
--to=robh+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=natechancellor@gmail.com \
--cc=nsaenzjulienne@suse.de \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).