From: Rob Herring <robh+dt@kernel.org>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: "open list:THERMAL" <linux-pm@vger.kernel.org>,
devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Collabora Kernel ML <kernel@collabora.com>
Subject: Re: [PATCH 16/38] dt-bindings: power: supply: tps65217: Convert to DT schema format
Date: Tue, 16 Mar 2021 11:52:47 -0600 [thread overview]
Message-ID: <CAL_Jsq+rynEXFCJDL-Xrar1hSam65qP6ZAiOQUKRtDbu26BYSw@mail.gmail.com> (raw)
In-Reply-To: <20210316162045.cvvb226rpzxbovdl@earth.universe>
On Tue, Mar 16, 2021 at 10:20 AM Sebastian Reichel
<sebastian.reichel@collabora.com> wrote:
>
> Hi Rob,
>
> On Mon, Mar 15, 2021 at 12:33:23PM -0600, Rob Herring wrote:
> > On Fri, Mar 12, 2021 at 8:44 AM Sebastian Reichel
> > <sebastian.reichel@collabora.com> wrote:
> > > + interrupts:
> > > + minItems: 2
> > > + maxItems: 2
> >
> > We've lost info that was in the original binding. You could do
> > something like this:
> >
> > items:
> > - description: USB charger
> > const: 0
> > - description: AC charger
> > const: 1
> >
> > (Usually the interrupt values would be out of scope of the binding,
> > but I guess here it makes some sense.)
>
> I initially did this, but it did not work. I see the following for
> dt_binding_check (dtbs_check triggers the same):
>
> Documentation/devicetree/bindings/power/supply/tps65217-charger.example.dt.yaml: charger: interrupts:0: [0] is too short
> From schema: Documentation/devicetree/bindings/power/supply/tps65217-charger.yaml
> Documentation/devicetree/bindings/power/supply/tps65217-charger.example.dt.yaml: charger: interrupts: [[0], [1]] is too long
> From schema: Documentation/devicetree/bindings/power/supply/tps65217-charger.yaml
> Documentation/devicetree/bindings/power/supply/tps65217-charger.example.dt.yaml: charger: interrupts: Additional items are not allowed ([1] was unexpected)
> From schema: Documentation/devicetree/bindings/power/supply/tps65217-charger.yaml
>
> Seemed to be a limitation in the validation tool, so I just dropped
> the extra information. If we do not want to loose information I can
> add it to the description, or should the validation tool be fixed?
> I suppose it's kind of unusual, that the binding can provide the
> interrupt line numbers.
It is, so let's just leave it as-is.
Rob
next prev parent reply other threads:[~2021-03-16 17:53 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 15:43 [PATCH 00/38] Convert power-supply DT bindings to YAML Sebastian Reichel
2021-03-12 15:43 ` [PATCH 01/38] ARM: dts: motorola-cpcap-mapphone: Prepare for dtbs_check parsing Sebastian Reichel
2021-03-12 15:43 ` [PATCH 02/38] dt-bindings: power: supply: cpcap-battery: Convert to DT schema format Sebastian Reichel
2021-03-12 15:43 ` [PATCH 03/38] dt-bindings: power: supply: cpcap-charger: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 04/38] dt-bindings: power: supply: bq25890: " Sebastian Reichel
2021-03-15 18:21 ` Rob Herring
2021-03-16 16:46 ` Sebastian Reichel
2021-03-16 17:50 ` Rob Herring
2021-03-12 15:43 ` [PATCH 05/38] dt-bindings: power: supply: bq24257: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 06/38] dt-bindings: power: supply: bq24190: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 07/38] dt-bindings: power: supply: bq2415x: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 08/38] dt-bindings: power: supply: bq24735: " Sebastian Reichel
2021-03-15 18:24 ` Rob Herring
2021-03-16 16:22 ` Sebastian Reichel
2021-03-16 17:45 ` Rob Herring
2021-03-12 15:43 ` [PATCH 09/38] dt-bindings: power: supply: isp1704: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 10/38] dt-bindings: power: supply: sbs-charger: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 11/38] dt-bindings: power: supply: sbs-manager: " Sebastian Reichel
2021-03-15 18:27 ` Rob Herring
2021-03-12 15:43 ` [PATCH 12/38] dt-bindings: power: supply: ds2760: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 13/38] dt-bindings: power: supply: sc27xx-fg: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 14/38] dt-bindings: power: supply: sc2731-charger: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 15/38] dt-bindings: power: supply: tps65090: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 16/38] dt-bindings: power: supply: tps65217: " Sebastian Reichel
2021-03-15 18:33 ` Rob Herring
2021-03-16 16:20 ` Sebastian Reichel
2021-03-16 17:52 ` Rob Herring [this message]
2021-03-12 15:43 ` [PATCH 17/38] dt-bindings: power: supply: twl4030: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 18/38] dt-bindings: power: supply: n900-battery: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 19/38] dt-bindings: power: supply: lego-ev3-battery: " Sebastian Reichel
2021-03-12 16:04 ` David Lechner
2021-03-12 15:43 ` [PATCH 20/38] dt-bindings: power: supply: max17040: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 21/38] dt-bindings: power: supply: max14656: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 22/38] dt-bindings: power: supply: max17042: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 23/38] dt-bindings: power: supply: max8903: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 24/38] dt-bindings: power: supply: ucs1002: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 25/38] dt-bindings: power: supply: pm8941-charger: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 26/38] dt-bindings: power: supply: pm8941-coincell: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 27/38] dt-bindings: power: supply: act8945a: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 28/38] dt-bindings: power: supply: axp20x: " Sebastian Reichel
2021-03-24 3:02 ` Chen-Yu Tsai
2021-03-12 15:43 ` [PATCH 29/38] dt-bindings: power: supply: da9150: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 30/38] dt-bindings: power: supply: lp8727: " Sebastian Reichel
2021-03-15 18:37 ` Rob Herring
2021-03-12 15:43 ` [PATCH 31/38] dt-bindings: power: supply: lt3651: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 32/38] dt-bindings: power: supply: ltc294x: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 33/38] dt-bindings: power: supply: rt9455: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 34/38] dt-bindings: power: supply: olpc-battery: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 35/38] dt-bindings: power: supply: ab8500: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 36/38] dt-bindings: power: supply: sbs-battery: Fix dtbs_check Sebastian Reichel
2021-03-12 15:43 ` [PATCH 37/38] dt-bindings: power: supply: Fix remaining battery.txt links Sebastian Reichel
2021-03-12 15:43 ` [PATCH 38/38] dt-bindings: power: supply: Drop power_supply.txt Sebastian Reichel
2021-03-15 19:44 ` [PATCH 00/38] Convert power-supply DT bindings to YAML Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_Jsq+rynEXFCJDL-Xrar1hSam65qP6ZAiOQUKRtDbu26BYSw@mail.gmail.com \
--to=robh+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).