From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D46EBC3F2CD for ; Mon, 23 Mar 2020 17:59:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A0C772072D for ; Mon, 23 Mar 2020 17:59:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584986371; bh=2l0KQW4VoP61cJLv+dL28Z9ly7A7laSQG5Iu1ELGiNg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=eDivF2kyjLjB6kFqlQqPCbwFhaAqmXw4nCm/CFK3I/0zzFVMuJ5lajBzRcO8V1EXg g65O3vdm9cOJKbZPe6gRiNNxlp0YsMxoTDFg88UwQO9nL9/5C324As7fe4fcVH3Nch GvUX8lAtSdu/8k9/+TjGtH7hfEdIIHmb08ewL8N8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727196AbgCWR7b (ORCPT ); Mon, 23 Mar 2020 13:59:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:35396 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727011AbgCWR7b (ORCPT ); Mon, 23 Mar 2020 13:59:31 -0400 Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6C2292076E; Mon, 23 Mar 2020 17:59:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584986370; bh=2l0KQW4VoP61cJLv+dL28Z9ly7A7laSQG5Iu1ELGiNg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=0lqsb+hyuD6XqDBK/iujiOzptPXvHe2aV/Kkwr/P9PUnDfHuueev3+9fAESyrBbXO ZkqqYSoJFuvUWkikxGH/IUJ026YcMeuNlg4tvEn2RHdNtA8m0Q8d/1izBjP/Y7z1YM neW0n8jo8z3fJdmpYEmC19DdPkIw8QyaG/UxJ2uQ= Received: by mail-qk1-f173.google.com with SMTP id x3so4743764qki.4; Mon, 23 Mar 2020 10:59:30 -0700 (PDT) X-Gm-Message-State: ANhLgQ3X6lkENw1D+18PwfR1dHlvEp+svbIONC0IFdXeaX3lh/nmGMJ+ CfwV5SOwBn319i1jyWmcJbwatv4y65OE6frLzg== X-Google-Smtp-Source: ADFU+vsR6Us0V+BMyVNelvszRuS/SrM36zlyf95ZYn/ZAx/QRMGOQ3N6czh+WeF4cZMmcFdLqwHXYaDLwzsbRTR1RmQ= X-Received: by 2002:a37:8502:: with SMTP id h2mr22475590qkd.223.1584986369516; Mon, 23 Mar 2020 10:59:29 -0700 (PDT) MIME-Version: 1.0 References: <20200320174107.29406-1-lkundrak@v3.sk> <20200320174107.29406-9-lkundrak@v3.sk> In-Reply-To: <20200320174107.29406-9-lkundrak@v3.sk> From: Rob Herring Date: Mon, 23 Mar 2020 11:59:17 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 08/10] powerpc/fsl: Make serial ports compatible with ns16550a To: Lubomir Rintel Cc: Greg Kroah-Hartman , Mark Rutland , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Marc Gonzalez , Mans Rullgard , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , linuxppc-dev , "open list:SERIAL DRIVERS" , "linux-kernel@vger.kernel.org" , devicetree@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Mar 20, 2020 at 11:41 AM Lubomir Rintel wrote: > > There are separate compatible strings for ns16550 and ns16550a and the > Freescale serial port is compatible with the latter one, with working > FIFO. I don't think changing this is right. First, 'ns16550' is what's documented in the DT spec (and ePAPR which it's based on). Second, these dts files are pretty mature/stable, so I'm less inclined to change them. AFAICT, this change either enables the fifo (which would be an untested change in behavior) or has no effect because the fifo is auto-detected. > Use the appropriate compatible string that is also consistent with ARM64 > Freescale boards and thus avoiding one special case in the binding schema. Well, that's annoying... Rob