From mboxrd@z Thu Jan 1 00:00:00 1970 MIME-Version: 1.0 In-Reply-To: <20150205045910.GA4234@jack-ThinkPad-T520> References: <1421994515-3070-1-git-send-email-jack.yoo@skyworksinc.com> <1421994515-3070-5-git-send-email-jack.yoo@skyworksinc.com> <20150205045910.GA4234@jack-ThinkPad-T520> Date: Thu, 5 Feb 2015 07:22:55 -0600 Message-ID: Subject: Re: [PATCH v10 4/6] devicetree: Add new SKY81452 backlight binding From: Rob Herring Content-Type: text/plain; charset=UTF-8 To: Gyungoh Yoo Cc: Samuel Ortiz , Lee Jones , Grant Likely , Rob Herring , Jingoo Han , Bryan Wu , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Jiri Kosina , Andrew Morton , Jonathan Cameron , Thomas Petazzoni , ktsai@capellamicro.com, hs@denx.de, "Opensource [Steve Twiss]" , matti.vaittinen@nsn.com, Mark Brown , Jason Cooper , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Shawn Guo , Florian Vaussard , Andrew Lunn , Antony Pavlov , Hayato Suzuki , Jean-Christophe Plagniol-Villard , Tomi Valkeinen , jack.yoo@skyworksinc.com, "linux-fbdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" List-ID: On Wed, Feb 4, 2015 at 10:59 PM, Gyungoh Yoo wrote: > On Wed, Feb 04, 2015 at 09:11:22AM -0600, Rob Herring wrote: >> On Fri, Jan 23, 2015 at 12:28 AM, wrote: >> > From: Gyungoh Yoo >> > >> > Signed-off-by: Gyungoh Yoo >> > Acked-by: Bryan Wu >> > --- >> > Changes v10: >> > Nothing >> > >> > Changes v9: >> > Nothing >> > >> > Changes v8: >> > Renamed property names for backlight with vendor prefix >> > Modified gpio-enable property to generic property for GPIO >> > Made up the example for backlight DT >> > >> > Changes v7: >> > Nothing >> > >> > Changes v6: >> > Nothing >> > >> > Changes v5: >> > Nothing >> > >> > Changes v4: >> > Nothing >> > >> > Changes v3: >> > Nothing >> > >> > Changes v2: >> > Added reg attribute for I2C slave address >> >> You did? Where is it? > > It was just changes on version 2. > Since that version, the patch series was separted. > >> >> > .../video/backlight/sky81452-backlight.txt | 29 ++++++++++++++++++++++ >> > 1 file changed, 29 insertions(+) >> > create mode 100644 Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt >> > >> > diff --git a/Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt b/Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt >> > new file mode 100644 >> > index 0000000..8daebf5 >> > --- /dev/null >> > +++ b/Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt >> > @@ -0,0 +1,29 @@ >> > +SKY81452-backlight bindings >> > + >> > +Required properties: >> > +- compatible : Must be "skyworks,sky81452-backlight" >> > + >> > +Optional properties: >> > +- name : Name of backlight device. Default is 'lcd-backlight'. >> > +- gpios : GPIO to use to EN pin. >> > + See Documentation/devicetree/bindings/gpio/gpio.txt >> > +- skyworks,en-channels : Enable mask for current sink channel 1 to 6. >> >> Does led-sources property being added in 3.20 work for this? > > I think so. I will modify it. > >> >> > +- skyworks,ignore-pwm : Ignore both PWM input >> > +- skyworks,dpwm-mode : Enable DPWM dimming mode, otherwise Analog dimming. >> > +- skyworks,phase-shift : Enable phase shift mode >> > +- skyworks,ovp-level : Over-voltage protection level. >> > + Should be between 14 or 28V. >> >> Please append units (-volt) > > I will append it and resubmit the patch. > > Thanks. > >> >> > +- skyworks,short-detection-threshold : It should be one of 4, 5, 6 and 7V. >> >> Please append units (-volt) >> >> > +- skyworks,current-limit : It should be 2300mA or 2750mA. >> >> Please append units (-mA) >> >> > + >> > +Example: >> > + >> > + backlight { >> > + compatible = "skyworks,sky81452-backlight"; >> > + name = "pwm-backlight"; >> > + skyworks,en-channels = <0x3f>; >> > + skyworks,ignore-pwm; >> > + skyworks,phase-shift; >> > + skyworks,ovp-level = <20>; >> > + skyworks,current-limit = <2300>; >> > + }; >> > -- >> > 1.9.1 >> >