From: Rob Herring <robh@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Saravana Kannan" <saravanak@google.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2] fdtoverlay: Remove bogus type info from help text
Date: Fri, 31 May 2024 09:38:41 -0500 [thread overview]
Message-ID: <CAL_JsqJ0nX7EK05aC7z9i2FEB7jAf0XrPDyPY-NXr8rnEDgqZg@mail.gmail.com> (raw)
In-Reply-To: <CAMuHMdV5q8cSz+SOry1ZJjMhTxhkb0ABNDFgCDySpKPijJjpcw@mail.gmail.com>
On Fri, May 31, 2024 at 9:07 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Rob,
>
> On Fri, May 31, 2024 at 3:43 PM Rob Herring <robh@kernel.org> wrote:
> > On Thu, May 30, 2024 at 8:32 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > > On Thu, May 30, 2024 at 2:31 PM Rob Herring <robh@kernel.org> wrote:
> > > > On Wed, May 29, 2024 at 5:11 AM Geert Uytterhoeven
> > > > <geert+renesas@glider.be> wrote:
> > > > >
> > > > > "fdtoverlay -h" shows a.o.:
> > > > >
> > > > > <type> s=string, i=int, u=unsigned, x=hex
> > > > > Optional modifier prefix:
> > > > > hh or b=byte, h=2 byte, l=4 byte (default)
> > > > >
> > > > > However, unlike fdtget and fdtput, fdtoverlay does not support the
> > > > > "-t"/"--type" option.
> > > > >
> > > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > > > ---
> > > > > Upstream dtc has Uwe's commit 2cdf93a6d402a161 ("fdtoverlay: Fix usage
> > > > > string to not mention "<type>"").
> > > >
> > > > So you want me to sync upstream? That's how upstream commits get into
> > > > the kernel. I don't take patches (unless there's some urgent
> > > > breakage).
> > >
> > > If that's the policy, then yes please ;-)
> >
> > With current dtc main branch, I get these errors:
> >
> > Failed to apply
> > 'arch/arm64/boot/dts/renesas/salvator-panel-aa104xd12.dtbo':
> > FDT_ERR_NOTFOUND
>
> Interesting...
>
> Do you know what's the problem?
No. Since it is conveniently platforms you care about, I thought I'd
leave it to you. ;)
Well, it seems that if I use the upstream built dtc and fdtoverlay it
works fine. Using the one in scripts/dtc/ doesn't. Looks like that
issue is on me...
> Are these the only ones failing?
Yes. And all of arm32 was fine.
Rob
next prev parent reply other threads:[~2024-05-31 14:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-29 10:11 [PATCH v2] fdtoverlay: Remove bogus type info from help text Geert Uytterhoeven
2024-05-30 12:31 ` Rob Herring
2024-05-30 13:31 ` Geert Uytterhoeven
2024-05-31 13:42 ` Rob Herring
2024-05-31 14:06 ` Geert Uytterhoeven
2024-05-31 14:38 ` Rob Herring [this message]
2024-05-31 15:00 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqJ0nX7EK05aC7z9i2FEB7jAf0XrPDyPY-NXr8rnEDgqZg@mail.gmail.com \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=saravanak@google.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).