From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH 1/2] can: sja1000: add documentation for Technologic Systems version Date: Tue, 22 Dec 2015 12:28:52 -0600 Message-ID: References: <1450469845-12900-1-git-send-email-damien.riegel@savoirfairelinux.com> <20151220033742.GA9883@rob-hp-laptop> <20151221150953.GA6434@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <20151221150953.GA6434@localhost> Sender: linux-kernel-owner@vger.kernel.org To: Damien Riegel Cc: "linux-kernel@vger.kernel.org" , netdev , linux-can@vger.kernel.org, "devicetree@vger.kernel.org" , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Wolfgang Grandegger , Marc Kleine-Budde , kernel@savoirfairelinux.com List-Id: devicetree@vger.kernel.org On Mon, Dec 21, 2015 at 9:09 AM, Damien Riegel wrote: > On Sat, Dec 19, 2015 at 09:37:42PM -0600, Rob Herring wrote: >> On Fri, Dec 18, 2015 at 03:17:24PM -0500, Damien Riegel wrote: >> > This commit adds documentation for the Technologic Systems version of >> > SJA1000. The difference with the NXP version is in the way the registers >> > are accessed. >> > >> > Signed-off-by: Damien Riegel >> > --- >> > Documentation/devicetree/bindings/net/can/sja1000.txt | 3 ++- >> > 1 file changed, 2 insertions(+), 1 deletion(-) >> > >> > diff --git a/Documentation/devicetree/bindings/net/can/sja1000.txt b/Documentation/devicetree/bindings/net/can/sja1000.txt >> > index b4a6d53..7a158d5 100644 >> > --- a/Documentation/devicetree/bindings/net/can/sja1000.txt >> > +++ b/Documentation/devicetree/bindings/net/can/sja1000.txt >> > @@ -2,7 +2,7 @@ Memory mapped SJA1000 CAN controller from NXP (formerly Philips) >> > >> > Required properties: >> > >> > -- compatible : should be "nxp,sja1000". >> > +- compatible : should be one of "nxp,sja1000", "technologic,sja1000". >> > >> > - reg : should specify the chip select, address offset and size required >> > to map the registers of the SJA1000. The size is usually 0x80. >> > @@ -14,6 +14,7 @@ Optional properties: >> > >> > - reg-io-width : Specify the size (in bytes) of the IO accesses that >> > should be performed on the device. Valid value is 1, 2 or 4. >> > + Must be set to 2 for technologic version. >> > Default to 1 (8 bits). >> >> Really, this should default to 2 for technologic version and not be >> required. > > Would something along the line of "This property is > for technologic version." be more appropriate? Yes, exactly. Rob