From: Rob Herring <robh+dt@kernel.org>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: devicetree@vger.kernel.org,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Michal Marek <michal.lkml@markovi.net>
Subject: Re: [PATCH 1/3] kbuild: avoid concurrency issue in parallel building dtbs and dtbs_check
Date: Wed, 4 Mar 2020 09:34:49 -0600 [thread overview]
Message-ID: <CAL_JsqJ3q4txoV6wE-Vk5X9oo0roVbBYpwMuPEngDiEv1XXinQ@mail.gmail.com> (raw)
In-Reply-To: <20200304032038.14424-2-masahiroy@kernel.org>
On Tue, Mar 3, 2020 at 9:20 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> 'make dtbs_check' checks the shecma in addition to building *.dtb files,
typo
> in other words, 'make dtbs_check' is a super-set of 'make dtbs'.
> So, you do not have to do 'make dtbs dtbs_check', but I want to keep
> the build system robust in any use.
>
> Currently, 'dtbs' and 'dtbs_check' are independent of each other.
> In parallel building, two threads descend into arch/*/boot/dts/,
> one for dtbs and the other for dtbs_check, then end up with building
> the same DTB simultaneously.
>
> This commit fixes the concurrency issue. Otherwise, I see build errors
> like follows:
>
> $ make ARCH=arm64 defconfig
> $ make -j16 ARCH=arm64 DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/psci.yaml dtbs dtbs_check
> <snip>
> DTC arch/arm64/boot/dts/qcom/sdm845-cheza-r2.dtb
> DTC arch/arm64/boot/dts/amlogic/meson-gxl-s905x-p212.dtb
> DTC arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-lite2.dtb
> DTC arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-lite2.dtb
> DTC arch/arm64/boot/dts/freescale/imx8mn-evk.dtb
> DTC arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-one-plus.dtb
> DTC arch/arm64/boot/dts/zte/zx296718-pcbox.dtb
> DTC arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dt.yaml
> DTC arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p230.dtb
> DTC arch/arm64/boot/dts/xilinx/zynqmp-zc1254-revA.dtb
> DTC arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dtb
> DTC arch/arm64/boot/dts/rockchip/rk3399-gru-scarlet-inx.dtb
> DTC arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-one-plus.dtb
> CHECK arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dt.yaml
> fixdep: error opening file: arch/arm64/boot/dts/allwinner/.sun50i-h6-orangepi-lite2.dtb.d: No such file or directory
> make[2]: *** [scripts/Makefile.lib:296: arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-lite2.dtb] Error 2
> make[2]: *** Deleting file 'arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-lite2.dtb'
> make[2]: *** Waiting for unfinished jobs....
> DTC arch/arm64/boot/dts/rockchip/rk3399-gru-scarlet-kd.dtb
> DTC arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p231.dtb
> DTC arch/arm64/boot/dts/xilinx/zynqmp-zc1275-revA.dtb
> DTC arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dtb
> fixdep: parse error; no targets found
> make[2]: *** [scripts/Makefile.lib:296: arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-one-plus.dtb] Error 1
> make[2]: *** Deleting file 'arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-one-plus.dtb'
> make[1]: *** [scripts/Makefile.build:505: arch/arm64/boot/dts/allwinner] Error 2
> make[1]: *** Waiting for unfinished jobs....
> DTC arch/arm64/boot/dts/renesas/r8a77951-salvator-xs.dtb
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
> Makefile | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
Reviewed-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2020-03-04 15:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 3:20 [PATCH 0/3] kbuild: improve DT build rules Masahiro Yamada
2020-03-04 3:20 ` [PATCH 1/3] kbuild: avoid concurrency issue in parallel building dtbs and dtbs_check Masahiro Yamada
2020-03-04 15:34 ` Rob Herring [this message]
2020-03-04 3:20 ` [PATCH 2/3] kbuild: allow to run dt_binding_check and dtbs_check in a single command Masahiro Yamada
2020-03-04 5:55 ` Sam Ravnborg
2020-03-04 15:19 ` Rob Herring
2020-03-08 2:18 ` Masahiro Yamada
2020-03-04 16:10 ` Rob Herring
2020-03-04 3:20 ` [PATCH 3/3] kbuild: allow to run dt_binding_check without kernel configuration Masahiro Yamada
2020-03-04 15:25 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqJ3q4txoV6wE-Vk5X9oo0roVbBYpwMuPEngDiEv1XXinQ@mail.gmail.com \
--to=robh+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).