From: Rob Herring <robh+dt@kernel.org>
To: Saravana Kannan <saravanak@google.com>
Cc: Frank Rowand <frowand.list@gmail.com>,
Android Kernel Team <kernel-team@android.com>,
devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] of: Reduce log level of of_phandle_iterator_next()
Date: Wed, 20 Nov 2019 10:09:48 -0600 [thread overview]
Message-ID: <CAL_JsqJ4JQ7Oop5oWUYRCNA-xQrd0svQSPrp+y1F+Qux9xTRrQ@mail.gmail.com> (raw)
In-Reply-To: <20191120040045.81115-1-saravanak@google.com>
On Tue, Nov 19, 2019 at 10:00 PM Saravana Kannan <saravanak@google.com> wrote:
>
> These error messages are mostly useful for debugging malformed device
> tree data.
A malformed DT is an error, no?
> So change these messages from error to debug messages to
> avoid spamming the end user. Any error messages that might actually be
> useful to the user is probably going to come from the caller of these
> APIs. So leave it to them to decide if they need to print any error
> messages.
Generally that pattern results in every caller doing their own message
which is the wrong way around IMO. And recent patches fix some of
those cases[1].
Rob
[1] https://lkml.org/lkml/2019/7/30/41
prev parent reply other threads:[~2019-11-20 16:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 4:00 [PATCH] of: Reduce log level of of_phandle_iterator_next() Saravana Kannan
2019-11-20 16:09 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqJ4JQ7Oop5oWUYRCNA-xQrd0svQSPrp+y1F+Qux9xTRrQ@mail.gmail.com \
--to=robh+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).