Re: [PATCHv1 1/6] HSI: add Device Tree support for HSI clients

[Rob Herring <robherring2@gmail.com>]

On Sun, Feb 23, 2014 at 5:49 PM, Sebastian Reichel <sre@debian.org> wrote:
> Add new method hsi_add_clients_from_dt, which can be used
> to initialize HSI clients from a device tree node.
>
> The patch also documents the DT binding for trivial HSI
> clients.
>
> Signed-off-by: Sebastian Reichel <sre@debian.org>
> ---
>  .../devicetree/bindings/hsi/trivial-devices.txt    | 36 +++++++++++
>  drivers/hsi/hsi.c                                  | 70 +++++++++++++++++++++-
>  include/dt-bindings/hsi/hsi.h                      | 17 ++++++
>  include/linux/hsi/hsi.h                            |  2 +
>  4 files changed, 124 insertions(+), 1 deletion(-)
>  create mode 100644 Documentation/devicetree/bindings/hsi/trivial-devices.txt
>  create mode 100644 include/dt-bindings/hsi/hsi.h
>
> diff --git a/Documentation/devicetree/bindings/hsi/trivial-devices.txt b/Documentation/devicetree/bindings/hsi/trivial-devices.txt
> new file mode 100644
> index 0000000..1ace14a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hsi/trivial-devices.txt
> @@ -0,0 +1,36 @@
> +This is a list of trivial hsi client devices that have simple
> +device tree bindings, consisting only of a compatible field
> +and the optional hsi configuration.
> +
> +If a device needs more specific bindings, such as properties to
> +describe some aspect of it, there needs to be a specific binding
> +document for it just like any other devices.
> +
> +Optional HSI configuration properties:
> +
> +- hsi,mode             Bit transmission mode (STREAM or FRAME)

hsi is not a vendor prefix, so all these properties should be hsi-*.

> +                       The first value is used for RX and the second one for
> +                       TX configuration. If only one value is provided it will
> +                       be used for RX and TX.
> +                       The assignments may be found in header file
> +                       <dt-bindings/hsi/hsi.h>.
> +- hsi,channels         Number of channels to use [1..16]
> +                       The first value is used for RX and the second one for
> +                       TX configuration. If only one value is provided it will
> +                       be used for RX and TX.
> +- hsi,speed            Max bit transmission speed (Kbit/s)

Include the units in the prop name: hsi-speed-kbps

> +                       The first value is used for RX and the second one for
> +                       TX configuration. If only one value is provided it will
> +                       be used for RX and TX.
> +- hsi,flow             RX flow type (SYNCHRONIZED or PIPELINE)
> +                       The assignments may be found in header file
> +                       <dt-bindings/hsi/hsi.h>.
> +- hsi,arb_mode         Arbitration mode for TX frame (Round robin, priority)
> +                       The assignments may be found in header file
> +                       <dt-bindings/hsi/hsi.h>.
> +
> +This is the list of trivial client devices:
> +
> +Compatible             Description
> +==========             =============
> +hsi-char               HSI character device


I've gotten this far and still have no idea what HSI is.

Rob