From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 881E22772A; Tue, 21 Nov 2023 14:58:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="krU/8KO4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F244DC433CC; Tue, 21 Nov 2023 14:58:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700578706; bh=+gJV5Kq/zk7daeG5FUsmI0jNOy/xuAwkVf/f+7MLU5I=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=krU/8KO4ATWr4zxxJrfvksylFL5Le76um3CUG0EvTiIm3ljSQHX9LDTM68Loi9rXe Lc15EnK4Facj2erJIGoZHXmQOo/scEBf1NhxP2fBu3qAEk2sG2+zM39WUPIuZ03zsh zduzA0o5RhvuAy/Vsc2DuolS70GnfTGdhoAYPnp3+xqeW8hIqdS3LXCEDtxt5IUHoE NGAotlvjGIwRIBNZcleOeWep/c7BL6XVPgUVb1To3eBO2RI0iT/m5uP8xgtQia//Kn YUthVWnYrPL85KPpksW6K62+I2u9g1PZrxJzAbVvN9awyjyzSTEL3+SaOGWp4T3e9G x1sLIt2r9On5w== Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-507962561adso8243693e87.0; Tue, 21 Nov 2023 06:58:25 -0800 (PST) X-Gm-Message-State: AOJu0Yz2AEoTPa91cTrntai2w7JVisMm3MrjRS8ort9V156hayecbqG4 cHGvtlyIKCiven82m1ULoiermthZ3CIrfBO/uA== X-Google-Smtp-Source: AGHT+IHBiGSizQyBkO4Q43LdN/hKHZvdOgdP/et2Xjgl2vIRMj51OZsWwcNiAsGaNW7Y23qV5f4kXncXYdheozxBgQo= X-Received: by 2002:a19:f010:0:b0:505:8075:7c10 with SMTP id p16-20020a19f010000000b0050580757c10mr7788659lfc.25.1700578704209; Tue, 21 Nov 2023 06:58:24 -0800 (PST) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20231116211739.3228239-1-robh@kernel.org> In-Reply-To: From: Rob Herring Date: Tue, 21 Nov 2023 07:58:12 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] arm/arm64: samsung: Enable W=1 on dtbs by default To: Krzysztof Kozlowski Cc: Alim Akhtar , Conor Dooley , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Nov 17, 2023 at 3:19=E2=80=AFAM Krzysztof Kozlowski wrote: > > On 16/11/2023 22:17, Rob Herring wrote: > > Samsung platforms are clean of W=3D1 dtc warnings, so enable the warnin= gs > > by default. This way submitters don't have to remember to run a W=3D1 > > build of the .dts files and the grumpiness of the maintainers can be > > reduced. > > > > Signed-off-by: Rob Herring > > --- > > Well, there's a couple of warnings on 32-bit, but they look fixable to > > me. > > > > There's a few other platforms we could do this to. Sadly, they are stil= l > > the minority. Otherwise, we could change the default and add a flag to > > disable (I_STILL_HAVENT_FIXED_MY_PLATFORMS=3D1). > > 64-bit has still few warnings: > https://krzk.eu/#/builders/29/builds/3710/steps/26/logs/warnings__6_ I may move that graph check to W=3D2. There's some cases where port@1 is optional and it doesn't really make sense to fix these. Also, Conor wants to do this for all of riscv, but this solution is per directory. So I need to rework it to use a different variable that can be per directory or global. Rob