From: Rob Herring <robh+dt@kernel.org>
To: Paul Cercueil <paul@crapouillou.net>
Cc: Sebastian Reichel <sre@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"open list:THERMAL" <linux-pm@vger.kernel.org>,
devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
od@zcrc.me
Subject: Re: [PATCH 1/2] dt-bindings: power/supply: Document generic USB charger
Date: Tue, 5 Nov 2019 07:48:22 -0600 [thread overview]
Message-ID: <CAL_JsqJDT71eThy43kaN3RsU03Ew7aZ_abJg0zhaFxyDH9RhhA@mail.gmail.com> (raw)
In-Reply-To: <1572945391.3.1@crapouillou.net>
On Tue, Nov 5, 2019 at 3:16 AM Paul Cercueil <paul@crapouillou.net> wrote:
>
> Hi Rob,
>
>
> Le lun., nov. 4, 2019 at 07:52, Rob Herring <robh+dt@kernel.org> a
> écrit :
> > On Sun, Nov 3, 2019 at 4:08 PM Paul Cercueil <paul@crapouillou.net>
> > wrote:
> >>
> >> Add documentation about the devicetree bindings for the generic USB
> >> charger.
> >
> > What makes it generic?
>
> It only uses the USB PHY subsystem, which already has some half-baked
> support for chargers but not bound to the power-supply subsystem.
>
>
> >>
> >> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> >> ---
> >> .../bindings/power/supply/usb-charger.txt | 24
> >> +++++++++++++++++++
> >> 1 file changed, 24 insertions(+)
> >> create mode 100644
> >> Documentation/devicetree/bindings/power/supply/usb-charger.txt
> >>
> >> diff --git
> >> a/Documentation/devicetree/bindings/power/supply/usb-charger.txt
> >> b/Documentation/devicetree/bindings/power/supply/usb-charger.txt
> >> new file mode 100644
> >> index 000000000000..fd46734cb0e5
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/power/supply/usb-charger.txt
> >> @@ -0,0 +1,24 @@
> >> +Generic USB charger bindings
> >> +~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >> +
> >> +Required properties :
> >> + - compatible : should be "usb-charger"
> >> + - phys: phandle to the USB PHY
> >> +
> >> +Example:
> >> +
> >> +usb_con: extcon {
> >> + compatible = "linux,extcon-usb-gpio";
> >> + vbus-gpios = <&gpb 5 GPIO_ACTIVE_HIGH>;
> >> +};
> >> +
> >> +usb_phy: usb-phy@0 {
> >> + compatible = "usb-nop-xceiv";
> >> + #phy-cells = <0>;
> >> + extcon = <&usb_con>;
> >
> > extcon is deprecated in favor of usb-connector binding. See
> > .../bindings/connector/usb-connector.txt. There's also some pending
> > patches for adding GPIO based connector controls including Vbus sense
> > (GPIO input) and control (regulator via a GPIO).
> >
> > Rob
>
> I understand that the usb-connector binding is better, but the current
> code doesn't integrate at all with the USB PHY subsystem, which has its
> own code to handle ID and VBUS GPIOs and supports notifiers. Is that
> deprecated then?
>
> What's the big picture here?
Does this series work for you?:
https://patchwork.kernel.org/cover/11120707/
next prev parent reply other threads:[~2019-11-05 13:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-03 22:08 [PATCH 1/2] dt-bindings: power/supply: Document generic USB charger Paul Cercueil
2019-11-03 22:08 ` [PATCH 2/2] power/supply: Add generic USB charger driver Paul Cercueil
2019-11-03 22:52 ` kbuild test robot
2019-11-29 14:03 ` Sebastian Reichel
2019-11-04 13:52 ` [PATCH 1/2] dt-bindings: power/supply: Document generic USB charger Rob Herring
2019-11-05 9:16 ` Paul Cercueil
2019-11-05 13:48 ` Rob Herring [this message]
2019-11-05 23:16 ` Paul Cercueil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqJDT71eThy43kaN3RsU03Ew7aZ_abJg0zhaFxyDH9RhhA@mail.gmail.com \
--to=robh+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=od@zcrc.me \
--cc=paul@crapouillou.net \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).