[PATCH 0/2] Fix dtcheck warnings for mediatek,dpi binding

[PATCH 0/2] Fix dtcheck warnings for mediatek,dpi binding

[Pin-yen Lin]

This series fixes two binding schema errors in mediatek,dpi binding.
The first patch adds the power-domain property to the binding, and the
second patch adds the port node as it's required by the binding.


Pin-yen Lin (2):
  dt-bindings: display: mediatek: dpi: Add power-domains to the bindings
  arm64: dts: mt8183: Add port node to dpi node

 .../bindings/display/mediatek/mediatek,dpi.yaml           | 8 ++++++++
 arch/arm64/boot/dts/mediatek/mt8183.dtsi                  | 4 ++++
 2 files changed, 12 insertions(+)

-- 
2.46.0.662.g92d0881bb0-goog

[PATCH 1/2] dt-bindings: display: mediatek: dpi: Add power-domains to the bindings

[Pin-yen Lin]

The power-domains property is used by most DT nodes using mediatek,dpi
bindings. Add this to the bindings to fix the schema check error.

Signed-off-by: Pin-yen Lin <treapking@chromium.org>
---

 .../bindings/display/mediatek/mediatek,dpi.yaml           | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
index 5ca7679d5427..7e0bb88f5856 100644
--- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
+++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
@@ -42,6 +42,12 @@ properties:
   interrupts:
     maxItems: 1
 
+  power-domains:
+    description:
+      A phandle and PM domain specifier as defined by bindings
+      of the power controller specified by phandle. See
+      Documentation/devicetree/bindings/power/power-domain.yaml for details.
+
   clocks:
     items:
       - description: Pixel Clock
@@ -82,11 +88,13 @@ examples:
   - |
     #include <dt-bindings/interrupt-controller/arm-gic.h>
     #include <dt-bindings/clock/mt8173-clk.h>
+    #include <dt-bindings/power/mt8173-power.h>
 
     dpi0: dpi@1401d000 {
         compatible = "mediatek,mt8173-dpi";
         reg = <0x1401d000 0x1000>;
         interrupts = <GIC_SPI 194 IRQ_TYPE_LEVEL_LOW>;
+        power-domains = <&spm MT8173_POWER_DOMAIN_MM>;
         clocks = <&mmsys CLK_MM_DPI_PIXEL>,
              <&mmsys CLK_MM_DPI_ENGINE>,
              <&apmixedsys CLK_APMIXED_TVDPLL>;
-- 
2.46.0.662.g92d0881bb0-goog

[PATCH 2/2] arm64: dts: mt8183: Add port node to dpi node

[Pin-yen Lin]

Add the port node to fix the binding schema check.

Fixes: 009d855a26fd ("arm64: dts: mt8183: add dpi node to mt8183")
Signed-off-by: Pin-yen Lin <treapking@chromium.org>
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202409110843.Hm5W9upr-lkp@intel.com/

---

 arch/arm64/boot/dts/mediatek/mt8183.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
index 266441e999f2..0a6578aacf82 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
@@ -1845,6 +1845,10 @@ dpi0: dpi@14015000 {
 				 <&mmsys CLK_MM_DPI_MM>,
 				 <&apmixedsys CLK_APMIXED_TVDPLL>;
 			clock-names = "pixel", "engine", "pll";
+
+			port {
+				dpi_out: endpoint { };
+			};
 		};
 
 		mutex: mutex@14016000 {
-- 
2.46.0.662.g92d0881bb0-goog

Re: [PATCH 2/2] arm64: dts: mt8183: Add port node to dpi node

[Rob Herring]

On Thu, Sep 12, 2024 at 9:44 AM Pin-yen Lin <treapking@chromium.org> wrote:
>
> Add the port node to fix the binding schema check.

The dsi node has the same issue.

> Fixes: 009d855a26fd ("arm64: dts: mt8183: add dpi node to mt8183")
> Signed-off-by: Pin-yen Lin <treapking@chromium.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202409110843.Hm5W9upr-lkp@intel.com/
>
> ---
>
>  arch/arm64/boot/dts/mediatek/mt8183.dtsi | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> index 266441e999f2..0a6578aacf82 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> @@ -1845,6 +1845,10 @@ dpi0: dpi@14015000 {
>                                  <&mmsys CLK_MM_DPI_MM>,
>                                  <&apmixedsys CLK_APMIXED_TVDPLL>;
>                         clock-names = "pixel", "engine", "pll";
> +
> +                       port {
> +                               dpi_out: endpoint { };
> +                       };
>                 };
>
>                 mutex: mutex@14016000 {
> --
> 2.46.0.662.g92d0881bb0-goog
>

Re: [PATCH 1/2] dt-bindings: display: mediatek: dpi: Add power-domains to the bindings

[Rob Herring]

On Thu, Sep 12, 2024 at 9:44 AM Pin-yen Lin <treapking@chromium.org> wrote:
>
> The power-domains property is used by most DT nodes using mediatek,dpi
> bindings. Add this to the bindings to fix the schema check error.
>
> Signed-off-by: Pin-yen Lin <treapking@chromium.org>
> ---
>
>  .../bindings/display/mediatek/mediatek,dpi.yaml           | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
> index 5ca7679d5427..7e0bb88f5856 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
> @@ -42,6 +42,12 @@ properties:
>    interrupts:
>      maxItems: 1
>
> +  power-domains:
> +    description:
> +      A phandle and PM domain specifier as defined by bindings
> +      of the power controller specified by phandle. See
> +      Documentation/devicetree/bindings/power/power-domain.yaml for details.

power-domains was already added recently, but mt8183 was not included.
So you'll need to adjust the if/then schema for it.

Rob

Re: (subset) [PATCH 0/2] Fix dtcheck warnings for mediatek,dpi binding

[AngeloGioacchino Del Regno]

On Thu, 12 Sep 2024 22:43:57 +0800, Pin-yen Lin wrote:
> This series fixes two binding schema errors in mediatek,dpi binding.
> The first patch adds the power-domain property to the binding, and the
> second patch adds the port node as it's required by the binding.
> 
> 
> Pin-yen Lin (2):
>   dt-bindings: display: mediatek: dpi: Add power-domains to the bindings
>   arm64: dts: mt8183: Add port node to dpi node
> 
> [...]

Applied to v6.12-next/dts64, thanks!

[2/2] arm64: dts: mt8183: Add port node to dpi node
      https://git.kernel.org/mediatek/c/ec1a37b3

Cheers,
Angelo

Re: [PATCH 2/2] arm64: dts: mt8183: Add port node to dpi node

[Rob Herring]

On Fri, Sep 13, 2024 at 4:37 PM Rob Herring <robh@kernel.org> wrote:
>
> On Thu, Sep 12, 2024 at 9:44 AM Pin-yen Lin <treapking@chromium.org> wrote:
> >
> > Add the port node to fix the binding schema check.
>
> The dsi node has the same issue.

This is still causing warnings in the tree. Please respin the patch.

>
> > Fixes: 009d855a26fd ("arm64: dts: mt8183: add dpi node to mt8183")
> > Signed-off-by: Pin-yen Lin <treapking@chromium.org>
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202409110843.Hm5W9upr-lkp@intel.com/
> >
> > ---
> >
> >  arch/arm64/boot/dts/mediatek/mt8183.dtsi | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > index 266441e999f2..0a6578aacf82 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > @@ -1845,6 +1845,10 @@ dpi0: dpi@14015000 {
> >                                  <&mmsys CLK_MM_DPI_MM>,
> >                                  <&apmixedsys CLK_APMIXED_TVDPLL>;
> >                         clock-names = "pixel", "engine", "pll";
> > +
> > +                       port {
> > +                               dpi_out: endpoint { };
> > +                       };
> >                 };
> >
> >                 mutex: mutex@14016000 {
> > --
> > 2.46.0.662.g92d0881bb0-goog
> >