From: Rob Herring <robh+dt@kernel.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Grant Likely <grant.likely@linaro.org>
Subject: Re: [PATCH] of/address: replace printk(KERN_ERR ...) with pr_err(...)
Date: Sun, 6 Dec 2015 14:40:01 -0600 [thread overview]
Message-ID: <CAL_JsqJNsQtGe9cUJVj_iqzsRfB+CyCxACNW6FBDDE28T3tm_w@mail.gmail.com> (raw)
In-Reply-To: <1448864059-12319-1-git-send-email-yamada.masahiro@socionext.com>
On Mon, Nov 30, 2015 at 12:14 AM, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
> A trivial change suggested by checkpatch.pl.
You might as well all levels while you are at it. Looks like that is
only one more:
drivers/of/address.c: printk(KERN_DEBUG "%s", s);
Rob
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> drivers/of/address.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/of/address.c b/drivers/of/address.c
> index cd53fe4..5289c80 100644
> --- a/drivers/of/address.c
> +++ b/drivers/of/address.c
> @@ -596,7 +596,7 @@ static u64 __of_translate_address(struct device_node *dev,
> pbus = of_match_bus(parent);
> pbus->count_cells(dev, &pna, &pns);
> if (!OF_CHECK_COUNTS(pna, pns)) {
> - printk(KERN_ERR "prom_parse: Bad cell count for %s\n",
> + pr_err("prom_parse: Bad cell count for %s\n",
> of_node_full_name(dev));
> break;
> }
> --
> 1.9.1
>
next prev parent reply other threads:[~2015-12-06 20:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-30 6:14 [PATCH] of/address: replace printk(KERN_ERR ...) with pr_err(...) Masahiro Yamada
2015-12-06 20:40 ` Rob Herring [this message]
[not found] ` <CAL_JsqJNsQtGe9cUJVj_iqzsRfB+CyCxACNW6FBDDE28T3tm_w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-12-08 16:09 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqJNsQtGe9cUJVj_iqzsRfB+CyCxACNW6FBDDE28T3tm_w@mail.gmail.com \
--to=robh+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=grant.likely@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).