From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A495E5820D; Thu, 11 Jan 2024 22:03:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qQETrqDh" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2DFF0C43399; Thu, 11 Jan 2024 22:03:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705010619; bh=jN9g+MnTl+CuJ+/RvoYQJ0TAQWXECkq+Sx15c1NcM4c=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=qQETrqDh5M/ns6SFVKQSqUS42/kaxrvLrN8y2KF4vmyBIt1pOK66I2YZUfAYK80P8 4Ri50DkUoL/qQqqxRtTxh//fxrXSmxd6IeORDZTRpD+5lOl30hO4EOa1CuXOdJkvQN Uq195P7kItZ4h6nIyqPHGLxZeeXqeJ2JaIyouph2k3r5XEpWduk873MXI5NoTpcEnu CJm4XunD/djKIX/nD2nOWLWQWO+OsS9Re8qxJq6b+dL8gwEgOylQ70EF4eIf0FmIO7 ixNZdO550n/YmEFVIUR9uMIXHi0KeodQGv+tmV2UhkgiM4KlpAk36iUBaSaKp1qMzG cJ1WiUt/sMT8w== Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-2cd5b467209so52432941fa.3; Thu, 11 Jan 2024 14:03:39 -0800 (PST) X-Gm-Message-State: AOJu0YwOZI+pKy/8XYCpN0XHjHhQKZL0tobFaDe/TeeUQIVFhtzbDBgS TaAzzC/7tVv21dDuVVgq772QTuUv0CN3DTNDqg== X-Google-Smtp-Source: AGHT+IGqQEJRlx5vqZKnSFNrc+k4aJn7Nwqxw+vCHtTG57ACO6acRmhTsCZusCpdLBlZG73fSAeQv2CiH9ue0nIZVs4= X-Received: by 2002:a2e:9e97:0:b0:2cc:610d:ca6 with SMTP id f23-20020a2e9e97000000b002cc610d0ca6mr198479ljk.81.1705010617334; Thu, 11 Jan 2024 14:03:37 -0800 (PST) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240109-axi-spi-engine-series-3-v1-0-e42c6a986580@baylibre.com> <20240109-axi-spi-engine-series-3-v1-2-e42c6a986580@baylibre.com> In-Reply-To: <20240109-axi-spi-engine-series-3-v1-2-e42c6a986580@baylibre.com> From: Rob Herring Date: Thu, 11 Jan 2024 16:03:24 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 02/13] scripts: dtc: checks: don't warn on SPI non-peripheral child nodes To: David Lechner Cc: Mark Brown , Jonathan Cameron , Krzysztof Kozlowski , Conor Dooley , Michael Hennerich , =?UTF-8?B?TnVubyBTw6E=?= , Frank Rowand , Thierry Reding , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Jonathan Corbet , linux-spi@vger.kernel.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Jan 10, 2024 at 1:51=E2=80=AFPM David Lechner wrote: > > According to the spi-controller.yaml bindings, SPI peripheral child > nodes match the pattern "^.*@[0-9a-f]+$". > > A SPI controller binding may require a child object node that is not a > peripheral. For example, the adi,axi-spi-engine binding requires an > "offloads" child node that is not a peripheral but rather a part of the > controller itself. > > By checking for '@' in the node name, we can avoids a warnings like: > > Warning (spi_bus_reg): /example-0/spi@44a00000/offloads: missing or e= mpty reg property > > for a binding like: > > spi { > ... > > offloads { > offload@0 { > ... > }; > ... > }; > > peripheral@0 { > ... > }; > }; > > Signed-off-by: David Lechner > --- > scripts/dtc/checks.c | 4 ++++ > 1 file changed, 4 insertions(+) Check the commit history. We don't take changes to kernel's dtc copy. They must go upstream first. Rob