Re: [PATCH] Documentation/devicetree: document OCTEON USB bindings

[Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

On Fri, May 1, 2015 at 11:15 AM, Aaro Koskinen <aaro.koskinen-X3B1VOXEql0@public.gmane.org> wrote:
> Hi,
>
> On Fri, May 01, 2015 at 09:39:19AM -0500, Rob Herring wrote:
>> > +   - refclk-frequency: speed of the USB reference clock. Allowed values are
>> > +     12000000, 24000000 or 48000000.
>>
>> We already have a standard property for this if you only have 1 clock:
>> clock-frequency.
>>
>> > +   - refclk-type: type of the USB reference clock. Allowed values are
>> > +     "crystal" or "external".
>>
>> Should be prefixed with "cavium,".
>
> Both of these are already used in
> Documentation/devicetree/bindings/mips/cavium/uctl.txt (the USB
> controller for newer OCTEONs). These bindings are unfortunately
> just "reverse-engineered" from products that are already shipping
> and likely not perfect, but shouldn't we still try to be compatible
> for the sake of users?

Well, generally we don't just accept whatever crap people came up with
behind closed doors. But for this case, I'm not going to bikeshed it.

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html