From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3ABABCA0EC3 for ; Tue, 12 Sep 2023 01:46:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234909AbjILBqe (ORCPT ); Mon, 11 Sep 2023 21:46:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44924 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235573AbjILBqT (ORCPT ); Mon, 11 Sep 2023 21:46:19 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4149713AF20; Mon, 11 Sep 2023 16:43:22 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 38525C433BA; Mon, 11 Sep 2023 21:06:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694466391; bh=emY+8OOcII6sxAHBz/ueLAdDUaQM+gjoMKh7SHfBk1M=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Tfe97YsfXcfKG5h/8G4yZP+eRv0qt8cCoMlRBYzI0MAfyU4DdQKymBPxuPSEvuPyB NyC0hnNLkbs5Xs860kSiFKoD1O2W84hsUijA9DTiJASMNBiq/3de5qPC8geSoEVkRh SOfkxgUYfuplCjC8lFKGCdKsBWZx0wUj1yxHCvvPupYNdxSflhB/yvVNrBC5LG9KW0 5RpQhlAzzCN6IIeJnUGhm+FyS/qgBH9LkYKRnYkOFZEr9T8o9eFhtADqBv5xIUvccf 45ua3df6Lrc7W2v1XbZqdzyaREJIExUwp3zVzXT5fvES8+qwNRnEJ9AQSwd0BH7X8I v1AsIuZW5dzIg== Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-500913779f5so8460595e87.2; Mon, 11 Sep 2023 14:06:31 -0700 (PDT) X-Gm-Message-State: AOJu0YzNNkdb0zoBno1uD67kyz5MBGNE55W7/3LxJ4khZi0vAZQ9rFY8 5rP0ejFBLZf3pZyE75ymcUyRHlHWIgHQJeC1DA== X-Google-Smtp-Source: AGHT+IFIlnCjhKkjK04xViV3+eFz0aY5IAvCPJkUT/P8yaXEYd0nahR4SLre1VfiOPhvbszphcoq47BjPmOBQ6Yktoc= X-Received: by 2002:a05:6512:3496:b0:500:863e:fc57 with SMTP id v22-20020a056512349600b00500863efc57mr7380863lfr.25.1694466389428; Mon, 11 Sep 2023 14:06:29 -0700 (PDT) MIME-Version: 1.0 References: <20230901072730.13571-1-linux@fw-web.de> <76060BF0-B432-4BB8-A5C8-39EFF3D628EA@public-files.de> In-Reply-To: <76060BF0-B432-4BB8-A5C8-39EFF3D628EA@public-files.de> From: Rob Herring Date: Mon, 11 Sep 2023 16:06:16 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v1] arm64: dts: mt7986: add overlay for SATA power socket on BPI-R3 To: frank-w@public-files.de Cc: Frank Wunderlich , linux-mediatek@lists.infradead.org, Matthias Brugger , AngeloGioacchino Del Regno , Krzysztof Kozlowski , Conor Dooley , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Sep 11, 2023 at 3:11=E2=80=AFPM Frank Wunderlich wrote: > > Am 11. September 2023 21:51:42 MESZ schrieb Rob Herring : > >On Fri, Sep 1, 2023 at 2:27=E2=80=AFAM Frank Wunderlich wrote: > >> > >> From: Frank Wunderlich > >> > >> Bananapi R3 has a Power socket entended for using external SATA drives= . > >> This Socket is off by default but can be switched with gpio 8. > >> > >> Add an overlay to activate it. > >> > >> Signed-off-by: Frank Wunderlich > >> --- > >> arch/arm64/boot/dts/mediatek/Makefile | 1 + > >> .../mt7986a-bananapi-bpi-r3-sata.dtso | 39 ++++++++++++++++++= + > >> 2 files changed, 40 insertions(+) > >> create mode 100644 arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-= r3-sata.dtso > >> > >> diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/d= ts/mediatek/Makefile > >> index c99c3372a4b5..822d3e36d3df 100644 > >> --- a/arch/arm64/boot/dts/mediatek/Makefile > >> +++ b/arch/arm64/boot/dts/mediatek/Makefile > >> @@ -13,6 +13,7 @@ dtb-$(CONFIG_ARCH_MEDIATEK) +=3D mt7986a-bananapi-bp= i-r3-emmc.dtbo > >> dtb-$(CONFIG_ARCH_MEDIATEK) +=3D mt7986a-bananapi-bpi-r3-nand.dtbo > >> dtb-$(CONFIG_ARCH_MEDIATEK) +=3D mt7986a-bananapi-bpi-r3-nor.dtbo > >> dtb-$(CONFIG_ARCH_MEDIATEK) +=3D mt7986a-bananapi-bpi-r3-sd.dtbo > >> +dtb-$(CONFIG_ARCH_MEDIATEK) +=3D mt7986a-bananapi-bpi-r3-sata.dtbo > > > >The requirement for overlays is they have a target base dt in tree and > >that you apply the overlay to it. All these existing overlays have the > >same problem which I pointed out when you submitted them. Please fix > >the existing ones before adding more. > > > > > >Rob > > Hi Rob, > > i do not understand the problem as there is a target base dt...mt7986a-ba= nanapi-bpi-r3.dtb. > > Do you mean that overlays should be merged with basedt at compiletime? Yes, because we want to know an overlay can actually apply to what's upstre= am. > We pack the base-dt and all overlays into one fit image and let uboot dyn= amically select the combination to apply. E.g. check if emmc is available, = if yes apply emmc overlay else the sd one,same for nand/nor. That's irrelevant. Though do you really want to wait until that point to find out you made some mistake in your overlay that it doesn't apply when you could find out much sooner? > Else i do not know *how* to fix as i don't see it as broken. You need what I pointed out last time[1]. Rob [1] https://lore.kernel.org/all/CAL_JsqK_3xxD0DFwipXO85P=3Dq=3DEYjUdjE1_8g1= MKtvw3vVzx5A@mail.gmail.com/