From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32C4745F77; Fri, 22 Sep 2023 19:45:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F816C43391; Fri, 22 Sep 2023 19:45:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695411957; bh=Z73INrp+tUCDrn3nt/IznNU60OcEzvbVv581pkRDXlE=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=P4ZZPqOmhipnrgdjc5Cicuv4gwGoR5ahpSW6RraPJhB2FOCevSoVAq7M03SUqbiJq K7C83A8rvE9vTWF2PZ5kYCMKgg3G1IVvpRh+NW3hqCEKgBE5APzZ0p6is/9D0IzpXy L4KFq+qRrX7Nsl9X/FVhceTOut8PENgISZ7V9Hgc0n17gQFch+sOZHm06uwoEbBMFg bdQku4DZghgBK/X1clycJXNjGfpUaVv8cK0r9G/b2uMU+jMiHYfIm/lqjl9v/3n8cS tduJT5OdwlLHx5IjPVmN9jiMNIWgStlkcTXysI9oJM3ogbUGEUzRoqqQuRZPSge2DG XwBXMnxxa/mIQ== Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-502e7d66c1eso4403480e87.1; Fri, 22 Sep 2023 12:45:57 -0700 (PDT) X-Gm-Message-State: AOJu0YzET3fIoLVxGM9RxuqSwL+djuYNXhC9P6ZumOlepuoR4JARMjx+ h4LOZERLC7Rm7GHf2X+sobwCVY8k0UHqW/Y9dA== X-Google-Smtp-Source: AGHT+IEyL15UWPDOOifALHGXr9zT3PFp6EFjcQQ6N5sRMKjOVNVOEvEhKETlB6KYvfp58mdiyeysUyZjSt5CkUaQLB8= X-Received: by 2002:a19:651e:0:b0:503:18c5:6833 with SMTP id z30-20020a19651e000000b0050318c56833mr310830lfb.61.1695411955742; Fri, 22 Sep 2023 12:45:55 -0700 (PDT) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20230922075913.422435-1-herve.codina@bootlin.com> <20230922075913.422435-26-herve.codina@bootlin.com> <169538601225.2919383.2942072541503354871.robh@kernel.org> <20230922154546.4ca18b6f@bootlin.com> In-Reply-To: <20230922154546.4ca18b6f@bootlin.com> From: Rob Herring Date: Fri, 22 Sep 2023 14:45:43 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v6 25/30] dt-bindings: net: Add the Lantiq PEF2256 E1/T1/J1 framer To: Herve Codina Cc: linux-arm-kernel@lists.infradead.org, Randy Dunlap , Takashi Iwai , Simon Horman , Jaroslav Kysela , Liam Girdwood , Thomas Petazzoni , linux-gpio@vger.kernel.org, Krzysztof Kozlowski , netdev@vger.kernel.org, Fabio Estevam , Eric Dumazet , Andrew Lunn , Christophe JAILLET , Christophe Leroy , Nicolin Chen , Conor Dooley , Mark Brown , Linus Walleij , alsa-devel@alsa-project.org, Paolo Abeni , Lee Jones , linux-kernel@vger.kernel.org, "David S. Miller" , Jakub Kicinski , Xiubo Li , Shengjiu Wan g , linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org, Li Yang , Qiang Zhao Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Sep 22, 2023 at 8:46=E2=80=AFAM Herve Codina wrote: > > Hi Rob, > > On Fri, 22 Sep 2023 07:33:32 -0500 > Rob Herring wrote: > > > On Fri, 22 Sep 2023 09:59:00 +0200, Herve Codina wrote: > > > The Lantiq PEF2256 is a framer and line interface component designed = to > > > fulfill all required interfacing between an analog E1/T1/J1 line and = the > > > digital PCM system highway/H.100 bus. > > > > > > Signed-off-by: Herve Codina > > > Reviewed-by: Christophe Leroy > > > --- > > > .../bindings/net/lantiq,pef2256.yaml | 214 ++++++++++++++++= ++ > > > 1 file changed, 214 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/net/lantiq,pef2= 256.yaml > > > > > > > My bot found errors running 'make DT_CHECKER_FLAGS=3D-m dt_binding_chec= k' > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings= /net/lantiq,pef2256.yaml: properties:lantiq,data-rate-bps: '$ref' should no= t be valid under {'const': '$ref'} > > hint: Standard unit suffix properties don't need a type $ref > > from schema $id: http://devicetree.org/meta-schemas/core.yaml# > > > > The '-bps' suffix was added recently in > https://github.com/devicetree-org/dt-schema/ > commit 033d0b1 ("Add '-bps' as a standard unit suffix for bits per second= ") > > This commit is not yet present in any dt-schema release. > > Should I update my patch (ie. removing $ref) right now even if this updat= e will > make the last dt-schema release not happy ? Yes. I will spin a release soon as well. Rob