devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Marco Franchi <marco.franchi-3arQi8VN3Tc@public.gmane.org>
Cc: Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	Fabio Estevam <festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Marco Antonio Franchi
	<marcofrk-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v2 1/6] ARM: dts: imx51-apf51dev: Fix 'backlight@bl1' node with unit name and no reg property
Date: Wed, 18 Oct 2017 15:12:33 -0500	[thread overview]
Message-ID: <CAL_JsqJZD+DTe9-sAX+MbHr2ZZz3riXQ7nFcy5OmADK+a2F9SQ@mail.gmail.com> (raw)
In-Reply-To: <1508354991-18016-1-git-send-email-marco.franchi-3arQi8VN3Tc@public.gmane.org>

On Wed, Oct 18, 2017 at 2:29 PM, Marco Franchi <marco.franchi-3arQi8VN3Tc@public.gmane.org> wrote:
> The following build warning is seen with W=1:
>
> Warning (unit_address_vs_reg): Node /backlight@bl1 has a unit name, but no
> reg property
>
> Fix this warning by changing '@' to '-'.
>
> Signed-off-by: Marco Franchi <marco.franchi-3arQi8VN3Tc@public.gmane.org>
> ---
> Changes since v1:
> -none
>  arch/arm/boot/dts/imx51-apf51dev.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx51-apf51dev.dts b/arch/arm/boot/dts/imx51-apf51dev.dts
> index 2f1a9d2..a6c2c11 100644
> --- a/arch/arm/boot/dts/imx51-apf51dev.dts
> +++ b/arch/arm/boot/dts/imx51-apf51dev.dts
> @@ -16,7 +16,7 @@
>         model = "Armadeus Systems APF51Dev docking/development board";
>         compatible = "armadeus,imx51-apf51dev", "armadeus,imx51-apf51", "fsl,imx51";
>
> -       backlight@bl1{
> +       backlight-bl1{

Is there more that one? If not, just "backlight".

You also should have a space before the {.

>                 pinctrl-names = "default";
>                 pinctrl-0 = <&pinctrl_backlight>;
>                 compatible = "gpio-backlight";
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      parent reply	other threads:[~2017-10-18 20:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-18 19:29 [PATCH v2 1/6] ARM: dts: imx51-apf51dev: Fix 'backlight@bl1' node with unit name and no reg property Marco Franchi
     [not found] ` <1508354991-18016-1-git-send-email-marco.franchi-3arQi8VN3Tc@public.gmane.org>
2017-10-18 19:29   ` [PATCH v2 2/6] ARM: dts: imx51-ts4800: Fix 'port@0' " Marco Franchi
2017-10-18 19:29   ` [PATCH v2 3/6] ARM: dts: imx53: Fix 'usbphy@x' " Marco Franchi
2017-10-18 19:29   ` [PATCH v2 4/6] ARM: dts: imx53-m53evk: Fix 'led_gpio@0' " Marco Franchi
2017-10-18 19:29   ` [PATCH v2 5/6] ARM: dts: imx53-qsb-common: Fix 'led_gpio7_7@0' " Marco Franchi
2017-10-18 19:29   ` [PATCH v2 6/6] ARM: dts: imx53-tx53: Fix 'ethernet-phy@0' " Marco Franchi
     [not found]     ` <1508354991-18016-6-git-send-email-marco.franchi-3arQi8VN3Tc@public.gmane.org>
2017-10-18 20:15       ` Rob Herring
2017-10-18 20:12   ` Rob Herring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAL_JsqJZD+DTe9-sAX+MbHr2ZZz3riXQ7nFcy5OmADK+a2F9SQ@mail.gmail.com \
    --to=robh-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=marco.franchi-3arQi8VN3Tc@public.gmane.org \
    --cc=marcofrk-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).