From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54810C432BE for ; Mon, 30 Aug 2021 15:05:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 347FA60E77 for ; Mon, 30 Aug 2021 15:05:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237438AbhH3PG3 (ORCPT ); Mon, 30 Aug 2021 11:06:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:55698 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237123AbhH3PG0 (ORCPT ); Mon, 30 Aug 2021 11:06:26 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id BE6EE60F45; Mon, 30 Aug 2021 15:05:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630335932; bh=+w96EgfxB/OnIF4TZZubblNzgSY24akfalBQTQOBFSQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=kCwB0oJQhw9Sx58A5G93DB0VLM6imlaIM/sb/B7vDMY7X22XPdqQnS7BWCZ5Sqq6y Dq8la0BAuDSPiVjYNY6UBGJb2ScyD1ph+kvF7IyVV//+RDgNrUkvFhq784DXfF+I1Q 0xCG0FaUen2RMwYJbNQ9TY3zYh3YTBOP7P7PYGPhwk6b3cVyo1UL3hwb9ELWPw58vt /tZ1Pfszrlnx2ouCcpZrhhsSRk0HVjq9R9L+tcuf8+uEEX1tDJkQOLDYDqbnpEL728 pbGAx2Q0KhCCyCbEat8PcupTItksBdrDKJRwBM6Wgb1eDc/MQZ4CQIzmpw9657m+yI LN/w1gYFdT5yQ== Received: by mail-ej1-f49.google.com with SMTP id n27so31859346eja.5; Mon, 30 Aug 2021 08:05:32 -0700 (PDT) X-Gm-Message-State: AOAM531ojrIBQXt9LJ5uOtprpvOhP6wgljssPrR8S5Oxk1/IZhm4GLsy B/9m8V43gxDCRgCguIafKKn1LCUD4HtDIew/6g== X-Google-Smtp-Source: ABdhPJyF3KMiFYr5oMzxYuwKYn4Ft/XJo6sPgysJQrJltM5HoP9Y3XlZs6D0letv4tX1E+fvnmMyrNrRlEjQqFfRe20= X-Received: by 2002:a17:906:b4d:: with SMTP id v13mr26149139ejg.468.1630335931267; Mon, 30 Aug 2021 08:05:31 -0700 (PDT) MIME-Version: 1.0 References: <20210824100027.25989-1-moudy.ho@mediatek.com> <20210824100027.25989-4-moudy.ho@mediatek.com> <0092244acd520acac81208b8863b15fba58f4193.camel@mediatek.com> In-Reply-To: <0092244acd520acac81208b8863b15fba58f4193.camel@mediatek.com> From: Rob Herring Date: Mon, 30 Aug 2021 10:05:19 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v7 3/5] dt-binding: mt8183: Add Mediatek MDP3 dt-bindings To: moudy ho Cc: Mauro Carvalho Chehab , Matthias Brugger , Hans Verkuil , Jernej Skrabec , Maoguang Meng , daoyuan huang , Ping-Hsun Wu , Geert Uytterhoeven , Rob Landley , Laurent Pinchart , Linux Media Mailing List , devicetree@vger.kernel.org, linux-arm-kernel , "moderated list:ARM/Mediatek SoC support" , "linux-kernel@vger.kernel.org" , Tomasz Figa , Nicolas Boichat , Alexandre Courbot , Pi-Hsun Shih , menghui.lin@mediatek.com, Sj Huang , ben.lok@mediatek.com, randy.wu@mediatek.com, srv_heupstream , Hsin-Yi Wang Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Aug 30, 2021 at 2:58 AM moudy ho wrote: > > On Tue, 2021-08-24 at 13:02 -0500, Rob Herring wrote: > > On Tue, Aug 24, 2021 at 06:00:25PM +0800, Moudy Ho wrote: > > > This patch adds DT binding document for Media Data Path 3 (MDP3) > > > a unit in multimedia system used for scaling and color format > > > convert. > > > > > > Signed-off-by: Moudy Ho > > > --- > > > .../bindings/media/mediatek,mdp3-ccorr.yaml | 57 +++++ > > > .../bindings/media/mediatek,mdp3-rdma.yaml | 207 > > > ++++++++++++++++++ > > > .../bindings/media/mediatek,mdp3-rsz.yaml | 65 ++++++ > > > .../bindings/media/mediatek,mdp3-wdma.yaml | 71 ++++++ > > > .../bindings/media/mediatek,mdp3-wrot.yaml | 71 ++++++ > > > 5 files changed, 471 insertions(+) > > > create mode 100644 > > > Documentation/devicetree/bindings/media/mediatek,mdp3-ccorr.yaml > > > create mode 100644 > > > Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml > > > create mode 100644 > > > Documentation/devicetree/bindings/media/mediatek,mdp3-rsz.yaml > > > create mode 100644 > > > Documentation/devicetree/bindings/media/mediatek,mdp3-wdma.yaml > > > create mode 100644 > > > Documentation/devicetree/bindings/media/mediatek,mdp3-wrot.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3- > > > ccorr.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3- > > > ccorr.yaml > > > new file mode 100644 > > > index 000000000000..59fd68b46022 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3- > > > ccorr.yaml > > > @@ -0,0 +1,57 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: > > > https://urldefense.com/v3/__http://devicetree.org/schemas/media/mediatek,mdp3-ccorr.yaml*__;Iw!!CTRNKA9wMg0ARbw!1C0ChLqzi7Zq8D2d4_S4IqCEei4GXdgy3_VCQg8MdsJP7n8TlxbGyajipusfH8hi$ > > > > > > +$schema: > > > https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!CTRNKA9wMg0ARbw!1C0ChLqzi7Zq8D2d4_S4IqCEei4GXdgy3_VCQg8MdsJP7n8TlxbGyajipi-OInix$ > > > > > > + > > > +title: Mediatek Media Data Path 3 CCORR Device Tree Bindings > > > + > > > +maintainers: > > > + - Daoyuan Huang > > > + - Moudy Ho > > > + > > > +description: | > > > + One of Media Data Path 3 (MDP3) components used to do color > > > correction with 3X3 matrix. > > > + > > > +properties: > > > + compatible: > > > + items: > > > + - enum: > > > + - mediatek,mt8183-mdp3-ccorr > > > + > > > + mediatek,mdp3-id: > > > + $ref: /schemas/types.yaml#/definitions/uint32 > > > + maxItems: 1 > > > + description: | > > > + HW index to distinguish same functionality modules. > > > > If we wanted h/w indexes in DT, we'd have a standard property. Why > > do > > you need this? > > > I'm sorry not quite sure what HW indexes means (something like > aliases?) It means whatever you said in your description. And no, I'm not suggesting you use aliases. > It was originally used to mark multiple identical modules in the MDP > data path algorithm, so that appropriate paths can be dynamically > dispatched. If they are identical, then why do you need to distinguish them in DT? If there's some difference you need to know about such as connections to other blocks, then describe that. Another common example is needing to know what bits/registers to access in a syscon phandle. For that, make the register offset or bits be args to the phandle property. Rob