From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v3 3/3] PCI: imx6: Add support for i.MX8MQ Date: Tue, 18 Dec 2018 15:10:43 -0600 Message-ID: References: <20181218040702.29231-1-andrew.smirnov@gmail.com> <20181218040702.29231-4-andrew.smirnov@gmail.com> <20181218151533.GA2922@bogus> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Leonard Crestez Cc: Andrey Smirnov , Lucas Stach , Lorenzo Pieralisi , Bjorn Helgaas , Fabio Estevam , Chris Healy , Dong Aisheng , Richard Zhu , devicetree@vger.kernel.org, NXP Linux Team , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "linux-kernel@vger.kernel.org" , linux-pci@vger.kernel.org List-Id: devicetree@vger.kernel.org On Tue, Dec 18, 2018 at 12:09 PM Leonard Crestez wrote: > > On 12/18/2018 5:15 PM, Rob Herring wrote: > > On Mon, Dec 17, 2018 at 08:07:02PM -0800, Andrey Smirnov wrote: > >> Add code needed to support i.MX8MQ variant. > >> > >> Signed-off-by: Andrey Smirnov > >> Reviewed-by: Lucas Stach > > >> --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt > >> +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt > >> > >> +Additional required properties for imx8mq-pcie: > >> +- fsl,controller-id: Logical ID of a given PCIE controller. PCIE1 is 0, PCIE2 is 1; > >> + > > > > Remove this. > > > > If GPR register offset is what you need, then put that into DT. > > Typically, we'd have a property with iomuxc phandle and offset. > > This series initially added explicit offsets but I suggested a single > "controller-id" because: > * There are multiple bit and byte offsets > * Other imx8 SOCs also have 2x pcie with other bit/byte offsets > > Hiding this behind a compatible string and single "controller-id" seem > preferable to elaborating register maps in dt bindings. It also makes > upgrades simpler: if features are added which use other bits there is no > need to describe them in DT and deal with compatibility headaches. You already have an id for the controllers: the address. Use that if you don't want to put the register offsets in DT. Rob