From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Sam Protsenko <semen.protsenko@linaro.org>,
Jiri Slaby <jirislaby@kernel.org>,
linux-samsung-soc@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Chanho Park <chanho61.park@samsung.com>,
linux-serial@vger.kernel.org,
Youngmin Nam <youngmin.nam@samsung.com>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
David Virag <virag.david003@gmail.com>,
Jaewon Kim <jaewon02.kim@samsung.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 RESEND 1/5] dt-bindings: soc: samsung: Add Exynos USI bindings
Date: Wed, 1 Dec 2021 10:19:47 -0600 [thread overview]
Message-ID: <CAL_JsqJb4nMBoGLcf-bKpi5kEE+zXQ=dfo5JSBhrqPFeLnCsHw@mail.gmail.com> (raw)
In-Reply-To: <4b5bebb0-ed74-8132-1e6b-cb7cbc21439c@canonical.com>
On Tue, Nov 30, 2021 at 2:04 PM Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:
>
> On 30/11/2021 18:43, Rob Herring wrote:
> > On Tue, 30 Nov 2021 13:13:21 +0200, Sam Protsenko wrote:
> >> Add constants for choosing USIv2 configuration mode in device tree.
> >> Those are further used in USI driver to figure out which value to write
> >> into SW_CONF register. Also document USIv2 IP-core bindings.
> >>
> >> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
> >> ---
> >> Changes in v2:
> >> - Combined dt-bindings doc and dt-bindings header patches
> >> - Added i2c node to example in bindings doc
> >> - Added mentioning of shared internal circuits
> >> - Added USI_V2_NONE value to bindings header
> >>
> >> .../bindings/soc/samsung/exynos-usi.yaml | 135 ++++++++++++++++++
> >> include/dt-bindings/soc/samsung,exynos-usi.h | 17 +++
> >> 2 files changed, 152 insertions(+)
> >> create mode 100644 Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml
> >> create mode 100644 include/dt-bindings/soc/samsung,exynos-usi.h
> >>
> >
> > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> >
> > yamllint warnings/errors:
> >
> > dtschema/dtc warnings/errors:
> > Documentation/devicetree/bindings/soc/samsung/exynos-usi.example.dts:35.39-42.15: Warning (unique_unit_address): /example-0/usi@138200c0/serial@13820000: duplicate unit-address (also used in node /example-0/usi@138200c0/i2c@13820000)
>
> Rob,
>
> The checker complains about two nodes with same unit-address, even
> though the node name is different. Does it mean that our idea of
> embedding two children in USI and having enabled only one (used one) is
> wrong?
IIRC, we allow for this exact scenario, and there was a change in dtc
for it. So I'm not sure why this triggered.
Rob
next prev parent reply other threads:[~2021-12-01 16:20 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-30 11:13 [PATCH v2 RESEND 0/5] soc: samsung: Add USI driver Sam Protsenko
2021-11-30 11:13 ` [PATCH v2 RESEND 1/5] dt-bindings: soc: samsung: Add Exynos USI bindings Sam Protsenko
2021-11-30 17:43 ` Rob Herring
2021-11-30 20:04 ` Krzysztof Kozlowski
2021-12-01 16:19 ` Rob Herring [this message]
2021-12-02 11:00 ` Sam Protsenko
2021-12-02 20:44 ` Rob Herring
2021-12-03 18:39 ` Sam Protsenko
2021-11-30 19:31 ` Rob Herring
2021-12-03 19:35 ` Sam Protsenko
2021-12-03 20:40 ` Rob Herring
2021-12-04 0:18 ` Sam Protsenko
2021-12-04 11:31 ` Krzysztof Kozlowski
2021-12-04 11:28 ` Krzysztof Kozlowski
2021-12-04 14:27 ` Sam Protsenko
2021-11-30 11:13 ` [PATCH v2 RESEND 2/5] soc: samsung: Add USI driver Sam Protsenko
2021-12-01 10:52 ` Andy Shevchenko
2021-12-03 15:31 ` Sam Protsenko
2021-11-30 11:13 ` [PATCH v2 RESEND 3/5] tty: serial: samsung: Remove USI initialization Sam Protsenko
2021-12-01 10:54 ` Andy Shevchenko
2021-12-03 16:22 ` Sam Protsenko
2021-12-04 11:22 ` Krzysztof Kozlowski
2021-11-30 11:13 ` [PATCH v2 RESEND 4/5] tty: serial: samsung: Enable console as module Sam Protsenko
2021-11-30 11:13 ` [PATCH v2 RESEND 5/5] tty: serial: samsung: Fix console registration from module Sam Protsenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_JsqJb4nMBoGLcf-bKpi5kEE+zXQ=dfo5JSBhrqPFeLnCsHw@mail.gmail.com' \
--to=robh@kernel.org \
--cc=chanho61.park@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jaewon02.kim@samsung.com \
--cc=jirislaby@kernel.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=semen.protsenko@linaro.org \
--cc=virag.david003@gmail.com \
--cc=youngmin.nam@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).