From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F5B0C433FE for ; Mon, 20 Sep 2021 12:57:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 49835610A8 for ; Mon, 20 Sep 2021 12:57:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230157AbhITM6w (ORCPT ); Mon, 20 Sep 2021 08:58:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:58228 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229719AbhITM6v (ORCPT ); Mon, 20 Sep 2021 08:58:51 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2DAE96109D; Mon, 20 Sep 2021 12:57:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632142645; bh=3Y4gQvacVMDsvloS8gj8JrRb56U+3j+/P9qgEmbnLxQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=t1/6VbpWrRN93zO/7PLoh+fho0IqhrImeOpjdU4IY33UR2RAo7KLD276fmnMAqpg8 jCF6414qDCbijwCEbh81qJABpbSW3o1mSNMt+CitGM2rzApfyMATlyU3QFE4BoEArv R6FKYy/zO//2UHZgqUlfWafI78znpa+tbcapZu+vLR/lfXcqteI6kLj2ANMBlncaW5 Ui37uFBr0wFioz20MQzDVrJnIAhTN7NUMZFYBt0mWrniRdWQWCeEW2OzX9EHbyW7x7 TZWwQjqDLn81DMH9k4YnT/5wVaC+QtBcwDo6qwbQ7VO56O2zlqYW3UlhGkFhwOpyJn S1Hl8sOxy1YNQ== Received: by mail-ed1-f51.google.com with SMTP id dj4so4947047edb.5; Mon, 20 Sep 2021 05:57:25 -0700 (PDT) X-Gm-Message-State: AOAM532RAds5bAaN7qhvT36q0eww3Y2EF7DoaTxiH4KBWYoiY7Al2O+a O6lD7jTFW2dPaQeBfy6Zhja6yVzJEJGq+cTSKw== X-Google-Smtp-Source: ABdhPJwxl4M7JwIYLhEMizLmntOnoBCcnFt6nsvNmWy/WrfKk4jbby+1tLrXqVYlYpjSu+es0W80TyrsSkRSdBrRY+s= X-Received: by 2002:a50:e004:: with SMTP id e4mr29223066edl.164.1632142643564; Mon, 20 Sep 2021 05:57:23 -0700 (PDT) MIME-Version: 1.0 References: <1630686919-19495-1-git-send-email-spujar@nvidia.com> <1630686919-19495-3-git-send-email-spujar@nvidia.com> In-Reply-To: <1630686919-19495-3-git-send-email-spujar@nvidia.com> From: Rob Herring Date: Mon, 20 Sep 2021 07:57:12 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 2/3] ASoC: Use schema reference for sound-name-prefix To: Sameer Pujar Cc: Mark Brown , Liam Girdwood , Thierry Reding , Jon Hunter , Stephan Gerhold , Jerome Brunet , Linux-ALSA , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , linux-tegra Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Sep 3, 2021 at 11:36 AM Sameer Pujar wrote: > > Use schema reference for 'sound-name-prefix' property wherever > necessary. > > Signed-off-by: Sameer Pujar > Cc: Jerome Brunet > Cc: Stephan Gerhold > Cc: Rob Herring > Reviewed-by: Jerome Brunet > Reviewed-by: Rob Herring > --- [...] > diff --git a/Documentation/devicetree/bindings/sound/nxp,tfa989x.yaml b/Documentation/devicetree/bindings/sound/nxp,tfa989x.yaml > index ffb8fcf..68e5ad2 100644 > --- a/Documentation/devicetree/bindings/sound/nxp,tfa989x.yaml > +++ b/Documentation/devicetree/bindings/sound/nxp,tfa989x.yaml > @@ -9,6 +9,9 @@ title: NXP/Goodix TFA989X (TFA1) Audio Amplifiers > maintainers: > - Stephan Gerhold > > +allOf: > + - $ref: name-prefix.yaml# > + > properties: > compatible: > enum: > @@ -21,12 +24,6 @@ properties: > '#sound-dai-cells': > const: 0 > > - sound-name-prefix: You can't remove the property. This is now a warning in linux-next: Documentation/devicetree/bindings/sound/nxp,tfa989x.example.dt.yaml: audio-codec@34: 'sound-name-prefix' does not match any of the regexes: 'pinctrl-[0-9]+' From schema: /builds/robherring/linux-dt/Documentation/devicetree/bindings/sound/nxp,tfa989x.yaml Documentation/devicetree/bindings/sound/nxp,tfa989x.example.dt.yaml: audio-codec@36: 'sound-name-prefix' does not match any of the regexes: 'pinctrl-[0-9]+' From schema: /builds/robherring/linux-dt/Documentation/devicetree/bindings/sound/nxp,tfa989x.yaml Just 'sound-name-prefix: true' is fine > - $ref: /schemas/types.yaml#/definitions/string > - description: > - Used as prefix for sink/source names of the component. Must be a > - unique string among multiple instances of the same component. > - > vddd-supply: > description: regulator phandle for the VDDD power supply. > > diff --git a/Documentation/devicetree/bindings/sound/rt5659.txt b/Documentation/devicetree/bindings/sound/rt5659.txt > index c473df5..013f534 100644 > --- a/Documentation/devicetree/bindings/sound/rt5659.txt > +++ b/Documentation/devicetree/bindings/sound/rt5659.txt > @@ -42,7 +42,7 @@ Optional properties: > - realtek,ldo1-en-gpios : The GPIO that controls the CODEC's LDO1_EN pin. > - realtek,reset-gpios : The GPIO that controls the CODEC's RESET pin. > > -- sound-name-prefix: Please refer to name-prefix.txt > +- sound-name-prefix: Please refer to name-prefix.yaml > > - ports: A Codec may have a single or multiple I2S interfaces. These > interfaces on Codec side can be described under 'ports' or 'port'. > diff --git a/Documentation/devicetree/bindings/sound/simple-audio-mux.yaml b/Documentation/devicetree/bindings/sound/simple-audio-mux.yaml > index 5986d1f..c597d9d 100644 > --- a/Documentation/devicetree/bindings/sound/simple-audio-mux.yaml > +++ b/Documentation/devicetree/bindings/sound/simple-audio-mux.yaml > @@ -13,6 +13,9 @@ description: | > Simple audio multiplexers are driven using gpios, allowing to select which of > their input line is connected to the output line. > > +allOf: > + - $ref: name-prefix.yaml# > + > properties: > compatible: > const: simple-audio-mux > @@ -21,12 +24,6 @@ properties: > description: | > GPIOs used to select the input line. > > - sound-name-prefix: Here too, but I guess we don't have any example to throw a warning?