From: Rob Herring <robh+dt@kernel.org>
To: Pavel Fedin <p.fedin@samsung.com>
Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Grant Likely <grant.likely@linaro.org>
Subject: Re: [PATCH v2 2/2] PCI: of: Ignore resources with failed translation
Date: Tue, 13 Oct 2015 15:10:57 -0500 [thread overview]
Message-ID: <CAL_JsqJd3MisGEEahkx=46AiTBgLah42tL3ozzvkPiLtwCTG+Q@mail.gmail.com> (raw)
In-Reply-To: <3604931244806840dd12ff9663671b52d2acd951.1444288748.git.p.fedin@samsung.com>
On Thu, Oct 8, 2015 at 2:24 AM, Pavel Fedin <p.fedin@samsung.com> wrote:
> This patch allows PCI host controller to function even if part of resources
> is unusable for some reason. An example is non-LPAE kernel on a machine
> which has some 64-bit resources. Unusable resources will be just skipped
> instead of a complete failure.
>
> Signed-off-by: Pavel Fedin <p.fedin@samsung.com>
Applied, thanks.
Rob
> ---
> drivers/of/of_pci.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/of/of_pci.c b/drivers/of/of_pci.c
> index 5751dc5..ea7c2b6 100644
> --- a/drivers/of/of_pci.c
> +++ b/drivers/of/of_pci.c
> @@ -223,8 +223,10 @@ int of_pci_get_host_bridge_resources(struct device_node *dev,
> }
>
> err = of_pci_range_to_resource(&range, dev, res);
> - if (err)
> - goto conversion_failed;
> + if (err) {
> + kfree(res);
> + continue;
> + }
>
> if (resource_type(res) == IORESOURCE_IO) {
> if (!io_base) {
> --
> 2.4.4
>
next prev parent reply other threads:[~2015-10-13 20:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-08 7:24 [PATCH v2 0/2] PCI: of: Fix handling 64-bit PCI resources on non-LPAE kernels Pavel Fedin
2015-10-08 7:24 ` [PATCH v2 1/2] PCI: of: Add 64-bit address recognition without LPAE support Pavel Fedin
2015-10-13 20:10 ` Rob Herring
2015-10-08 7:24 ` [PATCH v2 2/2] PCI: of: Ignore resources with failed translation Pavel Fedin
2015-10-13 20:10 ` Rob Herring [this message]
2015-10-13 20:09 ` [PATCH v2 0/2] PCI: of: Fix handling 64-bit PCI resources on non-LPAE kernels Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_JsqJd3MisGEEahkx=46AiTBgLah42tL3ozzvkPiLtwCTG+Q@mail.gmail.com' \
--to=robh+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=grant.likely@linaro.org \
--cc=linux-pci@vger.kernel.org \
--cc=p.fedin@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).