From: Rob Herring <robh+dt@kernel.org>
To: Sameer Pujar <spujar@nvidia.com>
Cc: Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jon Hunter <jonathanh@nvidia.com>,
Stephan Gerhold <stephan@gerhold.net>,
Jerome Brunet <jbrunet@baylibre.com>,
aleandre.belloni@bootlin.com,
Linux-ALSA <alsa-devel@alsa-project.org>,
devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-tegra <linux-tegra@vger.kernel.org>,
Bard Liao <bardliao@realtek.com>
Subject: Re: [PATCH 2/3] ASoC: Use schema reference for sound-name-prefix
Date: Wed, 1 Sep 2021 11:58:40 -0500 [thread overview]
Message-ID: <CAL_JsqJgqyGGF=SwEox6LkR_P8AR+c30AWNejA6UiCCh+U55Pg@mail.gmail.com> (raw)
In-Reply-To: <1630513111-18776-3-git-send-email-spujar@nvidia.com>
On Wed, Sep 1, 2021 at 11:19 AM Sameer Pujar <spujar@nvidia.com> wrote:
>
> Use schema reference for 'sound-name-prefix' property wherever
> necessary.
>
> Signed-off-by: Sameer Pujar <spujar@nvidia.com>
> Cc: Jerome Brunet <jbrunet@baylibre.com>
> Cc: Stephan Gerhold <stephan@gerhold.net>
> Cc: bardliao@realtek.com
> Cc: Alexandre Belloni <aleandre.belloni@bootlin.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> ---
> Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml | 7 +------
> Documentation/devicetree/bindings/sound/nvidia,tegra210-dmic.yaml | 7 +------
> Documentation/devicetree/bindings/sound/nvidia,tegra210-i2s.yaml | 7 +------
> Documentation/devicetree/bindings/sound/nxp,tfa989x.yaml | 5 +----
> Documentation/devicetree/bindings/sound/rt5659.txt | 2 +-
> Documentation/devicetree/bindings/sound/simple-audio-mux.yaml | 5 +----
> 6 files changed, 6 insertions(+), 27 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml
> index 5f6b37c..ae04a11 100644
> --- a/Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml
> +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml
> @@ -48,12 +48,7 @@ properties:
>
> sound-name-prefix:
> pattern: "^DSPK[1-9]$"
> - $ref: /schemas/types.yaml#/definitions/string
> - description:
> - Used as prefix for sink/source names of the component. Must be a
> - unique string among multiple instances of the same component.
> - The name can be "DSPK1" or "DSPKx", where x depends on the maximum
> - available instances on a Tegra SoC.
> + $ref: "name-prefix.yaml#/properties/sound-name-prefix"
This is generally not how we reference common properties.
Either you add a $ref to the whole schema document at the top level of
this one or add a 'select: true' in name-prefix.yaml.
Rob
next prev parent reply other threads:[~2021-09-01 16:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-01 16:18 [PATCH 0/3] Convert name-prefix doc to json-schema Sameer Pujar
2021-09-01 16:18 ` [PATCH 1/3] ASoC: Add json-schema documentation for sound-name-prefix Sameer Pujar
2021-09-01 16:18 ` [PATCH 2/3] ASoC: Use schema reference " Sameer Pujar
2021-09-01 16:58 ` Rob Herring [this message]
2021-09-01 16:18 ` [PATCH 3/3] ASoC: Remove name-prefix.txt Sameer Pujar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_JsqJgqyGGF=SwEox6LkR_P8AR+c30AWNejA6UiCCh+U55Pg@mail.gmail.com' \
--to=robh+dt@kernel.org \
--cc=aleandre.belloni@bootlin.com \
--cc=alsa-devel@alsa-project.org \
--cc=bardliao@realtek.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=jonathanh@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=spujar@nvidia.com \
--cc=stephan@gerhold.net \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).