From: Rob Herring <robh@kernel.org>
To: Niklas Cassel <nks@flawful.org>
Cc: "Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Heiko Stuebner" <heiko@sntech.de>,
"Shawn Lin" <shawn.lin@rock-chips.com>,
"Simon Xue" <xxm@rock-chips.com>,
"Damien Le Moal" <dlemoal@kernel.org>,
"Sebastian Reichel" <sebastian.reichel@collabora.com>,
"Serge Semin" <fancer.lancer@gmail.com>,
"Niklas Cassel" <niklas.cassel@wdc.com>,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v3 1/6] dt-bindings: PCI: dwc: rockchip: Add mandatory atu reg
Date: Fri, 27 Oct 2023 10:58:28 -0500 [thread overview]
Message-ID: <CAL_JsqJh6aJb7_qsVnVNEABBg2utf0FPN+qYyOfsF2dAfZpd0w@mail.gmail.com> (raw)
In-Reply-To: <20231027145422.40265-2-nks@flawful.org>
On Fri, Oct 27, 2023 at 9:56 AM Niklas Cassel <nks@flawful.org> wrote:
>
> From: Niklas Cassel <niklas.cassel@wdc.com>
>
> Even though rockchip-dw-pcie.yaml inherits snps,dw-pcie.yaml
> using:
>
> allOf:
> - $ref: /schemas/pci/snps,dw-pcie.yaml#
>
> and snps,dw-pcie.yaml does have the atu reg defined, in order to be
> able to use this reg, while still making sure 'make CHECK_DTBS=y'
> pass, we need to add this reg to rockchip-dw-pcie.yaml.
>
> All compatible strings (rockchip,rk3568-pcie and rockchip,rk3588-pcie)
> should have this reg.
>
> The regs in the example are updated to actually match pcie3x2 on rk3568.
Breaking compatibility on these platforms is okay because ...?
>
> Signed-off-by: Niklas Cassel <niklas.cassel@wdc.com>
> ---
> .../devicetree/bindings/pci/rockchip-dw-pcie.yaml | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
next prev parent reply other threads:[~2023-10-27 15:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-27 14:54 [PATCH v3 0/6] rockchip DWC PCIe improvements Niklas Cassel
2023-10-27 14:54 ` [PATCH v3 1/6] dt-bindings: PCI: dwc: rockchip: Add mandatory atu reg Niklas Cassel
2023-10-27 15:58 ` Rob Herring [this message]
2023-10-27 16:14 ` Niklas Cassel
2023-10-27 17:03 ` Rob Herring
2023-10-28 12:11 ` Niklas Cassel
2023-10-30 17:39 ` Rob Herring
2023-10-27 17:07 ` Heiko Stübner
2023-10-27 14:54 ` [PATCH v3 2/6] dt-bindings: PCI: dwc: rockchip: Add optional dma interrupts Niklas Cassel
2023-10-30 17:40 ` Rob Herring
2023-10-31 1:10 ` Serge Semin
2023-10-31 15:51 ` Niklas Cassel
2023-11-01 22:23 ` Bjorn Helgaas
2023-10-27 14:54 ` [PATCH v3 3/6] arm64: dts: rockchip: drop unused properties num-{ib,ob}-windows Niklas Cassel
2023-10-31 1:14 ` Serge Semin
2023-10-27 14:54 ` [PATCH v3 4/6] arm64: dts: rockchip: add missing mandatory rk3568 PCIe atu reg Niklas Cassel
2023-10-27 14:54 ` [PATCH v3 5/6] arm64: dts: rockchip: add missing mandatory rk3588 " Niklas Cassel
2023-10-27 14:54 ` [PATCH v3 6/6] arm64: dts: rockchip: add missing rk3588 PCIe eDMA interrupts Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqJh6aJb7_qsVnVNEABBg2utf0FPN+qYyOfsF2dAfZpd0w@mail.gmail.com \
--to=robh@kernel.org \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlemoal@kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=heiko@sntech.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=niklas.cassel@wdc.com \
--cc=nks@flawful.org \
--cc=sebastian.reichel@collabora.com \
--cc=shawn.lin@rock-chips.com \
--cc=xxm@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).